Re: [PATCH net-next v6 00/23] WireGuard: Secure Network Tunnel

2018-09-27 Thread Jason A. Donenfeld
Hi Eric, On Fri, Sep 28, 2018 at 6:55 AM Eric Biggers wrote: > And you still haven't answered my question about adding a new algorithm that > is > useful to have in both APIs. You're proposing that in most cases the crypto > API > part will need to go through Herbert while the implementation w

Re: [PATCH] crypto: qat - Fix KASAN stack-out-of-bounds bug in adf_probe()

2018-09-27 Thread Herbert Xu
On Sat, Sep 22, 2018 at 08:41:55PM -0400, Waiman Long wrote: > The following KASAN warning was printed when booting a 64-bit kernel > on some systems with Intel CPUs: > > [ 44.512826] > == > [ 44.520165] BUG: KASAN: stack-out-of-

Re: [PATCH] crypto: mxs-dcp - Fix wait logic on chan threads

2018-09-27 Thread Herbert Xu
On Fri, Sep 21, 2018 at 06:03:18PM +0300, Leonard Crestez wrote: > When compiling with CONFIG_DEBUG_ATOMIC_SLEEP=y the mxs-dcp driver > prints warnings such as: > > WARNING: CPU: 0 PID: 120 at kernel/sched/core.c:7736 __might_sleep+0x98/0x9c > do not call blocking ops when !TASK_RUNNING; state=1 s

Re: [PATCH] crypto : chtls: remove redundant null pointer check before kfree_skb

2018-09-27 Thread Herbert Xu
On Thu, Sep 20, 2018 at 05:57:16PM +0800, zhong jiang wrote: > kfree_skb has taken the null pointer into account. hence it is safe > to remove the redundant null pointer check before kfree_skb. > > Signed-off-by: zhong jiang Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor

Re: [PATCH] crypto: cavium: remove redundant null pointer check before kfree

2018-09-27 Thread Herbert Xu
On Fri, Sep 21, 2018 at 09:30:15PM +0800, zhong jiang wrote: > kfree has taken the null pointer into account. hence it is safe > to remove the redundant null pointer check before kfree. > > Signed-off-by: zhong jiang Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.o

Re: [PATCH cryptodev-2.6 1/3] crypto: cavium/nitrox - added support to identify the NITROX device partname.

2018-09-27 Thread Herbert Xu
On Fri, Sep 21, 2018 at 05:08:00PM +0530, Srikanth Jampala wrote: > Get the device partname based on it's capabilities like, > core frequency, number of cores and revision id. > > Signed-off-by: Srikanth Jampala > --- > drivers/crypto/cavium/nitrox/nitrox_csr.h | 111 + > dr

Re: [PATCH 0/3] crypto: OFB and tests

2018-09-27 Thread Herbert Xu
On Thu, Sep 20, 2018 at 02:18:37PM +0100, Gilad Ben-Yossef wrote: > Add OFB mode generic implementation and more SM4 tests > > Gilad Ben-Yossef (3): > crypto: testmgr: update sm4 test vectors > crypto: add output feedback mode > crypto: tcrypt: add OFB functional tests > > crypto/Kconfig

Re: [PATCH 1/1] crypto:chelsio: Fix memory corruption in DMA Mapped buffers.

2018-09-27 Thread Herbert Xu
On Wed, Sep 19, 2018 at 10:42:16PM +0530, Harsh Jain wrote: > Update PCI Id in "cpl_rx_phys_dsgl" header. In case pci_chan_id and > tx_chan_id are not derived from same queue, H/W can send request > completion indication before completing DMA Transfer. > > Herbert, It would be good if fix can be m

Re: [PATCH] crypto: tcrypt - remove remnants of pcomp-based zlib

2018-09-27 Thread Herbert Xu
On Wed, Sep 19, 2018 at 05:54:21PM +0300, Horia Geantă wrote: > Commit 110492183c4b ("crypto: compress - remove unused pcomp interface") > removed pcomp interface but missed cleaning up tcrypt. > > Signed-off-by: Horia Geantă Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondo

Re: [PATCH v3 0/2] crypto: Implement a generic crypto statistics

2018-09-27 Thread Herbert Xu
On Wed, Sep 19, 2018 at 10:10:53AM +, Corentin Labbe wrote: > This patch is a try to implement a generic crypto driver statistics. > The goal is to have an "ifconfig" for crypto device. > > Some driver tried to implement this via a debugfs interface. > > This serie do it directly in the crypt

Re: [PATCH crypto-next 00/23] crypto: skcipher - Remove VLA usage

2018-09-27 Thread Herbert Xu
On Tue, Sep 18, 2018 at 07:10:37PM -0700, Kees Cook wrote: > This is the full follow-up to earlier discussions[1] that suggested > adding a new struct crypto_sync_skcipher to handle the VLA removal from > SKCIPHER_REQUEST_ON_STACK. > > This series is effectively a no-op change: everything is a wra

Re: [PATCH v2 0/4] crypto: s5p-sss: Fix and add aes-ctr support

2018-09-27 Thread Herbert Xu
On Mon, Sep 17, 2018 at 05:09:26PM +0200, Christoph Manszewski wrote: > Hello, > > This patch series adds aes-ctr support in s5p-sss.c driver. Additionally it > it provides a fix, and a minor code cleanup. > > Patch 1 contains a simple fix, of a possible race condition. > Patches 2-3 are code cle

Re: [PATCH] crypto: fix a memory leak in rsa-kcs1pad's encryption mode

2018-09-27 Thread Herbert Xu
On Mon, Sep 17, 2018 at 08:24:32PM +0300, Dan Aloni wrote: > The encryption mode of pkcs1pad never uses out_sg and out_buf, so > there's no need to allocate the buffer, which presently is not even > being freed. > > CC: Herbert Xu > CC: linux-crypto@vger.kernel.org > CC: "David S. Miller" > Sign

Re: [PATCH net-next v6 00/23] WireGuard: Secure Network Tunnel

2018-09-27 Thread Eric Biggers
Hi Jason, On Fri, Sep 28, 2018 at 04:35:48AM +0200, Jason A. Donenfeld wrote: > Hi Eric, > > On Thu, Sep 27, 2018 at 06:17:27PM -0700, Eric Biggers wrote: > > So, Zinc will simultaneously replace the current crypto implementations, > > *and* > > be "orthogonal" and "separate" from all the crypto

Re: [PATCH net-next v6 00/23] WireGuard: Secure Network Tunnel

2018-09-27 Thread Jason A. Donenfeld
Hi Eric, On Thu, Sep 27, 2018 at 06:17:27PM -0700, Eric Biggers wrote: > So, Zinc will simultaneously replace the current crypto implementations, *and* > be "orthogonal" and "separate" from all the crypto code currently maintained > by > Herbert? You can't have your cake and eat it too... The p

Re: [PATCH net-next v6 00/23] WireGuard: Secure Network Tunnel

2018-09-27 Thread Eric Biggers
On Thu, Sep 27, 2018 at 11:35:39PM +0200, Jason A. Donenfeld wrote: > Hi Eric, > > On Thu, Sep 27, 2018 at 8:29 PM Eric Biggers wrote: > > Why is Herbert Xu's existing crypto tree being circumvented, especially for > > future patches (the initial merge isn't quite as important as that's a > > on

Re: [PATCH net-next v6 23/23] net: WireGuard secure network tunnel

2018-09-27 Thread Jason A. Donenfeld
On Fri, Sep 28, 2018 at 12:37 AM Jason A. Donenfeld wrote: > Will do. v7 will include the wg_ prefix. $ nm *.o | while read a b c; do [[ $b == T ]] && echo $c; done | grep -v ^wg_ cleanup_module init_module Success.

Re: [PATCH net-next v6 23/23] net: WireGuard secure network tunnel

2018-09-27 Thread Jason A. Donenfeld
Hi Andrew, Thanks for following up with this. On Thu, Sep 27, 2018 at 3:15 AM Andrew Lunn wrote: > I know you have been concentrating on the crypto code, so i'm not > expecting too many changes at the moment in the network code. I should be addressing things in parallel, actually, so I'm happy

Re: [PATCH net-next v6 00/23] WireGuard: Secure Network Tunnel

2018-09-27 Thread Jason A. Donenfeld
Hi Eric, On Thu, Sep 27, 2018 at 8:29 PM Eric Biggers wrote: > Why is Herbert Xu's existing crypto tree being circumvented, especially for > future patches (the initial merge isn't quite as important as that's a > one-time > event)? I like being able to check out cryptodev to test upcoming cryp

Re: [PATCH] crypto/morus(640,1280) - make crypto_...-algs static

2018-09-27 Thread Ondrej Mosnáček
št 27. 9. 2018 o 0:50 napísal(a): > sparse complains thusly: > > CHECK arch/x86/crypto/morus640-sse2-glue.c > arch/x86/crypto/morus640-sse2-glue.c:38:1: warning: symbol > 'crypto_morus640_sse2_algs' was not declared. Should it be static? > CHECK arch/x86/crypto/morus1280-sse2-glue.c > arc

Re: [PATCH net-next v6 00/23] WireGuard: Secure Network Tunnel

2018-09-27 Thread Eric Biggers
On Tue, Sep 25, 2018 at 04:55:59PM +0200, Jason A. Donenfeld wrote: > > It is intended that this entire patch series enter the kernel through > DaveM's net-next tree. Subsequently, WireGuard patches will go through > DaveM's net-next tree, while Zinc patches will go through Greg KH's tree. > Why

Re: [PATCH net-next v6 07/23] zinc: ChaCha20 ARM and ARM64 implementations

2018-09-27 Thread Jason A. Donenfeld
On Thu, Sep 27, 2018 at 6:27 PM Andy Lutomirski wrote: > I would add another consideration: if you can get better latency with > negligible overhead (0.1%? 0.05%), then that might make sense too. For > example, it seems plausible that checking need_resched() every few blocks > adds basically no

Re: [PATCH net-next v6 07/23] zinc: ChaCha20 ARM and ARM64 implementations

2018-09-27 Thread Andy Lutomirski
> On Sep 27, 2018, at 8:19 AM, Jason A. Donenfeld wrote: > > Hey again Thomas, > >> On Thu, Sep 27, 2018 at 3:26 PM Jason A. Donenfeld wrote: >> >> Hi Thomas, >> >> I'm trying to optimize this for crypto performance while still taking >> into account preemption concerns. I'm having a bit o

Re: [PATCH net-next v6 07/23] zinc: ChaCha20 ARM and ARM64 implementations

2018-09-27 Thread Jason A. Donenfeld
Hey again Thomas, On Thu, Sep 27, 2018 at 3:26 PM Jason A. Donenfeld wrote: > > Hi Thomas, > > I'm trying to optimize this for crypto performance while still taking > into account preemption concerns. I'm having a bit of trouble figuring > out a way to determine numerically what the upper bounds

Re: [PATCH net-next v6 07/23] zinc: ChaCha20 ARM and ARM64 implementations

2018-09-27 Thread Jason A. Donenfeld
Hi Thomas, I'm trying to optimize this for crypto performance while still taking into account preemption concerns. I'm having a bit of trouble figuring out a way to determine numerically what the upper bounds for this stuff looks like. I'm sure I could pick a pretty sane number that's arguably oka

Re: KASAN: use-after-free Read in generic_gcmaes_encrypt

2018-09-27 Thread Steffen Klassert
On Thu, Sep 27, 2018 at 10:35:48AM +0200, Ard Biesheuvel wrote: > (+ Stefan) > > On Wed, 26 Sep 2018 at 22:24, syzbot > wrote: > > > > Hello, > > > > syzbot found the following crash on: > > > > HEAD commit:739d0def85ca Merge branch 'hv_netvsc-Support-LRO-RSC-in-th.. > > git tree: net-n

Re: KASAN: use-after-free Read in generic_gcmaes_encrypt

2018-09-27 Thread Ard Biesheuvel
(+ Stefan) On Wed, 26 Sep 2018 at 22:24, syzbot wrote: > > Hello, > > syzbot found the following crash on: > > HEAD commit:739d0def85ca Merge branch 'hv_netvsc-Support-LRO-RSC-in-th.. > git tree: net-next > console output: https://syzkaller.appspot.com/x/log.txt?x=1146ffae40 > kerne