Re: [RFCv2 PATCH 0/7] A General Accelerator Framework, WarpDrive

2018-09-19 Thread Kenneth Lee
On Tue, Sep 18, 2018 at 09:03:14AM -0400, Jerome Glisse wrote: > Date: Tue, 18 Sep 2018 09:03:14 -0400 > From: Jerome Glisse > To: Kenneth Lee > CC: Kenneth Lee , Alex Williamson > , Herbert Xu , > k...@vger.kernel.org, Jonathan Corbet , Greg Kroah-Hartman > , Joerg Roedel , > linux-...@vger.

Re: random(4) and VMs

2018-09-19 Thread Theodore Y. Ts'o
On Tue, Sep 18, 2018 at 01:00:31PM -0400, Sandy Harris wrote: > Solutions have been proposed by various people. If I understand them > right, Ted Ts'o suggests modifying the boot loader to provide some > entropy & John Denker suggests that every machine should be > provisioned with some entropy in

Re: [PATCH crypto-next 03/23] lib80211: Remove VLA usage of skcipher

2018-09-19 Thread Johannes Berg
On Tue, 2018-09-18 at 19:10 -0700, Kees Cook wrote: > In the quest to remove all stack VLA usage from the kernel[1], this > replaces struct crypto_skcipher and SKCIPHER_REQUEST_ON_STACK() usage > with struct crypto_sync_skcipher and SYNC_SKCIPHER_REQUEST_ON_STACK(), > which uses a fixed stack size.

Re: [PATCH net-next v5 00/20] WireGuard: Secure Network Tunnel

2018-09-19 Thread Ard Biesheuvel
On 18 September 2018 at 14:01, Jason A. Donenfeld wrote: > Hi Ard, > > On Tue, Sep 18, 2018 at 11:28:50AM -0700, Ard Biesheuvel wrote: >> On 18 September 2018 at 09:16, Jason A. Donenfeld wrote: >> > - While I initially wasn't going to do this for the initial >> > patchset, it was just so s

[PATCH 1/1] crypto:chelsio: Fix memory corruption in DMA Mapped buffers.

2018-09-19 Thread Harsh Jain
Update PCI Id in "cpl_rx_phys_dsgl" header. In case pci_chan_id and tx_chan_id are not derived from same queue, H/W can send request completion indication before completing DMA Transfer. Herbert, It would be good if fix can be merge to stable tree. For 4.14 kernel, It requires some update to avoid

Re: process? [Re: Crypto Fixes for 4.19]

2018-09-19 Thread Willy Tarreau
On Wed, Sep 19, 2018 at 09:48:42AM -0700, Randy Dunlap wrote: > On 9/19/18 9:40 AM, Greg KH wrote: > > On Wed, Sep 19, 2018 at 09:10:55AM -0700, Randy Dunlap wrote: > >> submitting-patches.rst says: > >> The Signed-off-by: tag indicates that the signer was involved in the > >> development of the pa

Re: [PATCH net-next v3 02/17] zinc: introduce minimal cryptography library

2018-09-19 Thread Ard Biesheuvel
On 18 September 2018 at 13:36, Jason A. Donenfeld wrote: > Hi Ard, > > On Tue, Sep 18, 2018 at 11:53:11AM -0700, Ard Biesheuvel wrote: >> On 17 September 2018 at 08:52, Jason A. Donenfeld wrote: >> > Hi Ard, >> > >> >> Given that you show no interest whatsoever in gaining an understanding >> of t

Re: process? [Re: Crypto Fixes for 4.19]

2018-09-19 Thread Randy Dunlap
On 9/19/18 9:40 AM, Greg KH wrote: > On Wed, Sep 19, 2018 at 09:10:55AM -0700, Randy Dunlap wrote: >> On 9/19/18 6:23 AM, Greg KH wrote: >>> On Wed, Sep 19, 2018 at 02:22:01PM +0800, Herbert Xu wrote: Hi Greg: This push fixes a potential boot hang in ccp and an incorrect CPU ca

Re: process? [Re: Crypto Fixes for 4.19]

2018-09-19 Thread Greg KH
On Wed, Sep 19, 2018 at 09:10:55AM -0700, Randy Dunlap wrote: > On 9/19/18 6:23 AM, Greg KH wrote: > > On Wed, Sep 19, 2018 at 02:22:01PM +0800, Herbert Xu wrote: > >> Hi Greg: > >> > >> This push fixes a potential boot hang in ccp and an incorrect > >> CPU capability check in aegis/morus on x86.

process? [Re: Crypto Fixes for 4.19]

2018-09-19 Thread Randy Dunlap
On 9/19/18 6:23 AM, Greg KH wrote: > On Wed, Sep 19, 2018 at 02:22:01PM +0800, Herbert Xu wrote: >> Hi Greg: >> >> This push fixes a potential boot hang in ccp and an incorrect >> CPU capability check in aegis/morus on x86. >> >> >> Please pull from >> >> git://git.kernel.org/pub/scm/linux/kernel/

[PATCH] crypto: tcrypt - remove remnants of pcomp-based zlib

2018-09-19 Thread Horia Geantă
Commit 110492183c4b ("crypto: compress - remove unused pcomp interface") removed pcomp interface but missed cleaning up tcrypt. Signed-off-by: Horia Geantă --- crypto/tcrypt.c | 7 +-- crypto/testmgr.h | 2 -- 2 files changed, 1 insertion(+), 8 deletions(-) diff --git a/crypto/tcrypt.c b/c

Re: [PATCH 1/2] Fix static checker warning

2018-09-19 Thread Dan Carpenter
Sounds reasonable. The subject needs a subsystem prefix and it might be better to make it more specific. Like so: [PATCH 1/2] crypto: ccp - potential uninitialized variable I don't know if Herbert fixes those things up himself normally? regards, dan carpenter

Re: [PATCH 2/2] Allow SEV firmware to be chosen based on Family and Model

2018-09-19 Thread Gary R Hook
On 09/14/2018 05:32 PM, Janakarajan Natarajan wrote: > During PSP initialization, there is an attempt to update the SEV firmware > by looking in /lib/firmware/amd/. Currently, sev.fw is the expected name > of the firmware blob. > > This patch will allow for firmware filenames based on the family a

Re: [PATCH 1/2] Fix static checker warning

2018-09-19 Thread Gary R Hook
On 09/14/2018 05:32 PM, Janakarajan Natarajan wrote: > Under certain configuration SEV functions can be defined as no-op. > In such a case error can be uninitialized. > > Initialize the variable to 0. > > Cc: Dan Carpenter > Reported-by: Dan Carpenter > Signed-off-by: Janakarajan Natarajan Ac

Re: [PATCH 2/2] Allow SEV firmware to be chosen based on Family and Model

2018-09-19 Thread Lendacky, Thomas
On 09/14/2018 05:32 PM, Janakarajan Natarajan wrote: > During PSP initialization, there is an attempt to update the SEV firmware > by looking in /lib/firmware/amd/. Currently, sev.fw is the expected name > of the firmware blob. > > This patch will allow for firmware filenames based on the family

Re: Crypto Fixes for 4.19

2018-09-19 Thread Greg KH
On Wed, Sep 19, 2018 at 02:22:01PM +0800, Herbert Xu wrote: > Hi Greg: > > This push fixes a potential boot hang in ccp and an incorrect > CPU capability check in aegis/morus on x86. > > > Please pull from > > git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6.git linus Now pull

Re: [PATCH net-next v5 20/20] net: WireGuard secure network tunnel

2018-09-19 Thread Andrew Lunn
On Wed, Sep 19, 2018 at 04:04:01AM +0200, Jason A. Donenfeld wrote: > Hi Andrew, > > On Wed, Sep 19, 2018 at 1:34 AM Andrew Lunn wrote: > > I see this BUG_ON() is still here. It really needs to be removed. It > > does not look like you need to crash the kernel here. Can you add in a > > test of l

Re: [PATCH net-next v5 07/20] zinc: Poly1305 generic C implementations and selftest

2018-09-19 Thread Jason A. Donenfeld
On Wed, Sep 19, 2018 at 1:50 PM Jason A. Donenfeld wrote: > > On Wed, Sep 19, 2018 at 6:19 AM Andy Lutomirski wrote: > > Can you not uglify the code a bit by using normal (non-compound) liberals > > as described in the response to that email? > > I can define a bunch of variables, and then strin

Re: [PATCH net-next v5 07/20] zinc: Poly1305 generic C implementations and selftest

2018-09-19 Thread Jason A. Donenfeld
On Wed, Sep 19, 2018 at 6:19 AM Andy Lutomirski wrote: > Can you not uglify the code a bit by using normal (non-compound) liberals as > described in the response to that email? I can define a bunch of variables, and then string them all together in an array at the end. This is a bit ugly and les

Re: [PATCH net-next v5 04/20] zinc: ChaCha20 x86_64 implementation

2018-09-19 Thread Jason A. Donenfeld
Hi Thomas, On Wed, Sep 19, 2018 at 8:13 AM Thomas Gleixner wrote: > Subset? Not really. Both MIT and BSD3-Clause are GPL2.0 compatible > licenses. And if your intention is to have those files MIT/BSD only, yes > then the single license identifier is the right thing. If you want it dual > licensed

[PATCH v3 1/2] crypto: Implement a generic crypto statistics

2018-09-19 Thread Corentin Labbe
This patch implement a generic way to get statistics about all crypto usages. Signed-off-by: Corentin Labbe --- crypto/Kconfig | 11 + crypto/Makefile | 1 + crypto/ahash.c | 21 +- crypto/algapi.c

[PATCH v3 2/2] crypto: tools: Add cryptostat userspace

2018-09-19 Thread Corentin Labbe
This patch adds an userspace tool for displaying kernel crypto API statistics. Signed-off-by: Corentin Labbe --- tools/crypto/getstat.c | 294 + 1 file changed, 294 insertions(+) create mode 100644 tools/crypto/getstat.c diff --git a/tools/crypto

[PATCH v3 0/2] crypto: Implement a generic crypto statistics

2018-09-19 Thread Corentin Labbe
This patch is a try to implement a generic crypto driver statistics. The goal is to have an "ifconfig" for crypto device. Some driver tried to implement this via a debugfs interface. This serie do it directly in the crypto API and give access to stats via the crypto_user(netlink) API. Then an use