Re: [PATCH] Performance Improvement in CRC16 Calculations.

2018-08-10 Thread Douglas Gilbert
On 2018-08-10 08:11 PM, Joe Perches wrote: On Fri, 2018-08-10 at 16:02 -0400, Nicolas Pitre wrote: On Fri, 10 Aug 2018, Joe Perches wrote: On Fri, 2018-08-10 at 14:12 -0500, Jeff Lien wrote: This patch provides a performance improvement for the CRC16 calculations done in read/write workloads

Re: [PATCH] Performance Improvement in CRC16 Calculations.

2018-08-10 Thread Nicolas Pitre
On Fri, 10 Aug 2018, Joe Perches wrote: > On Fri, 2018-08-10 at 16:02 -0400, Nicolas Pitre wrote: > > On Fri, 10 Aug 2018, Joe Perches wrote: > > > > > On Fri, 2018-08-10 at 14:12 -0500, Jeff Lien wrote: > > > > This patch provides a performance improvement for the CRC16 > > > > calculations don

Re: [PATCH] Performance Improvement in CRC16 Calculations.

2018-08-10 Thread Joe Perches
On Fri, 2018-08-10 at 16:02 -0400, Nicolas Pitre wrote: > On Fri, 10 Aug 2018, Joe Perches wrote: > > > On Fri, 2018-08-10 at 14:12 -0500, Jeff Lien wrote: > > > This patch provides a performance improvement for the CRC16 calculations > > > done in read/write > > > workloads using the T10 Type 1/

Re: [PATCH] Performance Improvement in CRC16 Calculations.

2018-08-10 Thread Douglas Gilbert
On 2018-08-10 03:12 PM, Jeff Lien wrote: This patch provides a performance improvement for the CRC16 calculations done in read/write workloads using the T10 Type 1/2/3 guard field. For example, today with sequential write workloads (one thread/CPU of IO) we consume 100% of the CPU because of t

Re: [PATCH] Performance Improvement in CRC16 Calculations.

2018-08-10 Thread Eric Biggers
On Fri, Aug 10, 2018 at 02:12:11PM -0500, Jeff Lien wrote: > This patch provides a performance improvement for the CRC16 calculations done > in read/write > workloads using the T10 Type 1/2/3 guard field. For example, today with > sequential write > workloads (one thread/CPU of IO) we consume 10

Re: [PATCH] Performance Improvement in CRC16 Calculations.

2018-08-10 Thread Nicolas Pitre
On Fri, 10 Aug 2018, Jeff Lien wrote: > This patch provides a performance improvement for the CRC16 calculations done > in read/write > workloads using the T10 Type 1/2/3 guard field. For example, today with > sequential write > workloads (one thread/CPU of IO) we consume 100% of the CPU becaus

Re: [PATCH] Performance Improvement in CRC16 Calculations.

2018-08-10 Thread Nicolas Pitre
On Fri, 10 Aug 2018, Joe Perches wrote: > On Fri, 2018-08-10 at 14:12 -0500, Jeff Lien wrote: > > This patch provides a performance improvement for the CRC16 calculations > > done in read/write > > workloads using the T10 Type 1/2/3 guard field. For example, today with > > sequential write > >

Re: [PATCH] Performance Improvement in CRC16 Calculations.

2018-08-10 Thread Joe Perches
On Fri, 2018-08-10 at 14:12 -0500, Jeff Lien wrote: > This patch provides a performance improvement for the CRC16 calculations done > in read/write > workloads using the T10 Type 1/2/3 guard field. For example, today with > sequential write > workloads (one thread/CPU of IO) we consume 100% of t

[PATCH] Performance Improvement in CRC16 Calculations.

2018-08-10 Thread Jeff Lien
This patch provides a performance improvement for the CRC16 calculations done in read/write workloads using the T10 Type 1/2/3 guard field. For example, today with sequential write workloads (one thread/CPU of IO) we consume 100% of the CPU because of the CRC16 computation bottleneck. Today's

Re: random: ensure use of aligned buffers with ChaCha20

2018-08-10 Thread Theodore Y. Ts'o
On Fri, Aug 10, 2018 at 08:20:51AM +0200, Stephan Mueller wrote: > > while (nbytes >= CHACHA20_BLOCK_SIZE) { > > int adjust = (unsigned long)buf & (sizeof(tmp[0]) - 1); > > > > extract_crng(buf); > > Why this line? > > > buf += CHACHA20_BLOCK_SIZE; Sorry,

Re: [RFC PATCH 0/7] A General Accelerator Framework, WarpDrive

2018-08-10 Thread Jerome Glisse
On Fri, Aug 10, 2018 at 11:39:13AM +0800, Kenneth Lee wrote: > On Thu, Aug 09, 2018 at 10:46:13AM -0400, Jerome Glisse wrote: > > Date: Thu, 9 Aug 2018 10:46:13 -0400 > > From: Jerome Glisse > > To: Kenneth Lee > > CC: Kenneth Lee , "Tian, Kevin" > > , Alex Williamson , > > Herbert Xu , "k...@v

Re: disabling psp in bios causes errors in dmesg

2018-08-10 Thread Tom Lendacky
On 8/10/2018 2:03 AM, Thomas Backlund wrote: > Hi, > > this is tested on kernel 4.17.14 > > hw: > > MSI X399 GAMING PRO CARBON AC (MS-7B09) bios 1.A0 > > AMD Ryzen Threadripper 1950X > > > Disabling psp in bios gets this in the logs: Hmm, I'm not familiar with that BIOS option so I'm not exa

Re: [RFC PATCH 0/7] A General Accelerator Framework, WarpDrive

2018-08-10 Thread Jean-Philippe Brucker
Hi Kenneth, On 10/08/18 04:39, Kenneth Lee wrote: >> You can achieve everything you want to achieve with existing upstream >> solution. Re-inventing a whole new driver infrastructure should really >> be motivated with strong and obvious reasons. > > I want to understand better of your idea. If I

[PATCH] chtls: fix null dereference chtls_free_uld()

2018-08-10 Thread Ganesh Goudar
call chtls_free_uld() only for the initialized cdev, this fixes NULL dereference in chtls_free_uld() Signed-off-by: Ganesh Goudar Signed-off-by: Atul Gupta --- drivers/crypto/chelsio/chtls/chtls.h | 5 + drivers/crypto/chelsio/chtls/chtls_main.c | 7 +-- 2 files changed, 10 inserti

disabling psp in bios causes errors in dmesg

2018-08-10 Thread Thomas Backlund
Hi, this is tested on kernel 4.17.14 hw: MSI X399 GAMING PRO CARBON AC (MS-7B09) bios 1.A0 AMD Ryzen Threadripper 1950X Disabling psp in bios gets this in the logs: [  246.748978] "echo 0 > /proc/sys/kernel/hung_task_timeout_secs" disables this message. [  246.748978] systemd-udevd   D