Re: [PATCH] random: add a config option to trust the CPU's hwrng

2018-08-04 Thread Theodore Y. Ts'o
On Sat, Aug 04, 2018 at 08:25:14PM -0400, Theodore Y. Ts'o wrote: > Depending on your hardware, no mouse motion might be necessary at all. > On my laptop (a Dell XPS 13 model 9370) using an dm-crypt protected > root disk, and running a Debian testing userspace, with a 4.18-rc6 > based kernel, the "

Re: [PATCH] random: add a config option to trust the CPU's hwrng

2018-08-04 Thread Theodore Y. Ts'o
On Sat, Aug 04, 2018 at 11:52:10PM +0200, Pavel Machek wrote: > > However, enabling config option means that the CRNG will be > > initialized with potentially information available to the CPU > > manufacturer and/or Nation States, and this persists *after* > > initialization / early boot. So to sa

Re: [PATCH] random: add a config option to trust the CPU's hwrng

2018-08-04 Thread Pavel Machek
Hi! On Wed 2018-07-18 10:26:25, Theodore Y. Ts'o wrote: > On Wed, Jul 18, 2018 at 09:22:13AM +0200, Yann Droneaud wrote: > > > > The text message should explain this is only relevant during > > initialization / early boot. > > > > The config option name should state this. > > There are other wo

[PATCH 0/2] crypto: arm64/ghash-ce - performance improvements

2018-08-04 Thread Ard Biesheuvel
Another bit of performance work on the GHASH driver: this time it is not the combined AES/GCM algorithm but the bare GHASH driver that gets updated. Even though ARM cores that implement the polynomical multiplication instructions that these routines depend on are guaranteed to also support the AES

[PATCH 2/2] crypto: arm64/ghash-ce - implement 4-way aggregation

2018-08-04 Thread Ard Biesheuvel
Enhance the GHASH implementation that uses 64-bit polynomial multiplication by adding support for 4-way aggregation. This more than doubles the performance, from 2.4 cycles per byte to 1.1 cpb on Cortex-A53. Signed-off-by: Ard Biesheuvel --- arch/arm64/crypto/ghash-ce-core.S | 122 ++

[PATCH 1/2] crypto: arm64/ghash-ce - replace NEON yield check with block limit

2018-08-04 Thread Ard Biesheuvel
Checking the TIF_NEED_RESCHED flag is disproportionately costly on cores with fast crypto instructions and comparatively slow memory accesses. On algorithms such as GHASH, which executes at ~1 cycle per byte on cores that implement support for 64 bit polynomial multiplication, there is really no n