Re: [PATCH v4 11/14] treewide: Prepare to remove VLA usage for AHASH_REQUEST_ON_STACK

2018-07-14 Thread Kees Cook
On Fri, Jul 13, 2018 at 3:14 AM, Arnd Bergmann wrote: > On Fri, Jul 13, 2018 at 8:00 AM, Kees Cook wrote: >> On Thu, Jul 12, 2018 at 10:20 PM, Herbert Xu >> wrote: >>> On Thu, Jul 12, 2018 at 10:17:29PM -0700, Kees Cook wrote: What is the correct value to use for AHASH_REQUEST_ON_STACK? >>>

[PATCH] random: mix rdrand with entropy sent in from userspace

2018-07-14 Thread Theodore Ts'o
Fedora has integrated the jitter entropy daemon to work around slow boot problems, especially on VM's that don't support virtio-rng: https://bugzilla.redhat.com/show_bug.cgi?id=1572944 It's understandable why they did this, but the Jitter entropy daemon works fundamentally on the principle: "

Re: [PATCH v4 11/14] treewide: Prepare to remove VLA usage for AHASH_REQUEST_ON_STACK

2018-07-14 Thread Kees Cook
On Sat, Jul 14, 2018 at 7:44 PM, Herbert Xu wrote: > On Fri, Jul 13, 2018 at 08:07:10PM -0700, Kees Cook wrote: >> >> On a plane today I started converting all these to shash. IIUC, it >> just looks like this (apologies for whitespace damage): > > Yes if it doesn't actually make use of SGs then sh

Re: [PATCH v4 11/14] treewide: Prepare to remove VLA usage for AHASH_REQUEST_ON_STACK

2018-07-14 Thread Herbert Xu
On Fri, Jul 13, 2018 at 08:07:10PM -0700, Kees Cook wrote: > > On a plane today I started converting all these to shash. IIUC, it > just looks like this (apologies for whitespace damage): Yes if it doesn't actually make use of SGs then shash would be the way to go. However, for SG users ahash is

[PATCH] crypto: sharah: Unregister correct algorithms for SAHARA 3

2018-07-14 Thread Michael Müller
This patch fixes two typos related to unregistering algorithms supported by SAHARAH 3. In sahara_register_algs the wrong algorithms are unregistered in case of an error. In sahara_unregister_algs the wrong array is used to determine the iteration count. Signed-off-by: Michael Müller --- Sorry for

crypto: sharah: Unregister correct algorithms for SAHARA 3

2018-07-14 Thread Michael Müller
This patch fixes two typos related to unregistering algorithms supported by SAHARAH 3. In sahara_register_algs the wrong algorithms are unregistered in case of an error. In sahara_unregister_algs the wrong array is used to determine the iteration count. Signed-off-by: Michael Müller --- drivers/

Re: [PATCH v5 3/6] crypto: Add Qcom prng driver

2018-07-14 Thread Linus Walleij
On Mon, Jul 9, 2018 at 8:20 AM Vinod Koul wrote: > This ports the Qcom prng from older hw_random driver. > > No change of functionality and move from hw_random to crypto > APIs is done. > > Signed-off-by: Vinod Koul FWIW: Reviewed-by: Linus Walleij > +config CRYPTO_DEV_QCOM_RNG > + tri