Re: [PATCH v4 11/14] treewide: Prepare to remove VLA usage for AHASH_REQUEST_ON_STACK

2018-07-13 Thread Kees Cook
On Thu, Jul 12, 2018 at 11:22 PM, Herbert Xu wrote: > On Thu, Jul 12, 2018 at 11:16:28PM -0700, Kees Cook wrote: >> >> Is this correct? It seems like you did the bulk of >> AHASH_REQUEST_ON_STACK conversions in 2016. Can shash grow an sg >> interface? > > shash does not need to grow an sg interfac

Re: [v18,3/7] iomap: introduce io{read|write}64_{lo_hi|hi_lo}

2018-07-13 Thread Guenter Roeck
On 07/13/2018 05:20 PM, Logan Gunthorpe wrote: On 13/07/18 05:38 PM, Guenter Roeck wrote: This patch causes a build failure in -next when building ppc:corenet64_smp_defconfig. Thanks for the report. This 64bit IO stuff is a bit of a mess. It looks like your corner case arch and config was ne

Re: [v18,3/7] iomap: introduce io{read|write}64_{lo_hi|hi_lo}

2018-07-13 Thread Logan Gunthorpe
On 13/07/18 05:38 PM, Guenter Roeck wrote: > This patch causes a build failure in -next when building > ppc:corenet64_smp_defconfig. Thanks for the report. This 64bit IO stuff is a bit of a mess. It looks like your corner case arch and config was never covered by the kbuild robot which has run

Re: [v18,3/7] iomap: introduce io{read|write}64_{lo_hi|hi_lo}

2018-07-13 Thread Guenter Roeck
ite32'? Several files are afected; this is only the first error reported. Bisect log is attached. Guenter --- # bad: [483d835c8189f0566a4cbbe47e74ffa314430e98] Add linux-next specific files for 20180713 # good: [1e4b044d22517cae7047c99038abb23243ca]

[PATCH] crypto: inside-secure - initialize first_rdesc to make GCC happy

2018-07-13 Thread Antoine Tenart
In the cipher safexcel_send_req function, GCC warns that first_rdesc may be used uninitialized. While this should never happen, this patch removes the warning by initializing this variable to NULL to make GCC happy. This was reported by the kbuild test robot. Signed-off-by: Antoine Tenart --- d

Re: [PATCH] crypto: padlock-aes - Fix Nano workaround data corruption

2018-07-13 Thread Jamie Heilman
Herbert Xu wrote: > This was detected by the self-test thanks to Ard's chunking patch. > > I finally got around to testing this out on my ancient Via box. It > turns out that the workaround got the assembly wrong and we end up > doing count + initial cycles of the loop instead of just count. > >

[PATCH] crypto: inside-secure - switch to SPDX identifiers

2018-07-13 Thread Antoine Tenart
Use the appropriate SPDX license identifiers and drop the license text. This patch is only cosmetic. Signed-off-by: Antoine Tenart --- drivers/crypto/inside-secure/safexcel.c| 5 + drivers/crypto/inside-secure/safexcel.h| 5 + drivers/crypto/inside-secure/safexcel_cipher.

Re: [PATCH 14/14] arm64: dts: marvell: armada-37xx: update the crypto engine compatible

2018-07-13 Thread Gregory CLEMENT
Hi Antoine, On jeu., juin 28 2018, Antoine Tenart wrote: > New compatibles are now supported by the Inside Secure SafeXcel driver. > As they are more specific than the old ones, they should be used > whenever possible. This patch updates the Marvell Armada 37xx device > tree accordingly. > > S

Re: [PATCH 13/14] arm64: dts: marvell: armada-cp110: update the crypto engine compatible

2018-07-13 Thread Gregory CLEMENT
Hi Antoine, On jeu., juin 28 2018, Antoine Tenart wrote: > New compatibles are now supported by the Inside Secure SafeXcel driver. > As they are more specific than the old ones, they should be used > whenever possible. This patch updates the Marvell cp110 device tree > accordingly. > > Signed-

Re: [PATCH v4] AF_ALG: Initialize sg_num_bytes in error code path

2018-07-13 Thread Herbert Xu
On Sat, Jul 07, 2018 at 08:41:47PM +0200, Stephan Müller wrote: > Changes v4: > * Add Fixes and CC line > > Changes v3: > * Fix syz testing line > > Changes v2: > * Addition of syz testing line > > ---8<--- > > The RX SGL in processing is already registered with the RX SGL tracking > list to su

Re: [PATCH] crypto: chtls - use 64-bit arithmetic instead of 32-bit

2018-07-13 Thread Herbert Xu
On Wed, Jul 04, 2018 at 11:37:20AM -0500, Gustavo A. R. Silva wrote: > Cast *val* to u64 in order to give the compiler complete > information about the proper arithmetic to use. > > Notice that such variable is used in a context that expects an > expression of type u64 (64 bits, unsigned) and the

Re: [PATCH] crypto: Fix Kconfig typo

2018-07-13 Thread Herbert Xu
On Mon, Jul 02, 2018 at 05:04:49AM +, Huang nut wrote: > Only find crc32-pclmul and crct10dif-pclmul. > > Signed-off-by: haco Your patch didn't make it to patchwork, possibly because it didn't make it to linux-crypto. Could you please resend? Thanks, -- Email: Herbert Xu Home Page: http:

Re: [PATCH v1 0/5] crypto: ccp - Driver updates 2018-07-03

2018-07-13 Thread Herbert Xu
On Tue, Jul 03, 2018 at 12:11:22PM -0500, Tom Lendacky wrote: > The following patches for the PSP support within the CCP driver are > included in this driver update series: > > - Fix a possible race condition when checking for command completion > - Add a message to indicate if the PSP function ha

Re: [PATCH v4 11/14] treewide: Prepare to remove VLA usage for AHASH_REQUEST_ON_STACK

2018-07-13 Thread Arnd Bergmann
On Fri, Jul 13, 2018 at 8:00 AM, Kees Cook wrote: > On Thu, Jul 12, 2018 at 10:20 PM, Herbert Xu > wrote: >> On Thu, Jul 12, 2018 at 10:17:29PM -0700, Kees Cook wrote: >>> What is the correct value to use for AHASH_REQUEST_ON_STACK? >> >> As I said to arrive at a fixed value you should examine al

[PATCH] crypto: padlock-aes - Fix Nano workaround data corruption

2018-07-13 Thread Herbert Xu
This was detected by the self-test thanks to Ard's chunking patch. I finally got around to testing this out on my ancient Via box. It turns out that the workaround got the assembly wrong and we end up doing count + initial cycles of the loop instead of just count. This obviously causes corruptio