[PATCH v5 4/6] dt-bindings: crypto: Add new compatible qcom,prng-ee

2018-07-08 Thread Vinod Koul
Later qcom chips support v2 of the prng, which exposes an EE (Execution Environment) for OS to use so add new compatible qcom,prng-ee for this. Signed-off-by: Vinod Koul --- Documentation/devicetree/bindings/crypto/qcom,prng.txt | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --gi

[PATCH v5 3/6] crypto: Add Qcom prng driver

2018-07-08 Thread Vinod Koul
This ports the Qcom prng from older hw_random driver. No change of functionality and move from hw_random to crypto APIs is done. Signed-off-by: Vinod Koul --- drivers/crypto/Kconfig| 11 +++ drivers/crypto/Makefile | 1 + drivers/crypto/qcom-rng.c | 208

[PATCH v5 5/6] crypto: qcom: Add support for prng-ee

2018-07-08 Thread Vinod Koul
Qcom 8996 and later chips features multiple Execution Environments (EE) and secure world is typically responsible for configuring the prng. Add driver data for qcom,prng as 0 and qcom,prng-ee as 1 and use that to skip initialization routine. Signed-off-by: Vinod Koul --- drivers/crypto/qcom-rng

[PATCH v5 6/6] crypto: qcom: Add ACPI support

2018-07-08 Thread Vinod Koul
From: Timur Tabi Add support for probing on ACPI systems, with ACPI HID QCOM8160. On ACPI systems, clocks are always enabled, the PRNG should already be enabled, and the register region is read-only. The driver only verifies that the hardware is already enabled never tries to disable or configur

[PATCH v5 2/6] dt-bindings: crypto: Move prng binding to crypto

2018-07-08 Thread Vinod Koul
Now that we are adding new driver for prng in crypto, move the binding as well. Signed-off-by: Vinod Koul --- Documentation/devicetree/bindings/{rng => crypto}/qcom,prng.txt | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename Documentation/devicetree/bindings/{rng => crypto}/qcom,prng.t

[PATCH v5 1/6] hwrng: remove msm hw_random driver

2018-07-08 Thread Vinod Koul
This driver is for a psedo-rng so should not be added in hwrng. Remove it so that it's replacement can be added. Signed-off-by: Vinod Koul --- drivers/char/hw_random/Kconfig | 13 --- drivers/char/hw_random/Makefile | 1 - drivers/char/hw_random/msm-rng.c | 183

[PATCH v5 0/6] crypto: Add Qcom PRNG support

2018-07-08 Thread Vinod Koul
This series removes the hwrng qcom driver and replaces it with crypto qcom driver and then adds support for Execution Environment (EE) found in v2 version of the hardware and ACPI support for these Changes in v5: - Update ACPI check and use generic driver data API Changes in v4: - Use memcpy fo

Re: [PATCH v4 6/6] crypto: qcom: Add ACPI support

2018-07-08 Thread Vinod
On 07-07-18, 13:05, Timur Tabi wrote: > On 7/5/18 1:07 AM, Vinod wrote: > > Yes we can add driver data in ACPI ID as well so code can be: > > > > if (!has_acpi_companion(&pdev->dev)) { > > rng->clk = devm_clk_get(&pdev->dev, "core"); > > if (IS_ERR(rng->c

JÓ HÍREK

2018-07-08 Thread Mrs. Ursula Alice Walton
Kedves Kedvezményezettem, Biztos vagyok benne, hogy ez a levél meglepetésként fog megjelenni, mivel még soha nem találkoztunk, és akkor is megkérdeznéd, hogy miért döntöttem úgy, hogy választottam Önt a világ számos internethasználója között. Pontosan, nem tudom megmondani, hogy miért választot

[cryptodev:master 45/63] drivers/crypto/inside-secure/safexcel_cipher.c:475:2: warning: 'first_rdesc' may be used uninitialized in this function

2018-07-08 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master head: 5c324a2ffa06f8b6fda59a77c6807acb9f45cfee commit: 9744fec95f0674fbf67b12c42c3784dc299dc904 [45/63] crypto: inside-secure - remove request list to improve performance config: powerpc-allmodconfig (attac

Re: Crypto Fixes for 4.18

2018-07-08 Thread Linus Torvalds
On Sun, Jul 8, 2018 at 9:20 AM Herbert Xu wrote: > > - Add missing RETs in x86 aegis/morus. Side note - I queried earlier during the discussion about this: how was this code taken despite having clearly never tested on _anything_? That's a serious question. Code that simply has never had any tes

Re: [PATCH v2 0/6] crypto: fixes and cleanups

2018-07-08 Thread Herbert Xu
On Sun, Jul 01, 2018 at 08:02:33AM +0100, Gilad Ben-Yossef wrote: > The patch set fixes ccree IV handling, finup() operation (provided > by Hadar Gat) and CTS-AES mode of operation along a code cleanup. > >

Re: [PATCH 0/6] crypto: remove redundant type specifications

2018-07-08 Thread Herbert Xu
On Sat, Jun 30, 2018 at 03:16:10PM -0700, Eric Biggers wrote: > Originally, algorithms had to declare their type in .cra_flags as a > CRYPTO_ALG_TYPE_* value. Some types of algorithms such as "cipher" > still have to do this. But now most algorithm types use different > top-level C data structure

Re: [PATCH] crypto: x86/sha256-mb - fix digest copy in sha256_mb_mgr_get_comp_job_avx2()

2018-07-08 Thread Herbert Xu
On Fri, Jun 29, 2018 at 02:14:35PM -0700, Eric Biggers wrote: > From: Eric Biggers > > There is a copy-paste error where sha256_mb_mgr_get_comp_job_avx2() > copies the SHA-256 digest state from sha256_mb_mgr::args::digest to > job_sha256::result_digest. Consequently, the sha256_mb algorithm > so

Re: [PATCH] crypto: MAINTAINERS - fix file path for SHA multibuffer code

2018-07-08 Thread Herbert Xu
On Fri, Jun 29, 2018 at 02:21:11PM -0700, Eric Biggers wrote: > From: Eric Biggers > > "arch/x86/crypto/sha*-mb" needs a trailing slash, since it refers to > directories. Otherwise get_maintainer.pl doesn't find the entry. > > Signed-off-by: Eric Biggers Patch applied. Thanks. -- Email: Her

Re: [PATCH 0/4] crypto: decrease priority of multibuffer SHA algorithms

2018-07-08 Thread Herbert Xu
On Fri, Jun 29, 2018 at 05:01:40PM -0700, Eric Biggers wrote: > From: Eric Biggers > > I found that not only was sha256_mb sometimes computing the wrong digest > (fixed by a separately sent patch), but under normal workloads it's > hundreds of times slower than sha256-avx2, due to the flush delay

Re: [PATCH 0/5] crypto: inside-secure - support more algorithms

2018-07-08 Thread Herbert Xu
On Thu, Jun 28, 2018 at 05:21:52PM +0200, Antoine Tenart wrote: > Hi all, > > This series adds support for more algorithms in the Inside Secure > SafeXcel cryptographic engine driver. Those new algorithms are: > - MD5 (and its hmac). > - DES (ECB and CBC). > - 3DES (ECB and CBC). > > The last pat

Re: [PATCH v2] crypto: DH - add public key verification test

2018-07-08 Thread Herbert Xu
On Wed, Jun 27, 2018 at 08:15:31AM +0200, Stephan Müller wrote: > Hi, > > Changes v2: > * addition of a check that mpi_alloc succeeds. > > ---8<--- > > According to SP800-56A section 5.6.2.1, the public key to be processed > for the DH operation shall be checked for appropriateness. The check >

Re: [PATCH 0/3] crypto: stm32 - Add power mamagement support

2018-07-08 Thread Herbert Xu
On Tue, Jun 26, 2018 at 02:52:43PM +0200, Lionel Debieve wrote: > This set of patches add pm and pm_runtime feature to stm32 crypto > drivers. > > Lionel Debieve (3): > crypto: stm32/cryp - Add power management support > crypto: stm32/hash - Add power management support > crypto: stm32/crc -

Re: [PATCH 00/14] crypto: inside-secure - EIP197d support

2018-07-08 Thread Herbert Xu
On Thu, Jun 28, 2018 at 05:15:30PM +0200, Antoine Tenart wrote: > Hi all, > > This series introduces the EIP197d engine support to the Inside Secure > SafeXcel cryptographic engine driver. > > In order to support this new engine, the driver has to be reworked in > some ways: > - The firmwares are

Re: [PATCH] crypto: ECDH - add public key verification test

2018-07-08 Thread Herbert Xu
On Mon, Jun 25, 2018 at 12:00:18PM +0200, Stephan Müller wrote: > According to SP800-56A section 5.6.2.1, the public key to be processed > for the ECDH operation shall be checked for appropriateness. When the > public key is considered to be an ephemeral key, the partial validation > test as define

Re: [PATCH v2 1/2] crypto: Fix -Wstringop-truncation warnings

2018-07-08 Thread Herbert Xu
On Mon, Jun 25, 2018 at 09:45:37PM +0900, Stafford Horne wrote: > As of GCC 9.0.0 the build is reporting warnings like: > > crypto/ablkcipher.c: In function ‘crypto_ablkcipher_report’: > crypto/ablkcipher.c:374:2: warning: ‘strncpy’ specified bound 64 equals > destination size [-Wstringop

Crypto Fixes for 4.18

2018-07-08 Thread Herbert Xu
Hi Linus: This push fixes the following issues: - Add missing RETs in x86 aegis/morus. - Fix build error in arm speck. Please pull from git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6.git linus Borislav Petkov (1): crypto: x86 - Add missing RETs Eric Biggers (1):