Re: [PATCH 3/3] hwrng: msm - Add support for prng v2

2018-06-26 Thread Stephan Mueller
Am Mittwoch, 27. Juni 2018, 08:27:01 CEST schrieb Vinod: Hi Vinod, > Hi Stephan, > > Thanks for the answers, they are helpful. > > On 27-06-18, 08:13, Stephan Mueller wrote: > > > I have two follow up question on crypto: > > > - If there a way to avoid using a global variable in driver to hold

Re: [PATCH 3/3] hwrng: msm - Add support for prng v2

2018-06-26 Thread Vinod
Hi Stephan, Thanks for the answers, they are helpful. On 27-06-18, 08:13, Stephan Mueller wrote: > > I have two follow up question on crypto: > > > > - If there a way to avoid using a global variable in driver to hold the > >pointer for driver memory? Looks like exynos driver does that. > >

[PATCH v2] crypto: DH - add public key verification test

2018-06-26 Thread Stephan Müller
Hi, Changes v2: * addition of a check that mpi_alloc succeeds. ---8<--- According to SP800-56A section 5.6.2.1, the public key to be processed for the DH operation shall be checked for appropriateness. The check shall covers the full verification test in case the domain parameter Q is provided a

Re: [PATCH 3/3] hwrng: msm - Add support for prng v2

2018-06-26 Thread Stephan Mueller
Am Mittwoch, 27. Juni 2018, 07:08:53 CEST schrieb Vinod: Hi Vinod, > Thanks for the pointers, it helped me to test the driver :) > > I have two follow up question on crypto: > > - If there a way to avoid using a global variable in driver to hold the >pointer for driver memory? Looks like e

Re: [PATCH 3/3] hwrng: msm - Add support for prng v2

2018-06-26 Thread Vinod
On 22-06-18, 19:57, Stephan Mueller wrote: > Hi > > > > Am 22.06.2018 um 16:50 schrieb Herbert Xu : > > > >> On Fri, Jun 22, 2018 at 08:18:09PM +0530, Vinod wrote: > >> > >> Okay I am doing the port taking the exynos-rng as a ref. > >> Question is how to test it, how is one supposed to exercise

Re: [PATCH v2 1/2] dt-bindings: fsl-imx-sahara: Add i.MX51 as a supported SoC

2018-06-26 Thread Fabio Estevam
Hi Rob, On Tue, Jun 26, 2018 at 11:24 AM, Rob Herring wrote: >> Would it be OK to use: compatible = "fsl,imx51-sahara", "fsl,imx53-sahara"; ? > > Yes, but the order should be reversed as it should be most specific > and newest first. Thanks for the feedback. Just sent a dts patch as you suggest

Re: [dm-devel] [PATCH v2 10/11] crypto: ahash: Remove VLA usage for AHASH_REQUEST_ON_STACK

2018-06-26 Thread Kees Cook
On Tue, Jun 26, 2018 at 2:19 AM, Herbert Xu wrote: > On Mon, Jun 25, 2018 at 03:56:09PM -0700, Eric Biggers wrote: >> >> > diff --git a/include/crypto/internal/hash.h >> > b/include/crypto/internal/hash.h >> > index a0b0ad9d585e..d96ae5f52125 100644 >> > --- a/include/crypto/internal/hash.h >> >

Re: [PATCH v2 11/11] crypto: skcipher: Remove VLA usage for SKCIPHER_REQUEST_ON_STACK

2018-06-26 Thread Kees Cook
On Tue, Jun 26, 2018 at 2:20 AM, Herbert Xu wrote: > On Mon, Jun 25, 2018 at 02:10:26PM -0700, Kees Cook wrote: >> In the quest to remove all stack VLA usage from the kernel[1], this >> caps the skcipher request size similar to other limits and adds a >> sanity check at registration. In a manual r

Re: [PATCH v2 1/2] dt-bindings: rng: Add new compatible qcom,prng-v2

2018-06-26 Thread Vinod
On 25-06-18, 13:06, Rob Herring wrote: > On Tue, Jun 19, 2018 at 03:24:29PM +0530, Vinod Koul wrote: > > Later qcom chips support v2 of the prng, so add new compatible > > qcom,prng-v2 for this. > > > > Signed-off-by: Vinod Koul > > --- > > > > Cc: Rob Herring > > Cc: devicet...@vger.kernel.org

Re: [RFC PATCH] crypto: DH - add public key verification test

2018-06-26 Thread Stephan Mueller
Am Dienstag, 26. Juni 2018, 12:17:42 CEST schrieb Stephan Müller: Hi, > + MPI val = mpi_alloc(0); I just saw that I did not check for val after allocation. That will be fixed in another installment of the patch. Ciao Stephan

Re: [PATCH v2 1/2] dt-bindings: fsl-imx-sahara: Add i.MX51 as a supported SoC

2018-06-26 Thread Rob Herring
On Mon, Jun 25, 2018 at 2:27 PM Fabio Estevam wrote: > > Hi Rob, > > On Mon, Jun 25, 2018 at 5:21 PM, Rob Herring wrote: > > > Looks like imx51 should be a fallback and you can drop the driver > > change. > > I thought about that too. > > If I do like this in imx51.dtsi: > > compatible = "fsl,imx

[PATCH 3/3] crypto: stm32/crc - Add power management support

2018-06-26 Thread Lionel Debieve
Adding pm and pm_runtime support to STM32 CRC. Signed-off-by: Lionel Debieve --- drivers/crypto/stm32/stm32_crc32.c | 62 ++ 1 file changed, 62 insertions(+) diff --git a/drivers/crypto/stm32/stm32_crc32.c b/drivers/crypto/stm32/stm32_crc32.c index 8f09b84..

[PATCH 1/3] crypto: stm32/cryp - Add power management support

2018-06-26 Thread Lionel Debieve
Adding pm and pm_runtime support to STM32 CRYP. Signed-off-by: Lionel Debieve --- drivers/crypto/stm32/stm32-cryp.c | 62 +++ 1 file changed, 62 insertions(+) diff --git a/drivers/crypto/stm32/stm32-cryp.c b/drivers/crypto/stm32/stm32-cryp.c index c5d3efc..2

[PATCH 0/3] crypto: stm32 - Add power mamagement support

2018-06-26 Thread Lionel Debieve
This set of patches add pm and pm_runtime feature to stm32 crypto drivers. Lionel Debieve (3): crypto: stm32/cryp - Add power management support crypto: stm32/hash - Add power management support crypto: stm32/crc - Add power management support drivers/crypto/stm32/stm32-cryp.c | 62 ++

[PATCH 2/3] crypto: stm32/hash - Add power management support

2018-06-26 Thread Lionel Debieve
Adding pm and pm_runtime support to STM32 HASH. Signed-off-by: Lionel Debieve --- drivers/crypto/stm32/stm32-hash.c | 71 +++ 1 file changed, 71 insertions(+) diff --git a/drivers/crypto/stm32/stm32-hash.c b/drivers/crypto/stm32/stm32-hash.c index cdc96f1..d

Re: [PATCH] x86/crypto: Add missing RETs

2018-06-26 Thread Josh Poimboeuf
On Tue, Jun 26, 2018 at 08:49:30AM +0200, Ingo Molnar wrote: > > * Josh Poimboeuf wrote: > > > On Mon, Jun 25, 2018 at 09:24:38AM +0200, Ingo Molnar wrote: > > > > > > * Alexey Dobriyan wrote: > > > > > > > On Sun, Jun 24, 2018 at 09:11:05AM +0200, Ingo Molnar wrote: > > > > > > Add explicit

Re: cryptomgr_test / drbg_ctr: BUG: sleeping function called from invalid context

2018-06-26 Thread Stephan Mueller
Am Dienstag, 26. Juni 2018, 12:33:48 CEST schrieb Geert Uytterhoeven: Hi Geert, > Issue is gone. I assume due to commit 6e88f01206edab0e ("crypto: > arm64/aes-blk - fix and move skcipher_walk_done out of kernel_neon_begin, > _end"). Thanks a lot for the hint. > > Gr{oetje,eeting}s, > >

Re: cryptomgr_test / drbg_ctr: BUG: sleeping function called from invalid context

2018-06-26 Thread Geert Uytterhoeven
Hi Stephan, On Sun, May 20, 2018 at 9:54 PM Stephan Müller wrote: > Am Freitag, 18. Mai 2018, 10:36:04 CEST schrieb Geert Uytterhoeven: > > I tried following the code path, but couldn't find where it went wrong. > > > > mutex_lock(&drbg->drbg_mutex) is called from drbg_instantiate(), which is > >

[RFC PATCH] crypto: DH - add public key verification test

2018-06-26 Thread Stephan Müller
Hi, This patch is an RFC to discuss the following: step 1 in dh_is_pubkey_valid requires the public key to be in the range of 1 < y < p - 1. The currently implemented check is 1 < y < p since the calculation of p - 1 requires the presence of mpi_sub or mpi_sub_ui. Both functions are currently not

Re: [PATCH v2 11/11] crypto: skcipher: Remove VLA usage for SKCIPHER_REQUEST_ON_STACK

2018-06-26 Thread Herbert Xu
On Mon, Jun 25, 2018 at 02:10:26PM -0700, Kees Cook wrote: > In the quest to remove all stack VLA usage from the kernel[1], this > caps the skcipher request size similar to other limits and adds a > sanity check at registration. In a manual review of the callers of > crypto_skcipher_set_reqsize(),

Re: [dm-devel] [PATCH v2 10/11] crypto: ahash: Remove VLA usage for AHASH_REQUEST_ON_STACK

2018-06-26 Thread Herbert Xu
On Mon, Jun 25, 2018 at 03:56:09PM -0700, Eric Biggers wrote: > > > diff --git a/include/crypto/internal/hash.h b/include/crypto/internal/hash.h > > index a0b0ad9d585e..d96ae5f52125 100644 > > --- a/include/crypto/internal/hash.h > > +++ b/include/crypto/internal/hash.h > > @@ -142,6 +142,7 @@ stat