On Fri, Jan 12, 2018 at 6:10 PM, Colin King wrote:
> From: Colin Ian King
>
> The current error exit path in function cc_ivgen_init via label
> 'out' free's resources from the drvdata->ivgen_handle context.
> However, drvdata->ivgen_handle has not been assigned to the
> context ivgen_ctx at this
Hi Corentin,
On Thu, Jan 11, 2018 at 12:01 PM, Corentin Labbe
wrote:
> On Thu, Jan 11, 2018 at 09:17:10AM +, Gilad Ben-Yossef wrote:
>> Add CryptoCell ablkcipher support
>>
>
> Hello
>
> I have some minor comments:
>
> ablkcipher is deprecated, so you need to use skcipher instead.
Fixed in
On Thu, Jan 11, 2018 at 12:03 PM, Stephan Mueller wrote:
> Am Donnerstag, 11. Januar 2018, 10:17:10 CET schrieb Gilad Ben-Yossef:
>
> Hi Gilad,
>
>> + // verify weak keys
>> + if (ctx_p->flow_mode == S_DIN_to_DES) {
>> + if (!des_ekey(tmp, key) &&
>> + (crypto_t
2017-12-20, 17:03:02 +0530, Atul Gupta wrote:
> RFC series for Chelsio Inline TLS driver (chtls.ko)
>
> Driver use the ULP infrastructure to register chtls as Inline TLS ULP.
I don't think drivers should be registering their own ULP. TLS
offloading should be transparent to userspace, whatever HW
On Thu, Jan 11, 2018 at 10:42 AM, Dan Carpenter
wrote:
> Here are my remaining Smatch warnings:
>
> drivers/staging/ccree/cc_driver.c:219 init_cc_resources()
> error: '%pa' can only be followed by one of [dp]
>
> drivers/staging/ccree/cc_driver.c
>217
>218 if (rc) {
>2
On Tue, Jan 16, 2018 at 10:29 AM, Ard Biesheuvel
wrote:
> Implement the Chinese SM3 secure hash algorithm using the new
> special instructions that have been introduced as an optional
> extension in ARMv8.2.
>
> Signed-off-by: Ard Biesheuvel
> ---
Looks good to me.
Reviewed-by: Gilad Ben-Yossef
Hi Herbert,
I tried to summarize the use cases of the AIO support at [1].
The use case covering the inline IV support is documented in section [2]. It
naturally would depend on this patch to be accepted. What is your take on this
use case?
What is your take on the issue outlined at [3]? Should
