Fix Warning introduced in changeset
e1a018e607a3 ("crypto: chelsio - Remove dst sg size zero check")
Reported-by: Stephen Rothwell
Signed-off-by: Harsh Jain
---
drivers/crypto/chelsio/chcr_algo.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/crypto/chel
On Thu, 2018-01-18 at 22:39 +1100, Herbert Xu wrote:
> On Tue, Jan 09, 2018 at 04:09:04PM -0800, Megha Dey wrote:
> >
> > +static void mcryptd_skcipher_encrypt(struct crypto_async_request *base,
> > + int err)
> > +{
> > + struct skcipher_
On 01/18/2018 07:34 PM, Kamil Konieczny wrote:
> Export and import are mandatory in async hash. As drivers were
> rewritten, drop empty wrappers and correct init of ahash transformation.
Are you moving checks from the core subsystem to drivers ? This looks
really nonsensical and the commit message
Hi Herbert,
Sorry, I forgot to CC you on this patch -- v2 is unchanged from the
original patch. It only adds you in copy.
---8<---
GCM can be invoked with a zero destination buffer. This is possible if
the AAD and the ciphertext have zero lengths and only the tag exists in
the source buffer (i.e
GCM can be invoked with a zero destination buffer. This is possible if
the AAD and the ciphertext have zero lengths and only the tag exists in
the source buffer (i.e. a source buffer cannot be zero). In this case,
the GCM cipher only performs the authentication and no decryption
operation.
When th
tree:
https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master
head: 20b04c02bcb2d1e6a642bbe9e759157bb198499e
commit: e1a018e607a33dc9f987c761daf1792082fb9ca7 [147/154] crypto: chelsio -
Remove dst sg size zero check
config: x86_64-randconfig-v0-01182123 (attached as .
Crypto framework requires export/import in async hash. If driver do not
implement them, wrapper functions in framework will be used, and it will
cause error during ahash alg registration (unless one disables crypto
internal tests). To make change in framework and expose this requirement,
I will rem
Crypto framework requires export/import in async hash. If driver do not
implement them, wrapper functions in framework will be used, and it will
cause error during ahash alg registration (unless one disables crypto
internal tests). To make change in framework and expose this requirement,
I will rem
Export and import are mandatory in async hash. As drivers were
rewritten, drop empty wrappers and correct init of ahash transformation.
Signed-off-by: Kamil Konieczny
---
crypto/ahash.c | 18 ++
1 file changed, 2 insertions(+), 16 deletions(-)
diff --git a/crypto/ahash.c b/crypt
Crypto framework requires export/import in async hash. If driver do not
implement them, wrapper functions in framework will be used, and it will
cause error during ahash alg registration (unless one disables crypto
internal tests). To make change in framework and expose this requirement,
I will rem
Crypto framework requires export/import in async hash. If driver do not
implement them, wrapper functions in framework will be used, and it will
cause error during ahash alg registration (unless one disables crypto
internal tests). To make change in framework and expose this requirement,
I will rem
First four patches add empty hash export and import functions to each driver,
with the same behaviour as in crypto framework. The last one drops them from
crypto framework. Last one for ahash.c depends on all previous.
Changes in v3:
added change for bfin_crc.c
make this a patchset, instead of unr
On Thu, Jan 18, 2018 at 11:07:50AM +0100, Paolo Valente wrote:
>
>
> > Il giorno 17 gen 2018, alle ore 12:08, David Howells
> > ha scritto:
> >
> > If this happened during boot, it could be that you have an X.509 cert for
> > which the digest algorithm isn't built into the kernel.
> >
>
> Ye
Please drop this as I will resend it as part of patchset.
On 16.01.2018 17:32, Kamil Konieczny wrote:
> Crypto framework will require async hash export/import, so add empty
> functions to prevent OOPS.
>
> Signed-off-by: Kamil Konieczny
> ---
> drivers/crypto/ux500/hash/hash_core.c | 18 +++
Please drop this as I will resend it as part of patchset.
On 16.01.2018 17:18, Kamil Konieczny wrote:
> Crypto framework will require async hash export/import, so add empty
> functions to prevent OOPS.
>
> Signed-off-by: Kamil Konieczny
> ---
> drivers/crypto/n2_core.c | 12
> 1 fi
Please drop this as I will resend it as part of patchset.
On 16.01.2018 17:16, Kamil Konieczny wrote:
> Crypto framework will require async hash export/import, so add empty
> functions to prevent OOPS.
>
> Signed-off-by: Kamil Konieczny
> ---
> drivers/crypto/mxs-dcp.c | 14 ++
> 1
On Wed, Jan 17, 2018 at 07:43:51PM +0530, PrasannaKumar Muralidharan wrote:
> Hi Jarkko,
>
> On 14 November 2017 at 20:02, Jarkko Sakkinen
> wrote:
> > On Sun, Nov 12, 2017 at 10:53:35AM +0530, PrasannaKumar Muralidharan wrote:
> >> Did basic check on tpm rng patch, it works fine. As it depends o
On 14 January 2018 at 16:41, Ard Biesheuvel wrote:
> Add an implementation of SHA3 to arm64 using the new special instructions,
> and another one using scalar instructions but coded in assembler (#2)
>
> In preparation of that, fix a bug in the SHA3 (#1) and add some new test
> vectors to get bett
On 15 January 2018 at 16:07, Arnd Bergmann wrote:
> My last bugfix added -Os on the command line, which unfortunately caused
> a build regression on powerpc in some configurations.
>
> I've done some more analysis of the original problem and found slightly
> different workaround that avoids this r
On 18.01.2018 11:06, Linus Walleij wrote:
> On Tue, Jan 16, 2018 at 5:32 PM, Kamil Konieczny
> wrote:
>
>> Crypto framework will require async hash export/import, so add empty
>> functions to prevent OOPS.
>>
>> Signed-off-by: Kamil Konieczny
>
> Acked-by: Linus Walleij
>
> But why isn't th
tree:
https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master
head: 20b04c02bcb2d1e6a642bbe9e759157bb198499e
commit: e1a018e607a33dc9f987c761daf1792082fb9ca7 [147/154] crypto: chelsio -
Remove dst sg size zero check
config: ia64-allmodconfig (attached as .config)
comp
On Thu, Jan 11, 2018 at 10:06:39PM +0100, Martin Kaiser wrote:
> Use the SIMPLE_DEV_PM_OPS() macro instead of populating a struct
> dev_pm_ops directly. The suspend and resume functions will now be used
> for both hibernation and suspend to ram.
>
> If power management is disabled, SIMPLE_DEV_PM_O
On Wed, Jan 10, 2018 at 03:15:43PM +, Robin Murphy wrote:
> phys_to_dma() is an internal helper for certain DMA API implementations,
> and is not appropriate for drivers to use. It appears that what the CESA
> driver really wants to be using is dma_map_resource() - admittedly that
> didn't exis
On Wed, Jan 10, 2018 at 12:02:46PM +0800, sean.w...@mediatek.com wrote:
> From: Sean Wang
>
> When hw_random device's quality is non-zero, it will automatically fill
> the kernel's entropy pool at boot. For the purpose, one conservative
> quality value is being picked up as the default value.
>
On Wed, Jan 10, 2018 at 01:30:59PM +, Wei Yongjun wrote:
> There is a error message within devm_ioremap_resource
> already, so remove the dev_err call to avoid redundant
> error message.
>
> Signed-off-by: Wei Yongjun
Patch applied. Thanks.
--
Email: Herbert Xu
Home Page: http://gondor.ap
On Thu, Jan 11, 2018 at 04:45:47PM +0530, Harsh Jain wrote:
> This series include cleanup, bug fixes and authenc algo supporting
> ctr(aes)-sha operation.
>
> Harsh Jain (5):
> crypto: chelsio - Fix Indentation
> crypto: chelsio - check for sg null
> crypto: chelsio - Fix IV updated in XTS
On Wed, Jan 10, 2018 at 12:36:58PM +0300, Dan Carpenter wrote:
> "val" needs to be signed for the error handling to work.
>
> Fixes: 6cd225cc5d8a ("hwrng: exynos - add Samsung Exynos True RNG driver")
> Signed-off-by: Dan Carpenter
Patch applied. Thanks.
--
Email: Herbert Xu
Home Page: http:/
On Thu, Jan 18, 2018 at 11:46:07AM +, Ard Biesheuvel wrote:
> On 18 January 2018 at 11:41, Herbert Xu wrote:
> > On Wed, Jan 10, 2018 at 12:11:35PM +, Ard Biesheuvel wrote:
> >> Prevent inadvertently creating speculative gadgets by moving literal data
> >> into the .rodata section.
> >>
>
On Tue, Jan 09, 2018 at 06:23:02PM +, Ard Biesheuvel wrote:
> Implement the SHA-512 using the new special instructions that have
> been introduced as an optional extension in ARMv8.2.
>
> Signed-off-by: Ard Biesheuvel
Patch applied. Thanks.
--
Email: Herbert Xu
Home Page: http://gondor.ap
On Tue, Jan 09, 2018 at 06:57:35PM +0100, Krzysztof Kozlowski wrote:
> Replace GPL license statement with SPDX GPL-2.0 license identifier and
> correct the module license to GPLv2.
>
> The license itself was a generic GPL because of copy-and-paste from old
> drivers/char/hw_random/exynos-rng.c dri
On 18 January 2018 at 11:41, Herbert Xu wrote:
> On Wed, Jan 10, 2018 at 12:11:35PM +, Ard Biesheuvel wrote:
>> Prevent inadvertently creating speculative gadgets by moving literal data
>> into the .rodata section.
>>
>> Patch #1 enables this for C code, by reverting a change that disables the
On Wed, Jan 10, 2018 at 12:11:35PM +, Ard Biesheuvel wrote:
> Prevent inadvertently creating speculative gadgets by moving literal data
> into the .rodata section.
>
> Patch #1 enables this for C code, by reverting a change that disables the
> GCC feature implementing this. Note that this conf
On Tue, Jan 09, 2018 at 04:09:04PM -0800, Megha Dey wrote:
>
> +static void mcryptd_skcipher_encrypt(struct crypto_async_request *base,
> + int err)
> +{
> + struct skcipher_request *req = skcipher_request_cast(base);
> + struct mc
On 16.01.2018 19:38, Kamil Konieczny wrote:
> Export and import were optional in async hash. As most drivers were
> rewritten, they become mandatory now, so correct init of ahash
> transformation.
>
> Signed-off-by: Kamil Konieczny
Please drop this patch, as there is one more driver needed for c
Hello Herbert Xu,
The patch 700cb3f5fe75: "crypto: lrw - Convert to skcipher" from Nov
22, 2016, leads to the following static checker warning:
crypto/lrw.c:316 exit_crypt()
warn: should '(struct rctx)->ext' be freed with kzfree()'
crypto/lrw.c
309 static void exit_crypt(stru
> Il giorno 17 gen 2018, alle ore 12:08, David Howells ha
> scritto:
>
> If this happened during boot, it could be that you have an X.509 cert for
> which the digest algorithm isn't built into the kernel.
>
Yeah. I did look for such an inconsistency after that failure, but I
didn't find it,
On Tue, Jan 16, 2018 at 5:32 PM, Kamil Konieczny
wrote:
> Crypto framework will require async hash export/import, so add empty
> functions to prevent OOPS.
>
> Signed-off-by: Kamil Konieczny
Acked-by: Linus Walleij
But why isn't the framework code just checking the vtable for NULL?
if (foo->
On Thu, Jan 18, 2018 at 10:39:11AM +0200, Gilad Ben-Yossef wrote:
> On Sat, Jan 13, 2018 at 3:21 PM, Greg Kroah-Hartman
> wrote:
> > On Thu, Jan 11, 2018 at 09:17:08AM +, Gilad Ben-Yossef wrote:
> >> Remove the ccree driver from the staging tree in preparation to
> >> introducing it in the cry
Hello
When modprobing tcrypt on a qemu virtual machine, I get the following trace in
dmesg:
skcipher: Test 1 failed (invalid result) on encryption for
cts(virtio_crypto_aes_cbc)
Regards
Corentin Labbe
On Fri, Jan 12, 2018 at 10:11:18AM +0100, Stephan Mueller wrote:
> Am Freitag, 12. Januar 2018, 10:07:30 CET schrieb LABBE Corentin:
>
> > > > + __u64 stat_hash_tlen;
> > > >
> > > > };
> > >
> > > What I am slightly unsure here is: how should user space detect whether
> > > these additio
On Thu, Jan 11, 2018 at 1:14 PM, Wei Yongjun wrote:
> There is a error message within devm_ioremap_resource
> already, so remove the dev_err call to avoid redundant
> error message.
>
> Signed-off-by: Wei Yongjun
> ---
> drivers/staging/ccree/cc_driver.c | 4 +---
> 1 file changed, 1 insertion(+
On Sat, Jan 13, 2018 at 3:21 PM, Greg Kroah-Hartman
wrote:
> On Thu, Jan 11, 2018 at 09:17:08AM +, Gilad Ben-Yossef wrote:
>> Remove the ccree driver from the staging tree in preparation to
>> introducing it in the crypto tree.
>>
>> Signed-off-by: Gilad Ben-Yossef
>
> Heh, no, just make a pa
42 matches
Mail list logo
