Re: [PATCH] crypto: arm64/aes - do not call crypto_unregister_skcipher twice on error

2017-11-23 Thread LABBE Corentin
On Wed, Nov 22, 2017 at 08:55:14AM +, Ard Biesheuvel wrote: > Hello Corentin, > > On 22 November 2017 at 08:08, Corentin Labbe wrote: > > When a cipher fail > > fails > > > to register in aes_init(), the error path go thought > > goes through > > > aes_exit() then crypto_unregister_skciph

Re: [PATCH] crypto: skcipher - Fix skcipher_walk_aead_common

2017-11-23 Thread Herbert Xu
On Thu, Nov 23, 2017 at 01:49:06PM +0100, Ondrej Mosnacek wrote: > The skcipher_walk_aead_common function calls scatterwalk_copychunks on > the input and output walks to skip the associated data. If the AD end > at an SG list entry boundary, then after these calls the walks will > still be pointing

Re: [PATCH] crypto: arm64/aes - do not call crypto_unregister_skcipher twice on error

2017-11-23 Thread Herbert Xu
On Wed, Nov 22, 2017 at 08:55:14AM +, Ard Biesheuvel wrote: > > Would this also fix it? Looks good. Could you resubmit with a sign-off? Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

CONGRATULATIONS

2017-11-23 Thread BBC
Your E-mail ID has won you (One Million Great Britain Pounds) In BBC NATIONAL END OF YEAR EMAIL LOTTERY DRAW 2017,contact us via Email immediately for claims. BBC ©2017

Project Funding Program

2017-11-23 Thread Austin Jonas
Hello, Can i trust an investment project in your country? accepted please send email for more details. Best Regards Austin Jonas

Re: [PATCH 2/3] hwrng: exynos - add Samsung Exynos True RNG driver

2017-11-23 Thread Łukasz Stelmach
It was <2017-11-23 czw 17:31>, when Krzysztof Kozlowski wrote: > On Thu, Nov 23, 2017 at 4:09 PM, Łukasz Stelmach > wrote: >> Add support for True Random Number Generator found in Samsung Exynos >> 5250+ SoCs. >> >> Signed-off-by: Łukasz Stelmach >> --- >> MAINTAINERS |

Re: [PATCH 3/3] ARM: dts: exynos: Add nodes for True Random Number Generator

2017-11-23 Thread Krzysztof Kozlowski
On Thu, Nov 23, 2017 at 4:09 PM, Łukasz Stelmach wrote: > Add nodes for the True Random Number Generator found in Samsung Exynos > 5250+ SoCs. > > Signed-off-by: Łukasz Stelmach > --- > arch/arm/boot/dts/exynos5.dtsi| 5 + > arch/arm/boot/dts/exynos5250.dtsi | 5 + > arch/arm/boot/dt

Re: [PATCH 2/3] hwrng: exynos - add Samsung Exynos True RNG driver

2017-11-23 Thread Krzysztof Kozlowski
On Thu, Nov 23, 2017 at 4:09 PM, Łukasz Stelmach wrote: > Add support for True Random Number Generator found in Samsung Exynos > 5250+ SoCs. > > Signed-off-by: Łukasz Stelmach > --- > MAINTAINERS | 7 + > drivers/char/hw_random/Kconfig | 12 ++ > drivers/char/hw

Re: [PATCH 1/3] dt-bindings: hwrng: Add Samsung Exynos 5250+ True RNG bindings

2017-11-23 Thread Krzysztof Kozlowski
On Thu, Nov 23, 2017 at 4:09 PM, Łukasz Stelmach wrote: > Add binding documentation for the True Random Number Generator > found on Samsung Exynos 5250+ SoCs. > > Signed-off-by: Łukasz Stelmach > --- > .../devicetree/bindings/rng/samsung,exynos5250-trng.txt | 17 > + > 1 file ch

Re: [PATCH 2/3] hwrng: exynos - add Samsung Exynos True RNG driver

2017-11-23 Thread Andrew F. Davis
On 11/23/2017 09:09 AM, Łukasz Stelmach wrote: > Add support for True Random Number Generator found in Samsung Exynos > 5250+ SoCs. > > Signed-off-by: Łukasz Stelmach > --- > MAINTAINERS | 7 + > drivers/char/hw_random/Kconfig | 12 ++ > drivers/char/hw_random/M

[PATCH 2/3] hwrng: exynos - add Samsung Exynos True RNG driver

2017-11-23 Thread Łukasz Stelmach
Add support for True Random Number Generator found in Samsung Exynos 5250+ SoCs. Signed-off-by: Łukasz Stelmach --- MAINTAINERS | 7 + drivers/char/hw_random/Kconfig | 12 ++ drivers/char/hw_random/Makefile | 1 + drivers/char/hw_random/exynos-trng.c | 25

[PATCH 1/3] dt-bindings: hwrng: Add Samsung Exynos 5250+ True RNG bindings

2017-11-23 Thread Łukasz Stelmach
Add binding documentation for the True Random Number Generator found on Samsung Exynos 5250+ SoCs. Signed-off-by: Łukasz Stelmach --- .../devicetree/bindings/rng/samsung,exynos5250-trng.txt | 17 + 1 file changed, 17 insertions(+) create mode 100644 Documentation/devicetree/bin

[PATCH 3/3] ARM: dts: exynos: Add nodes for True Random Number Generator

2017-11-23 Thread Łukasz Stelmach
Add nodes for the True Random Number Generator found in Samsung Exynos 5250+ SoCs. Signed-off-by: Łukasz Stelmach --- arch/arm/boot/dts/exynos5.dtsi| 5 + arch/arm/boot/dts/exynos5250.dtsi | 5 + arch/arm/boot/dts/exynos5410.dtsi | 5 + arch/arm/boot/dts/exynos5420.dtsi | 5 +

[PATCH 0/3] True RNG driver for Samsung Exynos 5250+ SoCs

2017-11-23 Thread Łukasz Stelmach
Hello. The following patches add support for the true random number generator found in Samsung Exynos 5250+ SoCs. Patch #1 adds documentation for devicetree bindings. Patch #2 introduces the driver and appropriate changes in Makefile and Kconfig. Patch #3 adds nodes in devicetree files for Exyn

[PATCH] crypto: skcipher - Fix skcipher_walk_aead_common

2017-11-23 Thread Ondrej Mosnacek
The skcipher_walk_aead_common function calls scatterwalk_copychunks on the input and output walks to skip the associated data. If the AD end at an SG list entry boundary, then after these calls the walks will still be pointing to the end of the skipped region. These offsets are later checked for a

Re: x509 parsing bug + fuzzing crypto in the userspace

2017-11-23 Thread Stephan Mueller
Am Donnerstag, 23. November 2017, 12:34:54 CET schrieb Dmitry Vyukov: Hi Dmitry, > Btw, I've started doing some minimal improvements, did not yet sorted > out alg types/names, and fuzzer started scratching surface: > > WARNING: kernel stack regs has bad 'bp' value 77 Nov 23 2017 12:29:36 CET > g

Re: x509 parsing bug + fuzzing crypto in the userspace

2017-11-23 Thread Stephan Mueller
Am Donnerstag, 23. November 2017, 12:27:30 CET schrieb Dmitry Vyukov: Hi Dmitry, > Hi Stephan, > > Thanks for the explanation! I am starting to digesting it. > > You say that: > > static const struct crypto_type crypto_skcipher_type2 = { > > > > .type = CRYPTO_ALG_TYPE_SKCIPHER, > > w

Re: x509 parsing bug + fuzzing crypto in the userspace

2017-11-23 Thread Dmitry Vyukov
On Thu, Nov 23, 2017 at 12:27 PM, Dmitry Vyukov wrote: >> >> Hi Dmitry, >> >>> >> I've read the links and starring at the code, but still can't get it. >>> >> The question is about textual type names in sockaddr. >>> >> .cra_flags does not specify textual names. >>> >> [3] again talks about int fl

Re: x509 parsing bug + fuzzing crypto in the userspace

2017-11-23 Thread Dmitry Vyukov
On Thu, Nov 23, 2017 at 12:10 PM, Stephan Mueller wrote: > Am Donnerstag, 23. November 2017, 10:37:35 CET schrieb Dmitry Vyukov: > > Hi Dmitry, > >> >> I've read the links and starring at the code, but still can't get it. >> >> The question is about textual type names in sockaddr. >> >> .cra_flags

Re: x509 parsing bug + fuzzing crypto in the userspace

2017-11-23 Thread Stephan Mueller
Am Donnerstag, 23. November 2017, 10:37:35 CET schrieb Dmitry Vyukov: Hi Dmitry, > >> I've read the links and starring at the code, but still can't get it. > >> The question is about textual type names in sockaddr. > >> .cra_flags does not specify textual names. > >> [3] again talks about int fla

Re: x509 parsing bug + fuzzing crypto in the userspace

2017-11-23 Thread Dmitry Vyukov
On Thu, Nov 23, 2017 at 10:35 AM, Dmitry Vyukov wrote: > On Thu, Nov 23, 2017 at 10:32 AM, Dmitry Vyukov wrote: >> On Wed, Nov 22, 2017 at 6:08 PM, Stephan Mueller wrote: >>> Am Mittwoch, 22. November 2017, 11:44:51 CET schrieb Dmitry Vyukov: >>> >>> Hi Dmitry, >>> Thanks! I think we c

Re: x509 parsing bug + fuzzing crypto in the userspace

2017-11-23 Thread Dmitry Vyukov
On Thu, Nov 23, 2017 at 10:32 AM, Dmitry Vyukov wrote: > On Wed, Nov 22, 2017 at 6:08 PM, Stephan Mueller wrote: >> Am Mittwoch, 22. November 2017, 11:44:51 CET schrieb Dmitry Vyukov: >> >> Hi Dmitry, >> >>> >>> Thanks! I think we can incorporate this into syzkaller. >>> >>> One question: what's

Re: x509 parsing bug + fuzzing crypto in the userspace

2017-11-23 Thread Dmitry Vyukov
On Wed, Nov 22, 2017 at 6:08 PM, Stephan Mueller wrote: > Am Mittwoch, 22. November 2017, 11:44:51 CET schrieb Dmitry Vyukov: > > Hi Dmitry, > >> >> Thanks! I think we can incorporate this into syzkaller. >> >> One question: what's the relation between alg names and type ("aead", >> "hash", "rng",

Re: [PATCH 2/2] crypto: caam - add Derived Key Protocol (DKP) support

2017-11-23 Thread Horia Geantă
On 11/10/2017 4:34 PM, Horia Geantă wrote: > Offload split key generation in CAAM engine, using DKP. > DKP is supported starting with Era 6. > > Note that the way assoclen is transmitted from the job descriptor > to the shared descriptor changes - DPOVRD register is used instead > of MATH3 (where