Re: [PATCH] crypto/s5p-sss: Use common error handling code in s5p_aes_probe()

2017-10-22 Thread SF Markus Elfring
>> From: Markus Elfring >> Date: Sun, 22 Oct 2017 15:00:27 +0200 >> >> Add a jump target so that a bit of exception handling can be better reused >> at the end of this function. >> >> This issue was detected by using the Coccinelle software. >> >> Signed-off-by: Markus Elfring >> --- >> drivers/

Re: [PATCH] crypto/s5p-sss: Use common error handling code in s5p_aes_probe()

2017-10-22 Thread Krzysztof Kozlowski
On Sun, Oct 22, 2017 at 03:05:05PM +0200, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sun, 22 Oct 2017 15:00:27 +0200 > > Add a jump target so that a bit of exception handling can be better reused > at the end of this function. > > This issue was detected by using the Coccinelle soft

[PATCH] crypto/s5p-sss: Use common error handling code in s5p_aes_probe()

2017-10-22 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 22 Oct 2017 15:00:27 +0200 Add a jump target so that a bit of exception handling can be better reused at the end of this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/crypto/s5p-sss.c | 13 +++-

[PATCH] crypto-ccp: Use common error handling code in sp_get_irqs()

2017-10-22 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 22 Oct 2017 14:10:33 +0200 Add a jump target so that a bit of exception handling can be better reused at the end of this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/crypto/ccp/sp-platform.c | 16

Re: [PATCH v7 1/2] crypto: s5p-sss: change spaces into tabs in defines

2017-10-22 Thread Vladimir Zapolskiy
Hi Kamil, On 10/17/2017 02:28 PM, Kamil Konieczny wrote: > change spaces into tabs in defines Here a grammatically correct sentence in English is welcome. > > Signed-off-by: Kamil Konieczny > --- Please feel free to add a tag Acked-by: Vladimir Zapolskiy -- With best wishes, Vladimir

Re: [PATCH v7 2/2] crypto: s5p-sss: Add HASH support for Exynos

2017-10-22 Thread Vladimir Zapolskiy
Hi Kamil, thank you for updates, I have just a few more comments. On 10/17/2017 02:28 PM, Kamil Konieczny wrote: > Add support for MD5, SHA1, SHA256 hash algorithms for Exynos HW. > It uses the crypto framework asynchronous hash api. > It is based on omap-sham.c driver. > S5P has some HW differen

Re: [PATCH v5 2/2] crypto: stm32 - Support for STM32 CRYP crypto module

2017-10-22 Thread Corentin Labbe
On Thu, Oct 19, 2017 at 05:10:30PM +0200, Fabien Dessenne wrote: > This module registers block cipher algorithms that make use of the > STMicroelectronics STM32 crypto "CRYP1" hardware. > The following algorithms are supported: > - aes: ecb, cbc, ctr > - des: ecb, cbc > - tdes: ecb, cbc > > Signed

Re: [PATCH v4 2/2] crypto: stm32 - Support for STM32 CRYP crypto module

2017-10-22 Thread Corentin Labbe
On Thu, Oct 19, 2017 at 01:01:56PM +, Fabien DESSENNE wrote: > Hi Corentin > > > Thank you for your comments. I will fix according to them. See also me > answers/questions below > > While we are at it, do you plan to deliver a new version of the > crypto_engine update? (I had to remove the