Re: [PATCH] staging: ccree: local variable "dev" not required

On Thursday 05 October 2017 11:30 PM, Joe Perches wrote: > On Thu, 2017-10-05 at 10:07 +0300, Gilad Ben-Yossef wrote: >> On Wed, Oct 4, 2017 at 10:12 PM, wrote: >>> There is no need to create a local pointer variable "dev" and >>> pass it various API's, instead use plat_dev which is enumerated >>

Re: [PATCH 0/8] KEYS: keyctl operations for asymmetric keys [ver #2]

On Thu, Jun 23, 2016 at 02:47:34PM +0100, David Howells wrote: > > Here's a set of patches that provides keyctl access for asymmetric keys, > including a query function, and functions to do encryption, decryption, > signature creation and signature verification. > > I've added a PKCS#8 asymmetric

Re: [Part2 PATCH v5 11/31] crypto: ccp: Define SEV key management command id

On Wed, Oct 04, 2017 at 08:13:52AM -0500, Brijesh Singh wrote: > Define Secure Encrypted Virtualization (SEV) key management command id > and structure. The command definition is available in SEV KM [1] spec > 0.14. > > [1] http://support.amd.com/TechDocs/55766_SEV-KM API_Specification.pdf > > Cc

Re: [PATCH V2] Fix a sleep-in-atomic bug in shash_setkey_unaligned

On Thu, Oct 05, 2017 at 09:16:31PM +0800, Herbert Xu wrote: > On Thu, Oct 05, 2017 at 06:16:20PM +0800, Herbert Xu wrote: > > > > That was my point. Functions like sctp_pack_cookie shouldn't be > > setting the key in the first place. The setkey should happen at > > the point when the key is gener

Re: [PATCH] staging: ccree: local variable "dev" not required

On Thu, 2017-10-05 at 10:07 +0300, Gilad Ben-Yossef wrote: > On Wed, Oct 4, 2017 at 10:12 PM, wrote: > > There is no need to create a local pointer variable "dev" and > > pass it various API's, instead use plat_dev which is enumerated > > by platform core on successful probe. [] > I'm sorry but I

Re: [PATCH V2] Fix a sleep-in-atomic bug in shash_setkey_unaligned

On Thu, Oct 05, 2017 at 06:16:20PM +0800, Herbert Xu wrote: > > That was my point. Functions like sctp_pack_cookie shouldn't be > setting the key in the first place. The setkey should happen at > the point when the key is generated. That's sctp_endpoint_init > which AFAICS only gets called in GF

Re: [PATCH 3/7] crypto:gf128mul: The x8_ble multiplication functions

On 03-10-2017 20:28, David Laight wrote: > From: Harsh Jain >> Sent: 03 October 2017 07:46 >> It multiply GF(2^128) elements in the ble format. >> It will be used by chelsio driver to fasten gf multiplication. >^ speed up ?? It should be speed up. Will fix

Re: [PATCH V2] Fix a sleep-in-atomic bug in shash_setkey_unaligned

On Wed, Oct 04, 2017 at 09:37:58PM -0700, David Miller wrote: > > > I'm not talking about the code-path in question. I'm talking > > about the function which generates the secret key in the first > > place. AFAICS that's only called in GFP_KERNEL context. What > > am I missing? > > The setkey h

Re: [Part2 PATCH v5 10/31] crypto: ccp: Add Platform Security Processor (PSP) device support

On Wed, Oct 04, 2017 at 08:13:51AM -0500, Brijesh Singh wrote: > The Platform Security Processor (PSP) is part of AMD Secure Processor > (AMD-SP), PSP is a dedicated processor that provides the support for > key management commands in a Secure Encrypted Virtualization (SEV) mode, > along with softw

Re: [PATCH 5/6] crypto: talitos - use kzalloc instead of kmalloc

Le 21/09/2017 à 09:19, Christophe Leroy a écrit : Use kzalloc() to zeroize the extended descriptor at allocation and further zeorising This patch significantly degrades performances. I will submit a new serie soon. Christophe Signed-off-by: Christophe Leroy --- drivers/crypto/talitos.c

Re: [PATCH] staging: ccree: local variable "dev" not required

Hi Suniel, On Wed, Oct 4, 2017 at 10:12 PM, wrote: > From: Suniel Mahesh > > There is no need to create a local pointer variable "dev" and > pass it various API's, instead use plat_dev which is enumerated > by platform core on successful probe. > > Signed-off-by: Suniel Mahesh > --- I'm sorry