Re: md5sum (from libkcapi) fails as splice() returns -ENOKEY

Am Montag, 11. September 2017, 19:07:31 CEST schrieb christophe leroy: Hi christophe, > Hello Stephan, > > I'm trying to use md5sum from the latest libkcapi 0.14 and I getting a > failure with return code -5. > > What am I missing ? See strace below, splice() return -ENOKEY. The ENOKEY error i

Re: [Outreachy kernel] [PATCH v2] Staging: ccree: Remove unused variable monitor_lock

On Mon, Sep 11, 2017 at 7:36 PM, Sean Paul wrote: > On Mon, Sep 11, 2017 at 12:28 PM, Srishti Sharma > wrote: >> Remove the variable monitor_lock as it is not used anywhere. >> >> Signed-off-by: Srishti Sharma > > Reviewed-by: Sean Paul That variable is a left-over I've missed when I deleted

md5sum (from libkcapi) fails as splice() returns -ENOKEY

Hello Stephan, I'm trying to use md5sum from the latest libkcapi 0.14 and I getting a failure with return code -5. What am I missing ? See strace below, splice() return -ENOKEY. Christophe execve("./md5sum", ["./md5sum", "kcapi.tar"], [/* 11 vars */]) = 0 brk(0)

Re: [PATCH v2] Staging: ccree: Prefer using BIT macro.

On Mon, Sep 11, 2017 at 9:54 PM, Greg KH wrote: > On Thu, Sep 07, 2017 at 07:44:52PM +0530, Srishti Sharma wrote: >> Use BIT(x) instead of using (1<> >> Signed-off-by: Srishti Sharma >> --- >> Changes in v2: >> - Add tab spaces before BIT macro. >> >> drivers/staging/ccree/ssi_cipher.h | 10 +++

Re: [Outreachy kernel] [PATCH v2] Staging: ccree: Remove unused variable monitor_lock

On Mon, Sep 11, 2017 at 12:28 PM, Srishti Sharma wrote: > Remove the variable monitor_lock as it is not used anywhere. > > Signed-off-by: Srishti Sharma Reviewed-by: Sean Paul > --- > Changes in v2: > -The variable that was not to be declared as volatile can be > eliminated as it is not bei

Re: [Outreachy kernel] Re: [PATCH] Staging: ccree: Don't use volatile for monitor_lock

On Mon, Sep 11, 2017 at 9:45 PM, Srishti Sharma wrote: > On Mon, Sep 11, 2017 at 9:41 PM, Julia Lawall wrote: >> >> >> On Mon, 11 Sep 2017, Srishti Sharma wrote: >> >>> On Mon, Sep 11, 2017 at 9:34 PM, Greg KH wrote: >>> > On Mon, Sep 11, 2017 at 09:29:31PM +0530, Srishti Sharma wrote: >>> >> Th

[PATCH v2] Staging: ccree: Remove unused variable monitor_lock

Remove the variable monitor_lock as it is not used anywhere. Signed-off-by: Srishti Sharma --- Changes in v2: -The variable that was not to be declared as volatile can be eliminated as it is not being used anywhere. drivers/staging/ccree/ssi_request_mgr.c | 1 - 1 file changed, 1 deletion(-)

Re: [PATCH] staging: ccree: Add missing newlines

On Sat, Sep 09, 2017 at 11:18:02PM -0700, Joe Perches wrote: > Logging without newlines are still prone to interleaving. > Add newlines where necessary. Doesn't apply to my staging-testing branch, due to other changes in this driver. Can you rebase it onto that branch and resend? thanks, greg k

Re: [PATCH v2] Staging: ccree: Prefer using BIT macro.

On Thu, Sep 07, 2017 at 07:44:52PM +0530, Srishti Sharma wrote: > Use BIT(x) instead of using (1< > Signed-off-by: Srishti Sharma > --- > Changes in v2: > - Add tab spaces before BIT macro. > > drivers/staging/ccree/ssi_cipher.h | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-

Re: [Outreachy kernel] Re: [PATCH] Staging: ccree: Don't use volatile for monitor_lock

On Mon, Sep 11, 2017 at 9:41 PM, Julia Lawall wrote: > > > On Mon, 11 Sep 2017, Srishti Sharma wrote: > >> On Mon, Sep 11, 2017 at 9:34 PM, Greg KH wrote: >> > On Mon, Sep 11, 2017 at 09:29:31PM +0530, Srishti Sharma wrote: >> >> The use of volatile for the variable monitor_lock is unnecessary. >

Re: [Outreachy kernel] Re: [PATCH] Staging: ccree: Don't use volatile for monitor_lock

On Mon, 11 Sep 2017, Srishti Sharma wrote: > On Mon, Sep 11, 2017 at 9:34 PM, Greg KH wrote: > > On Mon, Sep 11, 2017 at 09:29:31PM +0530, Srishti Sharma wrote: > >> The use of volatile for the variable monitor_lock is unnecessary. > >> > >> Signed-off-by: Srishti Sharma > >> --- > >> drivers

Re: [Outreachy kernel] Re: [PATCH] Staging: ccree: Don't use volatile for monitor_lock

On Mon, Sep 11, 2017 at 12:08 PM, Srishti Sharma wrote: > On Mon, Sep 11, 2017 at 9:34 PM, Greg KH wrote: >> On Mon, Sep 11, 2017 at 09:29:31PM +0530, Srishti Sharma wrote: >>> The use of volatile for the variable monitor_lock is unnecessary. >>> >>> Signed-off-by: Srishti Sharma >>> --- >>> dr

Re: [PATCH] Staging: ccree: Don't use volatile for monitor_lock

On Mon, Sep 11, 2017 at 9:34 PM, Greg KH wrote: > On Mon, Sep 11, 2017 at 09:29:31PM +0530, Srishti Sharma wrote: >> The use of volatile for the variable monitor_lock is unnecessary. >> >> Signed-off-by: Srishti Sharma >> --- >> drivers/staging/ccree/ssi_request_mgr.c | 2 +- >> 1 file changed,

Re: [PATCH] Staging: ccree: Don't use volatile for monitor_lock

On Mon, Sep 11, 2017 at 09:29:31PM +0530, Srishti Sharma wrote: > The use of volatile for the variable monitor_lock is unnecessary. > > Signed-off-by: Srishti Sharma > --- > drivers/staging/ccree/ssi_request_mgr.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/

Re: [Outreachy kernel] [PATCH] Staging: ccree: Don't use volatile for monitor_lock

On Mon, 11 Sep 2017, Srishti Sharma wrote: > The use of volatile for the variable monitor_lock is unnecessary. You need to give more evidence of why this is the case. How is the variable used? I guess this comes from checkpatch, but checkpatch has only a local view of things, and doesn't know

[PATCH] Staging: ccree: Don't use volatile for monitor_lock

The use of volatile for the variable monitor_lock is unnecessary. Signed-off-by: Srishti Sharma --- drivers/staging/ccree/ssi_request_mgr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/ccree/ssi_request_mgr.c b/drivers/staging/ccree/ssi_request_mgr.c index