[PATCH] crypto:ccp - invoke the DMA callback in a standard way

From: amd Use the provided mechanism in dmaengine.h to invoke the completion callback. Signed-off-by: Gary R Hook --- drivers/crypto/ccp/ccp-dmaengine.c |4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/crypto/ccp/ccp-dmaengine.c b/drivers/crypto/ccp/ccp-dmaeng

[PATCH] crypto: ccp - unmap pages and remove unmap objects in callback

From: amd Clean up the mapped pages and the unmap object once we are done with it. This enables the final clean-up of the object once the transfer is complete. Signed-off-by: Gary R Hook --- drivers/crypto/ccp/ccp-dmaengine.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/crypt

Re: HWRNGs without quality attribute - are they used or not?

Hi Peter, On 5 September 2017 7:24:02 PM IST, Peter Huewe wrote: >Hi, > >while reading through the analysis of the Linux RNG by the BSI [1][2], >I was suprised by the lack of reflecting on the usage of HWRNGs except >RDRAND/RDSEED. > >In the paper it was mentioned that if the quality attribute

Re: [PATCH] crypto: caam - properly set IV after {en,de}crypt

On 8/14/2017 10:59 AM, Gilad Ben-Yossef wrote: > Hi, > > On Thu, Jun 29, 2017 at 1:19 PM, Horia Geantă wrote: >> On 6/28/2017 4:42 PM, Horia Geantă wrote: >>> On 6/28/2017 4:27 PM, David Gstir wrote: Certain cipher modes like CTS expect the IV (req->info) of ablkcipher_request (or equiv

Re: HWRNGs without quality attribute - are they used or not?

Am Dienstag, 5. September 2017, 15:54:02 CEST schrieb Peter Huewe: Hi Peter, > Hi, > > while reading through the analysis of the Linux RNG by the BSI [1][2], > I was suprised by the lack of reflecting on the usage of HWRNGs except > RDRAND/RDSEED. Sure, the study is about assessing entropy. How

HWRNGs without quality attribute - are they used or not?

Hi, while reading through the analysis of the Linux RNG by the BSI [1][2], I was suprised by the lack of reflecting on the usage of HWRNGs except RDRAND/RDSEED. In the paper it was mentioned that if the quality attribute of a regular hwrng is not set (or specified via the module parameter defau

[PATCH v8 07/20] crypto: move algif to generic async completion

algif starts several async crypto ops and waits for their completion. Move it over to generic code doing the same. Signed-off-by: Gilad Ben-Yossef --- crypto/af_alg.c | 27 --- crypto/algif_aead.c | 8 crypto/algif_hash.c | 30 ++-

[PATCH v8 13/20] dm: move dm-verity to generic async completion

dm-verity is starting async. crypto ops and waiting for them to complete. Move it over to generic code doing the same. This also avoids a future potential data coruption bug created by the use of wait_for_completion_interruptible() without dealing correctly with an interrupt aborting the wait prio

[PATCH v8 15/20] ima: move to generic async completion

ima starts several async crypto ops and waits for their completions. Move it over to generic code doing the same. Signed-off-by: Gilad Ben-Yossef Acked-by: Mimi Zohar --- security/integrity/ima/ima_crypto.c | 56 +++-- 1 file changed, 17 insertions(+), 39 deleti

[PATCH v8 20/20] crypto: adapt api sample to use async. op wait

The code sample is waiting for an async. crypto op completion. Adapt sample to use the new generic infrastructure to do the same. This also fixes a possible data coruption bug created by the use of wait_for_completion_interruptible() without dealing correctly with an interrupt aborting the wait pr

[PATCH v8 19/20] crypto: mediatek: move to generic async completion

The mediatek driver starts several async crypto ops and waits for their completions. Move it over to generic code doing the same. Signed-off-by: Gilad Ben-Yossef Acked-by: Ryder Lee --- drivers/crypto/mediatek/mtk-aes.c | 31 +-- 1 file changed, 5 insertions(+), 26 d

[PATCH v8 18/20] crypto: qce: move to generic async completion

The qce driver starts several async crypto ops and waits for their completions. Move it over to generic code doing the same. Signed-off-by: Gilad Ben-Yossef --- drivers/crypto/qce/sha.c | 30 -- 1 file changed, 4 insertions(+), 26 deletions(-) diff --git a/drivers/c

[PATCH v8 16/20] crypto: tcrypt: move to generic async completion

tcrypt starts several async crypto ops and waits for their completions. Move it over to generic code doing the same. Signed-off-by: Gilad Ben-Yossef --- crypto/tcrypt.c | 84 + 1 file changed, 25 insertions(+), 59 deletions(-) diff --git

[PATCH v8 17/20] crypto: talitos: move to generic async completion

The talitos driver starts several async crypto ops and waits for their completions. Move it over to generic code doing the same. Signed-off-by: Gilad Ben-Yossef --- drivers/crypto/talitos.c | 38 +- 1 file changed, 5 insertions(+), 33 deletions(-) diff --git

[PATCH v8 14/20] cifs: move to generic async completion

cifs starts an async. crypto op and waits for their completion. Move it over to generic code doing the same. Signed-off-by: Gilad Ben-Yossef Acked-by: Pavel Shilovsky --- fs/cifs/smb2ops.c | 30 -- 1 file changed, 4 insertions(+), 26 deletions(-) diff --git a/fs/cif

[PATCH v8 12/20] fscrypt: move to generic async completion

fscrypt starts several async. crypto ops and waiting for them to complete. Move it over to generic code doing the same. Signed-off-by: Gilad Ben-Yossef --- fs/crypto/crypto.c | 28 fs/crypto/fname.c | 36 ++-- fs/cry

[PATCH v8 11/20] crypto: move testmgr to generic async completion

testmgr is starting async. crypto ops and waiting for them to complete. Move it over to generic code doing the same. This also provides a test of the generic crypto async. wait code. Signed-off-by: Gilad Ben-Yossef --- crypto/testmgr.c | 204 ++---

[PATCH v8 10/20] crypto: move gcm to generic async completion

gcm is starting an async. crypto op and waiting for it complete. Move it over to generic code doing the same. Signed-off-by: Gilad Ben-Yossef --- crypto/gcm.c | 32 ++-- 1 file changed, 6 insertions(+), 26 deletions(-) diff --git a/crypto/gcm.c b/crypto/gcm.c index 3

[PATCH v8 09/20] crypto: move drbg to generic async completion

DRBG is starting an async. crypto op and waiting for it complete. Move it over to generic code doing the same. The code now also passes CRYPTO_TFM_REQ_MAY_SLEEP flag indicating crypto request memory allocation may use GFP_KERNEL which should be perfectly fine as the code is obviously sleeping for

[PATCH v8 08/20] crypto: move pub key to generic async completion

public_key_verify_signature() is starting an async crypto op and waiting for it to complete. Move it over to generic code doing the same. Signed-off-by: Gilad Ben-Yossef --- crypto/asymmetric_keys/public_key.c | 28 1 file changed, 4 insertions(+), 24 deletions(-) d

[PATCH v8 05/20] crypto: marvell/cesa: remove redundant backlog checks on EBUSY

Now that -EBUSY return code only indicates backlog queueing we can safely remove the now redundant check for the CRYPTO_TFM_REQ_MAY_BACKLOG flag when -EBUSY is returned. Signed-off-by: Gilad Ben-Yossef Acked-by: Boris Brezillon --- drivers/crypto/marvell/cesa.c | 3 +-- drivers/crypto/marvell/c

[PATCH v8 06/20] crypto: introduce crypto wait for async op

Invoking a possibly async. crypto op and waiting for completion while correctly handling backlog processing is a common task in the crypto API implementation and outside users of it. This patch adds a generic implementation for doing so in preparation for using it across the board instead of hand

[PATCH v8 04/20] crypto: remove redundant backlog checks on EBUSY

Now that -EBUSY return code only indicates backlog queueing we can safely remove the now redundant check for the CRYPTO_TFM_REQ_MAY_BACKLOG flag when -EBUSY is returned. Signed-off-by: Gilad Ben-Yossef --- crypto/ahash.c| 12 +++- crypto/cts.c | 6 ++ crypto/lrw.c

[PATCH v8 03/20] net: use -EAGAIN for transient busy indication

Replace -EBUSY with -EAGAIN when handling transient busy indication in the absence of backlog. Signed-off-by: Gilad Ben-Yossef --- Please squash this patch with the previous one when merging upstream. --- net/ipv4/ah4.c | 2 +- net/ipv4/esp4.c | 2 +- net/ipv6/ah6.c | 2 +- net/ipv6/esp6.c |

[PATCH v8 01/20] crypto: change transient busy return code to -EAGAIN

The crypto API was using the -EBUSY return value to indicate both a hard failure to submit a crypto operation into a transformation provider when the latter was busy and the backlog mechanism was not enabled as well as a notification that the operation was queued into the backlog when the backlog m

[PATCH v8 02/20] crypto: ccp: use -EAGAIN for transient busy indication

Replace -EBUSY with -EAGAIN when reporting transient busy indication in the absence of backlog. Signed-off-by: Gilad Ben-Yossef Reviewed-by: Gary R Hook --- Please squash this patch with the previous one when merging upstream. --- drivers/crypto/ccp/ccp-crypto-main.c | 8 +++- drivers/cry

[PATCH v8 00/20] simplify crypto wait for async op

all of the corner cases. The patch set is based upon linux-next release tagged next-20170905. Changes from v7: - Turn -EBUSY to -EAGAIN also in crypto using net code which I missed before, as has been pointed out by Harsh Jain. Changes from v6: - Fix brown paper bag compile error on marvell

Re: [PATCH v7 00/19] simplify crypto wait for async op

On Tue, Sep 5, 2017 at 2:23 PM, Harsh Jain wrote: > On Sun, Sep 3, 2017 at 11:47 AM, Gilad Ben-Yossef wrote: >> On Thu, Aug 31, 2017 at 3:31 PM, Harsh Jain wrote: >>> HI Gilad, >>> >>> I think we need an update in ESP also. Now EBUSY return means driver >>> has accepted, Packet should not be dro

Re: [PATCH v7 00/19] simplify crypto wait for async op

On Sun, Sep 3, 2017 at 11:47 AM, Gilad Ben-Yossef wrote: > On Thu, Aug 31, 2017 at 3:31 PM, Harsh Jain wrote: >> HI Gilad, >> >> I think we need an update in ESP also. Now EBUSY return means driver >> has accepted, Packet should not be dropped in >> >> esp_output_tail() function. > > Good catch.