Re: [PATCH V3 6/6] crypto/nx: Add P9 NX support for 842 compression engine

On 08/31/2017 06:31 AM, Dan Streetman wrote: > On Tue, Aug 29, 2017 at 5:54 PM, Haren Myneni > wrote: >> On 08/29/2017 02:23 PM, Benjamin Herrenschmidt wrote: >>> On Tue, 2017-08-29 at 09:58 -0400, Dan Streetman wrote: > + > + ret = -EINVAL; > + if (coproc && coproc->vas.r

Re: [PATCH V3 6/6] crypto/nx: Add P9 NX support for 842 compression engine

On 08/31/2017 06:40 AM, Dan Streetman wrote: > On Thu, Aug 31, 2017 at 3:44 AM, Haren Myneni > wrote: >> Thanks MIchael and Dan for your review comments. >> >> >> On 08/29/2017 06:32 AM, Dan Streetman wrote: >>> On Mon, Aug 28, 2017 at 7:25 PM, Michael Ellerman >>> wrote: Hi Haren, >>

Re: [PATCH] crypto: MPI - kunmap after finishing accessing buffer

On Wed, Aug 30, 2017 at 06:33:41PM +0200, Stephan Mueller wrote: > Am Dienstag, 22. August 2017, 08:33:15 CEST schrieb Herbert Xu: > > Hi Herbert, > > > On Thu, Aug 10, 2017 at 08:06:18AM +0200, Stephan Müller wrote: > > > Hi Herbert, > > > > > > I found that issue while playing around with edge

Re: [PATCH V3 6/6] crypto/nx: Add P9 NX support for 842 compression engine

On Thu, Aug 31, 2017 at 3:44 AM, Haren Myneni wrote: > Thanks MIchael and Dan for your review comments. > > > On 08/29/2017 06:32 AM, Dan Streetman wrote: >> On Mon, Aug 28, 2017 at 7:25 PM, Michael Ellerman >> wrote: >>> Hi Haren, >>> >>> Some comments inline ... >>> >>> Haren Myneni writes: >

Re: [PATCH V3 6/6] crypto/nx: Add P9 NX support for 842 compression engine

On Tue, Aug 29, 2017 at 5:54 PM, Haren Myneni wrote: > On 08/29/2017 02:23 PM, Benjamin Herrenschmidt wrote: >> On Tue, 2017-08-29 at 09:58 -0400, Dan Streetman wrote: + + ret = -EINVAL; + if (coproc && coproc->vas.rxwin) { + wmem->txwin = nx842_alloc_

Re: [PATCH v7 00/19] simplify crypto wait for async op

HI Gilad, I think we need an update in ESP also. Now EBUSY return means driver has accepted, Packet should not be dropped in esp_output_tail() function. . Regards Harsh Jain On Thu, Aug 24, 2017 at 7:48 PM, Gilad Ben-Yossef wrote: > Many users of kernel async. crypto services have a pattern

Re: [PATCH V3 6/6] crypto/nx: Add P9 NX support for 842 compression engine

Thanks MIchael and Dan for your review comments. On 08/29/2017 06:32 AM, Dan Streetman wrote: > On Mon, Aug 28, 2017 at 7:25 PM, Michael Ellerman wrote: >> Hi Haren, >> >> Some comments inline ... >> >> Haren Myneni writes: >> >>> diff --git a/drivers/crypto/nx/nx-842-powernv.c >>> b/drivers/c

[PATCH V4 7/7] crypto/nx: Add P9 NX support for 842 compression engine

This patch adds P9 NX support for 842 compression engine. Virtual Accelerator Switchboard (VAS) is used to access 842 engine on P9. For each NX engine per chip, setup receive window using vas_rx_win_open() which configures RxFIFo with FIFO address, lpid, pid and tid values. This unique (lpid, pid

[PATCH V4 6/7] crypto/nx: Add P9 NX specific error codes for 842 engine

This patch adds changes for checking P9 specific 842 engine error codes. These errros are reported in coprocessor status block (CSB) for failures. Signed-off-by: Haren Myneni --- arch/powerpc/include/asm/icswx.h | 3 +++ drivers/crypto/nx/nx-842-powernv.c | 18 ++ drivers/cry

[PATCH V4 5/7] crypto/nx: Use kzalloc for workmem allocation

Send window is opened / closed for each crypto session. So initializes txwin in workmem. Signed-off-by: Haren Myneni --- drivers/crypto/nx/nx-842.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/nx/nx-842.c b/drivers/crypto/nx/nx-842.c index d94e25df503b..da3

[PATCH V4 4/7] crypto/nx: Add nx842_add_coprocs_list function

Updating coprocessor list is moved to nx842_add_coprocs_list(). This function will be used for both icswx and VAS functions. Signed-off-by: Haren Myneni --- drivers/crypto/nx/nx-842-powernv.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/crypto/nx/nx-8

[PATCH V4 2/7] crypto/nx: Create nx842_configure_crb function

Configure CRB is moved to nx842_configure_crb() so that it can be used for icswx and VAS exec functions. VAS function will be added later with P9 support. Signed-off-by: Haren Myneni --- drivers/crypto/nx/nx-842-powernv.c | 57 +- 1 file changed, 38 insertion

[PATCH V4 3/7] crypto/nx: Create nx842_delete_coprocs function

Move deleting coprocessors info upon exit or failure to nx842_delete_coprocs(). Signed-off-by: Haren Myneni --- drivers/crypto/nx/nx-842-powernv.c | 25 - 1 file changed, 12 insertions(+), 13 deletions(-) diff --git a/drivers/crypto/nx/nx-842-powernv.c b/drivers/crypto

[PATCH V4 1/7] crypto/nx: Rename nx842_powernv_function as icswx function

Rename nx842_powernv_function to nx842_powernv_exec. nx842_powernv_exec points to nx842_exec_icswx and will be point to VAS exec function which will be added later for P9 NX support. Signed-off-by: Haren Myneni --- drivers/crypto/nx/nx-842-powernv.c | 20 +--- 1 file changed, 13

[PATCH V4 0/7] Enable NX 842 compression engine on Power9

P9 introduces Virtual Accelerator Switchboard (VAS) to communicate with NX 842 engine. icswx function is used to access NX before. On powerNV systems, NX-842 driver invokes VAS functions for configuring RxFIFO (receive window) per each NX engine. VAS uses this FIFO to communicate the request to NX