Re: random.c: LFSR polynomials are not irreducible/primitive

2017-08-16 Thread Stephan Mueller
Am Dienstag, 15. August 2017, 17:12:24 CEST schrieb Theodore Ts'o: Hi Theodore, Jeffrey, > > Stephan, if you have any comments on the proposal made by David > Fontaine and Olivier Vivolo, I'd appreciate hearing them! (from Jefferey): > This may be helpful, too. I use it to look up minimal weigh

Re: [PATCH v3 00/22] staging: ccree: fixes and simplifications

2017-08-16 Thread Greg Kroah-Hartman
On Tue, Aug 15, 2017 at 09:26:28AM +0300, Gilad Ben-Yossef wrote: > The series includes various bug fixes, code simplification and style > cleanups. > > Changer from v2: > - Drop M32R as supported architecture, which resolve the kbuild bot > warnings on Joe Perches patch. > - Bug fix that prope

Re: [PATCH] staging/ccree: Declare compiled out fuctions static inline

2017-08-16 Thread Greg KH
On Mon, Jul 31, 2017 at 02:47:23PM +0530, RishabhHardas wrote: > From: RishabhHardas > > Sparse was giving out a warning for symbols 'cc_set_ree_fips_status' and > 'fips_handler' > that they were not declared and need to be made static. This patch makes both > the symbols > static inline, to re

Re: [PATCH v3 11/22] staging: ccree: fix line indentation and breaks

2017-08-16 Thread Greg Kroah-Hartman
On Tue, Aug 15, 2017 at 09:26:39AM +0300, Gilad Ben-Yossef wrote: > Fix wrong indentation and line breaks, including missing tabs, > breaking lines longer then 80 char or wrongly broken. > > Signed-off-by: Gilad Ben-Yossef > --- > drivers/staging/ccree/ssi_driver.c | 107 > +

Re: random.c: LFSR polynomials are not irreducible/primitive

2017-08-16 Thread Fontaine david
Hi, Sorry to answer this late, but i was pretty busy, and i assume Olivier Vivolo is on vacation. For a polynomial, being primitive implies being irreducible, and the polynomial which must be primitive is Q(x), as you described it earlier, on GF(2^32). When the polynomials will be primitive,the T

Re: random.c: LFSR polynomials are not irreducible/primitive

2017-08-16 Thread Stephan Mueller
Am Dienstag, 15. August 2017, 17:12:24 CEST schrieb Theodore Ts'o: Hi Theodore, > > Stephan, if you have any comments on the proposal made by David > Fontaine and Olivier Vivolo, I'd appreciate hearing them! I think I have some news: The magma code I used for GF(2^32) testing was not correct.

Re: [PATCH] crypto: mediatek - Add empty messages check in GCM mode

2017-08-16 Thread Ryder Lee
Hi, On Wed, 2017-08-16 at 14:18 +0200, Stephan Mueller wrote: > Am Mittwoch, 16. August 2017, 13:19:48 CEST schrieb Ryder Lee: > > Hi Ryder, > > > Currently, empty messages are not supported in GCM mode, hence add > > a check to prevent producing incorrect results. > > In case the caller would

Re: [PATCH] crypto: mediatek - Add empty messages check in GCM mode

2017-08-16 Thread Stephan Mueller
Am Mittwoch, 16. August 2017, 13:19:48 CEST schrieb Ryder Lee: Hi Ryder, > Currently, empty messages are not supported in GCM mode, hence add > a check to prevent producing incorrect results. In case the caller would provide empty messages, would there be just wrong data or a real problem? Note

[PATCH] crypto: mediatek - Add empty messages check in GCM mode

2017-08-16 Thread Ryder Lee
Currently, empty messages are not supported in GCM mode, hence add a check to prevent producing incorrect results. Signed-off-by: Ryder Lee --- drivers/crypto/mediatek/mtk-aes.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/crypto/mediatek/mtk-aes.c b/drivers/crypto/mediatek/

[PATCH v4] crypto: only call put_page on referenced and used pages

2017-08-16 Thread Stephan Müller
Hi Herbert, This patch was created against the current Linus development tree. The functional test was conducted at the time v3 was aired. The patch v4 is compile-tested. Ciao Stephan ---8<--- For asynchronous operation, SGs are allocated without a page mapped to them or with a page that is not

Re: [PATCH v2] crypto: AF_ALG - consolidation of duplicate code

2017-08-16 Thread Stephan Mueller
Am Mittwoch, 16. August 2017, 11:37:31 CEST schrieb Herbert Xu: Hi Herbert, > On Wed, Aug 16, 2017 at 10:39:43AM +0200, Stephan Mueller wrote: > > Are you feeding that patch to the Linus 4.13-rc tree via your crypto-2.6 > > tree? > Good point. Why don't you repost that patch and I'll push it > t

Re: [PATCH v2] crypto: AF_ALG - consolidation of duplicate code

2017-08-16 Thread Herbert Xu
On Wed, Aug 16, 2017 at 10:39:43AM +0200, Stephan Mueller wrote: > > Are you feeding that patch to the Linus 4.13-rc tree via your crypto-2.6 tree? Good point. Why don't you repost that patch and I'll push it to 4.13 along with stable. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apan

Re: [PATCH 2/3] crypto: engine - find request type with cra_type

2017-08-16 Thread Corentin Labbe
On Tue, Aug 15, 2017 at 07:51:14AM +, Fabien DESSENNE wrote: > Hi Corentin, > > Since I have just sent a patch to add the support of "aead_request" to crypto > engine, I am wondering if your proposed change (checking cra_type instead of > crypto_tfm_alg_type) and mine are compatible. > It lo

Re: [PATCH v5] crypto : stm32 - Add STM32F4 CRC32 support

2017-08-16 Thread Lionel DEBIEVE
Hi Cosar, Sorry for the delay to feedback. This implementation is in the good way. But it should be better to use platform data and use array with type of algs instead of duplicating the algo description for each platform. If we add a new platform, with another type of crc, we will again duplicat

Re: [PATCH v2] crypto: AF_ALG - consolidation of duplicate code

2017-08-16 Thread Stephan Mueller
Am Mittwoch, 16. August 2017, 10:29:18 CEST schrieb Herbert Xu: Hi Herbert, > On Thu, Aug 10, 2017 at 10:25:58AM +0200, Stephan Mueller wrote: > > I think there is such patch already, see [1]. > > > > Your comment to that patch triggered my rewrite of the memory managment > > code. > > > > [1]

Re: [PATCH v2] crypto: AF_ALG - consolidation of duplicate code

2017-08-16 Thread Herbert Xu
On Thu, Aug 10, 2017 at 10:25:58AM +0200, Stephan Mueller wrote: > > I think there is such patch already, see [1]. > > Your comment to that patch triggered my rewrite of the memory managment code. > > [1] https://www.spinics.net/lists/linux-crypto/msg21618.html Could you please post that patch t