Re: [PATCH 3/3] crypto: hwrng add sysfs attribute to show user selected rng

2017-07-05 Thread PrasannaKumar Muralidharan
Hi Harald, > Here is an updated version with just showing 0 or 1 in the new sysfs > attribute file: > == cut == > From: Harald Freudenberger > Date: Mon, 3 Jul 2017 10:19:22 +0200 > Subject: [PATCH 3/3] crypto: hwrng add sysfs attribute to show user selected > rng > > This patch

Re: Crypto Update for 4.13

2017-07-05 Thread Herbert Xu
On Wed, Jul 05, 2017 at 01:02:59PM -0700, Linus Torvalds wrote: > > That stupid CNN55XX driver was added with a default of "m"? > > WTF? Hell no. We don't add random new drivers and default them on - > and we do so even less when they are for very unusual hardware. Sorry, I'll make sure the defau

Re: Crypto Update for 4.13

2017-07-05 Thread Linus Torvalds
On Wed, Jul 5, 2017 at 6:01 AM, Herbert Xu wrote: > > Drivers: > > - Add support for CNN55XX adapters in cavium. Grr. I noticed this too late to fix it in the merge. That stupid CNN55XX driver was added with a default of "m"? WTF? Hell no. We don't add random new drivers and default them on - a

Re: Antw: Re: [kernel-hardening] Re: [PATCH v4 06/13] iscsi: ensure RNG is seeded before use

2017-07-05 Thread Theodore Ts'o
On Wed, Jul 05, 2017 at 09:16:09AM -0400, Paul Koning wrote: > > In the implementations I know, /dev/random and /dev/urandom are the > same driver, the only difference is that when you read from > /dev/random there's a check for the current entropy level. It's in the same driver but /dev/random a

Re: Antw: Re: [kernel-hardening] Re: [PATCH v4 06/13] iscsi: ensure RNG is seeded before use

2017-07-05 Thread Paul Koning
> On Jul 5, 2017, at 3:08 AM, Ulrich Windl > wrote: > Jeffrey Walton schrieb am 17.06.2017 um 16:23 in Nachricht > : > > [...] >> But its not clear to me how to ensure uniqueness when its based on >> randomness from the generators. > > Even with a perfect random generator non-uniq

Crypto Update for 4.13

2017-07-05 Thread Herbert Xu
Hi Linus: Here is the crypto update for 4.13: Algorithms: - Add private key generation to ecdh. Drivers: - Add generic gcm(aes) to aesni-intel. - Add SafeXcel EIP197 crypto engine driver. - Add ecb(aes), cfb(aes) and ecb(des3_ede) to cavium. - Add support for CNN55XX adapters in cavium. - Add

Re: Antw: Re: [kernel-hardening] Re: [PATCH v4 06/13] iscsi: ensure RNG is seeded before use

2017-07-05 Thread Theodore Ts'o
On Wed, Jul 05, 2017 at 09:03:43AM +0200, Ulrich Windl wrote: > > Note, during the development of my /dev/random implementation, I added the > > getrandom-like blocking behavior to /dev/urandom (which is the equivalent to > > Jason's patch except that it applies to user space). The boot process lo

Re: [PATCH 0/3] crypto: introduce Microchip / Atmel ECC driver

2017-07-05 Thread Marcel Holtmann
Hi Tudor, >>> This patch set introduces Microchip / Atmel ECC driver. >>> >>> The first patch adds some helpers that will be used by fallbacks to >>> kpp software implementations. >>> >>> The second patch adds ECDH support for the ATECC508A (I2C) >>> cryptographic engine. The I2C interface is de

Re: [PATCH v2 6/6] ima: Support module-style appended signatures for appraisal

2017-07-05 Thread Mimi Zohar
On Tue, 2017-07-04 at 23:22 -0300, Thiago Jung Bauermann wrote: > Mimi Zohar writes: > > > On Wed, 2017-06-21 at 14:45 -0300, Thiago Jung Bauermann wrote: > >> Mimi Zohar writes: > >> > On Wed, 2017-06-07 at 22:49 -0300, Thiago Jung Bauermann wrote: > >> >> @@ -267,11 +276,18 @@ int ima_appraise

Re: [PATCH 3/3] crypto: hwrng add sysfs attribute to show user selected rng

2017-07-05 Thread Harald Freudenberger
On 07/04/2017 03:15 PM, PrasannaKumar Muralidharan wrote: > On 3 July 2017 at 15:33, Harald Freudenberger > wrote: >> This patch introduces a new sysfs attribute file 'rng_selected' >> which shows the the rng chosen by userspace. >> >> If a rng source is chosen by user via echo some valid string

Re: [PATCH 0/3] crypto: introduce Microchip / Atmel ECC driver

2017-07-05 Thread Tudor Ambarus
Hi, Marcel, On 05.07.2017 13:54, Marcel Holtmann wrote: Hi Tudor, This patch set introduces Microchip / Atmel ECC driver. The first patch adds some helpers that will be used by fallbacks to kpp software implementations. The second patch adds ECDH support for the ATECC508A (I2C) cryptographic

Re: [PATCH 0/3] crypto: introduce Microchip / Atmel ECC driver

2017-07-05 Thread Marcel Holtmann
Hi Tudor, > This patch set introduces Microchip / Atmel ECC driver. > > The first patch adds some helpers that will be used by fallbacks to > kpp software implementations. > > The second patch adds ECDH support for the ATECC508A (I2C) > cryptographic engine. The I2C interface is designed to oper

[PATCH 2/3] crypto: introduce Microchip / Atmel ECC driver

2017-07-05 Thread Tudor Ambarus
Add ECDH support for ATECC508A (I2C) device. The device features hardware acceleration for the NIST standard P256 prime curve and supports the complete key life cycle from private key generation to ECDH key agreement. Random private key generation is supported internally within the device to ensu

[PATCH 0/3] crypto: introduce Microchip / Atmel ECC driver

2017-07-05 Thread Tudor Ambarus
Hi, This patch set introduces Microchip / Atmel ECC driver. The first patch adds some helpers that will be used by fallbacks to kpp software implementations. The second patch adds ECDH support for the ATECC508A (I2C) cryptographic engine. The I2C interface is designed to operate at a maximum clo

[PATCH 3/3] MAINTAINERS: add a maintainer for Microchip / Atmel ECC driver

2017-07-05 Thread Tudor Ambarus
A new cryptographic engine driver was added in drivers/crypto/atmel-ecc.*. Add myself as a maintainer for this driver. Signed-off-by: Tudor Ambarus --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index a24eb8c..d55b983 100644 --- a/MAINTAINERS

[PATCH 1/3] crypto: kpp: add get/set_flags helpers

2017-07-05 Thread Tudor Ambarus
These helpers will be used for fallbacks to kpp software implementations. Signed-off-by: Tudor Ambarus --- include/crypto/kpp.h | 10 ++ 1 file changed, 10 insertions(+) diff --git a/include/crypto/kpp.h b/include/crypto/kpp.h index 2133d17..1bde0a6 100644 --- a/include/crypto/kpp.h +++

Antw: Re: [kernel-hardening] Re: [PATCH v4 06/13] iscsi: ensure RNG is seeded before use

2017-07-05 Thread Ulrich Windl
>>> Jeffrey Walton schrieb am 17.06.2017 um 16:23 in >>> Nachricht : [...] > But its not clear to me how to ensure uniqueness when its based on > randomness from the generators. Even with a perfect random generator non-unique values are possible (that's why it's random). It's unlikely, but it

Antw: Re: [kernel-hardening] Re: [PATCH v4 06/13] iscsi: ensure RNG is seeded before use

2017-07-05 Thread Ulrich Windl
>>> Stephan Müller schrieb am 26.06.2017 um 19:38 in Nachricht <1678474.gnybdsl...@tauon.chronox.de>: > Am Montag, 26. Juni 2017, 03:23:09 CEST schrieb Nicholas A. Bellinger: > > Hi Nicholas, > >> Hi Stephan, Lee & Jason, >> >> (Adding target-devel CC') >> >> Apologies for coming late to the d