Re: [PATCH] random: silence compiler warnings and fix race

2017-06-19 Thread Sebastian Andrzej Siewior
On 2017-06-19 22:55:37 [+0200], Jason A. Donenfeld wrote: > On Mon, Jun 19, 2017 at 9:45 AM, Sebastian Andrzej Siewior > wrote: > > ehm. You sure? I simply delayed the lock-dropping _after_ the state > > variable was been modified. So it was basically what your patch did > > except it was unlocked

Re: [kernel-hardening] Re: [PATCH] random: silence compiler warnings and fix race

2017-06-19 Thread Joel Stanley
ANDOM so that the answer is 'n'. It *is* spammy > for PowerPC, because they aren't getting their CRNG initialized > quickly enough, so several userspace processes are getting > fork/exec'ed with an uninitialized CRNG. It's very spammy for ARM as well. I booted next-2

Re: [PATCH v6 1/5] Documentation/bindings: Document the SafeXel cryptographic engine driver

2017-06-19 Thread Antoine Tenart
On Tue, Jun 20, 2017 at 11:37:47AM +0800, Herbert Xu wrote: > On Sun, Jun 11, 2017 at 10:53:53AM +0200, Antoine Tenart wrote: > > On Wed, May 24, 2017 at 04:10:31PM +0200, Antoine Tenart wrote: > > > The Inside Secure Safexcel cryptographic engine is found on some Marvell > > > SoCs (7k/8k). Docume

Re: [PATCH] random: silence compiler warnings and fix race

2017-06-19 Thread Theodore Ts'o
On Mon, Jun 19, 2017 at 10:57:18PM +0200, Jason A. Donenfeld wrote: > > With rc6 already released and rc7 coming up, I'd really appreciate you > stepping in here and either ACKing the above commit, or giving your > two cents about it in case I need to roll something different. I actually had set

[PATCH 11/11] Fix ERROR: "foo* bar" should be "foo *bar"

2017-06-19 Thread Jhih-Ming Huang
From: Jhih-Ming Hunag Fixed 'ERROR: "foo* bar" should be "foo *bar"'. Signed-off-by: Jhih-Ming Hunag --- drivers/staging/ccree/ssi_aead.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/ccree/ssi_aead.c b/drivers/staging/ccree/ssi_aead.c index c148d81..c70e4

[PATCH 10/11] Fix ERROR: else should follow close brace '}'

2017-06-19 Thread Jhih-Ming Huang
From: Jhih-Ming Hunag Fixied "ERROR: else should follow close brace '}'". Signed-off-by: Jhih-Ming Hunag --- drivers/staging/ccree/ssi_aead.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/ccree/ssi_aead.c b/drivers/staging/ccree/ssi_aead.c index d697244.

[PATCH 08/11] Fix ERROR: space prohibited before open square bracket '['

2017-06-19 Thread Jhih-Ming Huang
From: Jhih-Ming Hunag Fixied "ERROR: space prohibited before open square bracket '['". Signed-off-by: Jhih-Ming Hunag --- drivers/staging/ccree/ssi_aead.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/ccree/ssi_aead.c b/drivers/staging/ccree/ssi_aead.c ind

[PATCH 09/11] Fix ERROR: space prohibited before that ','

2017-06-19 Thread Jhih-Ming Huang
From: Jhih-Ming Hunag Fixed "ERROR: space prohibited before that ','". Signed-off-by: Jhih-Ming Hunag --- drivers/staging/ccree/ssi_aead.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/ccree/ssi_aead.c b/drivers/staging/ccree/ssi_aead.c index 6d2c0

[PATCH 07/11] Fix ERROR: open brace '{' following function declarations go on the next line

2017-06-19 Thread Jhih-Ming Huang
From: Jhih-Ming Hunag Fixed "ERROR: open brace '{' following function declarations go on the next line". Signed-off-by: Jhih-Ming Hunag --- drivers/staging/ccree/ssi_aead.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/staging/ccree/ssi_aead.c b/drivers/sta

[PATCH 06/11] Fix ERROR: space prohibited before that close parenthesis ')'

2017-06-19 Thread Jhih-Ming Huang
From: Jhih-Ming Hunag Fixed "ERROR: space prohibited before that close parenthesis ')'". Signed-off-by: Jhih-Ming Hunag --- drivers/staging/ccree/ssi_aead.c | 30 +++--- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/drivers/staging/ccree/ssi_aead.c b/d

[PATCH 05/11] Fix ERROR: space prohibited after that open parenthesis '('

2017-06-19 Thread Jhih-Ming Huang
From: Jhih-Ming Hunag Fixed "ERROR: space prohibited after that open parenthesis '('". Signed-off-by: Jhih-Ming Hunag --- drivers/staging/ccree/ssi_aead.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/staging/ccree/ssi_aead.c b/drivers/staging/ccr

[PATCH 04/11] Fix ERROR: that open brace { should be on the previous line

2017-06-19 Thread Jhih-Ming Huang
From: Jhih-Ming Hunag Fixed 'ERROR: that open brace { should be on the previous line'. Signed-off-by: Jhih-Ming Hunag --- drivers/staging/ccree/ssi_aead.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/staging/ccree/ssi_aead.c b/drivers/staging/ccree/ssi_aead

[PATCH 03/11] Fix ERROR: space required before the open brace

2017-06-19 Thread Jhih-Ming Huang
From: Jhih-Ming Hunag Fixed 'ERROR: space required before the open brace'. Signed-off-by: Jhih-Ming Hunag --- drivers/staging/ccree/ssi_aead.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/ccree/ssi_aead.c b/drivers/staging/ccree/ssi_aead.c index 0f9

[PATCH 02/11] Fix ERROR: spaces required around that

2017-06-19 Thread Jhih-Ming Huang
From: Jhih-Ming Hunag Fixed 'ERROR: spaces required around that' Signed-off-by: Jhih-Ming Hunag --- drivers/staging/ccree/ssi_aead.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/ccree/ssi_aead.c b/drivers/staging/ccree/ssi_aead.c index 5bc3a5

[PATCH 01/11] Fix coding style of driver/staging/ccree/ssi_aead.c ERROR: space required after that

2017-06-19 Thread Jhih-Ming Huang
From: Jhih-Ming Hunag In this series patches, I fix all of the coding style error in driver/staging/ccree/ssi_aead.c from 54 errors to 0 error. The first patch fixed 'ERROR: space required after that'. Signed-off-by: Jhih-Ming Hunag --- drivers/staging/ccree/ssi_aead.c | 22 +++--

Re: [PATCH] crypto: caam: make of_device_ids const.

2017-06-19 Thread Herbert Xu
On Fri, Jun 16, 2017 at 02:46:44PM +0530, Arvind Yadav wrote: > of_device_ids are not supposed to change at runtime. All functions > working with of_device_ids provided by work with const > of_device_ids. So mark the non-const structs as const. > > File size before: >text data bs

Re: [PATCH] crypto: vmx: remove unnecessary check

2017-06-19 Thread Herbert Xu
On Fri, Jun 16, 2017 at 11:39:48AM +0300, Tudor Ambarus wrote: > You can't reach init() if parent alg_name is invalid. Moreover, > cypto_alloc_base() will return ENOENT if alg_name is NULL. > Found while grasping the fallback mechanism. > > Signed-off-by: Tudor Ambarus Patch applied. Thanks. --

Re: [PATCH] crypto: n2: make of_device_ids const

2017-06-19 Thread Herbert Xu
On Thu, Jun 15, 2017 at 05:28:10PM +0530, Arvind Yadav wrote: > of_device_ids are not supposed to change at runtime. All functions > working with of_device_ids provided by work with const > of_device_ids. So mark the non-const structs as const. > > File size before: >text data bs

Re: [PATCH 00/13] crypto: inside-secure - various improvements

2017-06-19 Thread Herbert Xu
On Thu, Jun 15, 2017 at 09:56:16AM +0200, Antoine Tenart wrote: > Hi Herbert, > > This series improves the newly added inside-secure driver in various > ways. There are also a few non-critical fixes. > > The series is based on top of your cryptodev/master branch, as it > depends on the inside-sec

Re: [PATCH 0/9] Bug fixes and ctr mode of operation

2017-06-19 Thread Herbert Xu
On Thu, Jun 15, 2017 at 12:43:38PM +0530, Harsh Jain wrote: > This series is based on cryptodev2.6 tree and includes bug fix ,ctr(aes), > rfc3686(ctr(aes)) algo. > > Harsh Jain (7): > crypto: chcr - Pass lcb bit setting to firmware > crypto: chcr - Set fallback key > crypto: chcr - Return c

Re: [PATCH][crypto-next] crypto: cavium: fix spelling mistake "Revsion" -> "Revision"

2017-06-19 Thread Herbert Xu
On Tue, Jun 13, 2017 at 09:52:54AM +0100, Colin King wrote: > From: Colin Ian King > > Trivial fix to spelling mistake in seq_printf message > > Signed-off-by: Colin Ian King Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.a

Re: [PATCH][crypto-next] crypto: omap-aes: fix spelling mistake "Encryptio" -> "Encryption"

2017-06-19 Thread Herbert Xu
On Tue, Jun 13, 2017 at 09:46:47AM +0100, Colin King wrote: > From: Colin Ian King > > Trivial fix to spelling mistake in pr_err message > > Signed-off-by: Colin Ian King Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana

Re: [PATCH v2 0/3] add support of hardware random generator on MediaTek MT7622

2017-06-19 Thread Herbert Xu
On Mon, Jun 12, 2017 at 11:56:53PM +0800, sean.w...@mediatek.com wrote: > From: Sean Wang > > Changes since v1: > - update the bindings with the specific "mediatek,mt7622-rng" > instead of the generic one as "mediatek,generic-rng" > > The series add support of hardware RNG on MediaTek MT7622 a

Re: [PATCH] crypto: testmgr - add testvector for pkcs1pad(rsa)

2017-06-19 Thread Herbert Xu
On Mon, Jun 12, 2017 at 11:27:51PM +0200, Stephan Müller wrote: > The PKCS#1 RSA implementation is provided with a self test with RSA 2048 > and SHA-256. This self test implicitly covers other RSA keys and other > hashes. Also, this self test implies that the pkcs1pad(rsa) is FIPS > 140-2 compliant

Re: [PATCH] rsa-pkcs1pad: use constant time memory comparison for MACs

2017-06-19 Thread Herbert Xu
On Sun, Jun 11, 2017 at 11:20:23PM +0200, Jason A. Donenfeld wrote: > Otherwise, we enable all sorts of forgeries via timing attack. > > Signed-off-by: Jason A. Donenfeld > Suggested-by: Stephan Müller > Cc: sta...@vger.kernel.org > Cc: Herbert Xu > Cc: linux-crypto@vger.kernel.org Patch appli

Re: [PATCH v6 1/5] Documentation/bindings: Document the SafeXel cryptographic engine driver

2017-06-19 Thread Herbert Xu
On Sun, Jun 11, 2017 at 10:53:53AM +0200, Antoine Tenart wrote: > Hi Herbert, > > On Wed, May 24, 2017 at 04:10:31PM +0200, Antoine Tenart wrote: > > The Inside Secure Safexcel cryptographic engine is found on some Marvell > > SoCs (7k/8k). Document the bindings used by its driver. > > > > Signed

Re: [PATCH] crypto: crypto4xx - fix an error code

2017-06-19 Thread Herbert Xu
On Sat, Jun 10, 2017 at 02:54:33PM +0200, Christophe JAILLET wrote: > If 'kzalloc' fails, we return 0 which means success. > return -ENOMEM instead as already done a few lines above. > > Signed-off-by: Christophe JAILLET Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apa

Re: [PATCH v9 1/2] crypto: skcipher AF_ALG - overhaul memory management

2017-06-19 Thread Herbert Xu
On Sat, Jun 10, 2017 at 07:59:25PM +0200, Stephan Müller wrote: > > -static int skcipher_recvmsg_sync(struct socket *sock, struct msghdr *msg, > - int flags) > +static int skcipher_recvmsg(struct socket *sock, struct msghdr *msg, > + size_t ignor

Re: [RFC PATCH 1/2] crypto: caam - properly set IV after {en,de}crypt

2017-06-19 Thread Herbert Xu
On Mon, Jun 19, 2017 at 10:31:27AM +, Horia Geantă wrote: > > IIUC, IV update is required only in case of CBC. > Since this callback is used also for CTR, we should avoid the copy: > if ((ctx->cdata.algtype & OP_ALG_AAI_MASK) == OP_ALG_AAI_CBC) ... No it is needed for CTR too. Cheers, -- Ema

Re: Reply Urgent

2017-06-19 Thread INFO
Hello, How are you doing? I have been sent to inform you that, We have an inheritance of a deceased client with your surname. Contact Mr Andrew Bailey Reply Email To: myinf...@gmail.com with your "Full Names" for more info. Thanks for your understanding. Reply ASAP thank you. Melissa. -

Re: [PATCH] random: silence compiler warnings and fix race

2017-06-19 Thread Jason A. Donenfeld
Hello Ted, With rc6 already released and rc7 coming up, I'd really appreciate you stepping in here and either ACKing the above commit, or giving your two cents about it in case I need to roll something different. Thanks, Jason On Thu, Jun 15, 2017 at 12:45 AM, Jason A. Donenfeld wrote: > Odd ve

Re: [PATCH] random: silence compiler warnings and fix race

2017-06-19 Thread Jason A. Donenfeld
On Mon, Jun 19, 2017 at 9:45 AM, Sebastian Andrzej Siewior wrote: > ehm. You sure? I simply delayed the lock-dropping _after_ the state > variable was been modified. So it was basically what your patch did > except it was unlocked later… Yes, I'm sure. You moved the call to invalidate_batched_ent

Re: [PATCH] hwrng: do not warn when there are no devices

2017-06-19 Thread Mike Frysinger
On Mon, Jun 19, 2017 at 2:43 AM, PrasannaKumar Muralidharan wrote: > On 19 June 2017 at 11:51, Herbert Xu wrote: >> On Sun, Jun 18, 2017 at 10:00:17PM -0700, Mike Frysinger wrote: >>> >>> in order to make tpm-rng react in the way you're implying, the TPM >>> subsystem would need to add a notificati

[PATCH] crypto: ccp - Release locks before returning

2017-06-19 Thread Gary R Hook
krobot warning: make sure that all error return paths release locks. Signed-off-by: Gary R Hook --- drivers/crypto/ccp/ccp-debugfs.c |7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/crypto/ccp/ccp-debugfs.c b/drivers/crypto/ccp/ccp-debugfs.c index 6d86693b117

Re: [PATCH v2 0/6] crypto: aes - allow generic AES to be omitted

2017-06-19 Thread Ard Biesheuvel
On 19 June 2017 at 05:15, Eric Biggers wrote: > Hi Ard, > > On Fri, Jun 16, 2017 at 01:17:43PM +0200, Ard Biesheuvel wrote: >> The generic AES driver uses 16 lookup tables of 1 KB each, and has >> encryption and decryption routines that are fully unrolled. Given how >> the dependencies between thi

[PATCH] crypto: cavium/nitrox - dma_mapping_error() returns bool

2017-06-19 Thread Dan Carpenter
We want to return negative error codes here, but we're accidentally propogating the "true" return from dma_mapping_error(). Fixes: 14fa93cdcd9b ("crypto: cavium - Add support for CNN55XX adapters.") Signed-off-by: Dan Carpenter diff --git a/drivers/crypto/cavium/nitrox/nitrox_reqmgr.c b/drivers

Re: [RFC PATCH 1/2] crypto: caam - properly set IV after {en,de}crypt

2017-06-19 Thread Horia Geantă
On 6/2/2017 3:25 PM, David Gstir wrote: > Certain cipher modes like CTS expect the IV (req->info) of > ablkcipher_request (or equivalently req->iv of skcipher_request) to > contain the last ciphertext block when the {en,de}crypt operation is done. > This is currently not the case for the CAAM drive

Re: [PATCH] of: update ePAPR references to point to Devicetree Specification

2017-06-19 Thread Frank Rowand
On 06/18/17 07:05, Rob Herring wrote: > On Tue, Jun 13, 2017 at 07:49:04PM -0700, frowand.l...@gmail.com wrote: >> From: Frank Rowand >> >> The Devicetree Specification has superseded the ePAPR as the >> base specification for bindings. Update files in Documentation >> to reference the new docume

Re: [PATCH] hwrng: do not warn when there are no devices

2017-06-19 Thread PrasannaKumar Muralidharan
On 19 June 2017 at 11:51, Herbert Xu wrote: > On Sun, Jun 18, 2017 at 10:00:17PM -0700, Mike Frysinger wrote: >> >> in order to make tpm-rng react in the way you're implying, the TPM >> subsystem would need to add a notification chain for transitions from >> none<->some devices, then tpm-rng could

[cryptodev:master 77/100] drivers/crypto/ccp/ccp-debugfs.c:303:3-9: preceding lock on line 299 (fwd)

2017-06-19 Thread Julia Lawall
Please check whether a lock is needed before line 303. julia -- Forwarded message -- Date: Mon, 19 Jun 2017 17:34:11 +0800 From: kbuild test robot To: kbu...@01.org Cc: Julia Lawall Subject: [cryptodev:master 77/100] drivers/crypto/ccp/ccp-debugfs.c:303:3-9: preceding lock o

[PATCH 2/2] crypto: caam - fix gfp allocation flags (part II)

2017-06-19 Thread Horia Geantă
This is the 2nd part of fixing the usage of GFP_KERNEL for memory allocations, taking care off all the places that haven't caused a real problem / failure. Again, the issue being fixed is that GFP_KERNEL should be used only when MAY_SLEEP flag is set, i.e. MAY_BACKLOG flag usage is orthogonal. Sig

[PATCH 1/2] crypto: caam - fix gfp allocation flags (part I)

2017-06-19 Thread Horia Geantă
Changes in the SW cts (ciphertext stealing) code in commit 0605c41cc53ca ("crypto: cts - Convert to skcipher") revealed a problem in the CAAM driver: when cts(cbc(aes)) is executed and cts runs in SW, cbc(aes) is offloaded in CAAM; cts encrypts the last block in atomic context and CAAM incorrectly

Re: [PATCH v2 2/2] crypto: engine - Permit to enqueue skcipher request

2017-06-19 Thread Corentin Labbe
On Mon, Jun 19, 2017 at 01:27:08PM +0800, Herbert Xu wrote: > On Tue, Jun 06, 2017 at 03:44:17PM +0200, Corentin Labbe wrote: > > The crypto engine could actually only enqueue hash and ablkcipher request. > > This patch permit it to enqueue skcipher requets by adding all necessary > > functions. >

Re: [PATCH] random: silence compiler warnings and fix race

2017-06-19 Thread Sebastian Andrzej Siewior
On 2017-06-17 02:39:40 [+0200], Jason A. Donenfeld wrote: > On Fri, Jun 16, 2017 at 4:35 PM, Sebastian Andrzej Siewior > wrote: > > I wouldn't just push the lock one up as is but move that write part to > > crng_init to remain within the locked section. Like that: > > We can't quite do that, beca

[PATCH] crypto: fix typo in docs

2017-06-19 Thread Benjamin Peterson
Signed-off-by: Benjamin Peterson --- Documentation/crypto/userspace-if.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/crypto/userspace-if.rst b/Documentation/crypto/userspace-if.rst index de5a72e32bc9..ff86befa61e0 100644 --- a/Documentation/crypto/userspac