Re: [PATCH v2 1/2] dt-bindings: timeriomem_rng: Add entropy quality property

2017-05-31 Thread Herbert Xu
On Mon, May 22, 2017 at 02:12:23PM -0700, Rick Altherr wrote: > Signed-off-by: Rick Altherr Both patches applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH 0/5] crypto: arm - enable module autoloading

2017-05-31 Thread Herbert Xu
On Sun, May 21, 2017 at 10:23:35AM +, Ard Biesheuvel wrote: > Now that the prerequisite changes are in place, we can modify the > various accelerated crypto modules that use special instructions to > expose the CPU feature they depend on. This allows udev to autoload > the module at boot. All

[PATCH v1 2/2] dt-bindings: crypto: remove mediatek ethif clock

2017-05-31 Thread Ryder Lee
This patch removes the parent clock 'ethif' in bindings, since we don't need to control the parent of a clock in current clock framework. Moreover, the clocks are get by name in the driver, thus this change does not break backwards compatibility. Signed-off-by: Ryder Lee Reviewed-by: Matthias Br

[PATCH v1 1/2] crypto: mediatek - remove redundant clock setting

2017-05-31 Thread Ryder Lee
This patch removes redundant clock setting for 'clk_ethif', which is the parent of 'clk_cryp'. Hence, we just need to handle its child. Signed-off-by: Ryder Lee --- drivers/crypto/mediatek/mtk-platform.c | 10 +- drivers/crypto/mediatek/mtk-platform.h | 2 -- 2 files changed, 1 insertio

[PATCH v1 0/2] remove mediatek ethif clock in crypto driver

2017-05-31 Thread Ryder Lee
This patch series only remove redundant clock setting in mediatek crypto driver. Changes since v1: -rework the commit message. Ryder Lee (2): crypto: mediatek - remove redundant clock setting dt-bindings: crypto: remove mediatek ethif clock Documentation/devicetree/bindings/crypto/mediatek-

Re: [PATCH 2/2] crypto: mediatek - update DT binding documentation

2017-05-31 Thread Ryder Lee
On Wed, 2017-05-31 at 13:46 -0500, Rob Herring wrote: > On Fri, May 26, 2017 at 05:43:09PM +0800, Ryder Lee wrote: > > This patch removes unnecessary clock in binding file. > > Why is the clock unnecessary? A h/w block either has a clock or doesn't. > > The subject needs some work. Perhaps "dt-bi

Re: [PATCH 2/2] crypto: mediatek - update DT binding documentation

2017-05-31 Thread Rob Herring
On Fri, May 26, 2017 at 05:43:09PM +0800, Ryder Lee wrote: > This patch removes unnecessary clock in binding file. Why is the clock unnecessary? A h/w block either has a clock or doesn't. The subject needs some work. Perhaps "dt-bindings: crypto: remove mediatek ethif clock". Rob

[PATCH 1/4] dt-bindings: rng: add generic bindings for MediaTek SoCs

2017-05-31 Thread sean.wang
From: Sean Wang Add the generic binding for allowing the support of RNG on MediaTek SoCs such as MT7622. Signed-off-by: Sean Wang --- Documentation/devicetree/bindings/rng/mtk-rng.txt | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/rng/mt

[PATCH 2/4] hwrng: mtk - add support for MT7622 SoC

2017-05-31 Thread sean.wang
From: Sean Wang Add "mediatek,generic-rng" allowing most of RNG on MediaTek SoCs to be compatible with the driver including MT7622 SoC. Signed-off-by: Sean Wang --- drivers/char/hw_random/mtk-rng.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/char/hw_random/mtk-rng.c b/drivers/c

[PATCH 4/4] MAINTAINERS: add entry for MediaTek Random Number Generator

2017-05-31 Thread sean.wang
From: Sean Wang I work for MediaTek on maintaining the MediaTek RNG driver for the existing SoCs and adding support for the following SoCs. Signed-off-by: Sean Wang --- MAINTAINERS | 5 + 1 file changed, 5 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index cf86519..da473d0 100644

[PATCH 3/4] hwrng: mtk - add runtime PM support

2017-05-31 Thread sean.wang
From: Sean Wang Add runtime PM support. There will be the benefit on SoCs where the clock to the RNG used can be shutdown. Signed-off-by: Sean Wang --- drivers/char/hw_random/mtk-rng.c | 42 1 file changed, 42 insertions(+) diff --git a/drivers/char/h

Re: [sparc64] crc32c misbehave

2017-05-31 Thread David Miller
From: David Miller Date: Wed, 31 May 2017 11:53:35 -0400 (EDT) > Can you try something like disabling cpu IRQs around the crc32c() function > in lib/libcrc32c.c? Something like: > > u32 retval; > > local_irq_disable(); > > shash->tfm = tfm; > shash->flags = 0; >

Re: [sparc64] crc32c misbehave

2017-05-31 Thread David Miller
From: Anatoly Pugachev Date: Wed, 31 May 2017 14:56:52 +0300 > While debugging occasional crc32c checksum errors with xfs disk reads on > sparc64 (T5 [sun4v] 3.6 GHz CPU ldom, debian unstable/sid), Eric have found > that crc32c sometimes returns wrong checksum for data. Eric made a simple > test

[PATCH] Staging: ccree: cc_crypto_ctx.h: Fixed a comment coding style issue.

2017-05-31 Thread srishti sharma
Fixed a comment coding style issue that generated a warning stating that block comments should align the * on each line. Signed-off-by: srishti sharma --- drivers/staging/ccree/cc_crypto_ctx.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/ccree/cc_c

Re: [sparc64] crc32c misbehave

2017-05-31 Thread Anatoly Pugachev
A bit more on testing machines: kernel on T5 ldom ttip is git kernel: Linux ttip 4.12.0-rc3-00011-gf511c0b17b08 #327 SMP Wed May 31 12:54:02 MSK 2017 sparc64 GNU/Linux kernel on v215 is debian sid kernel: Linux v215 4.9.0-3-sparc64-smp #1 SMP Debian 4.9.25-1 (2017-05-02) sparc64 GNU/Linux mato

[PATCH] Staging: ccree: cc_crypto_ctx.h: Fixed a comment coding style issue.

2017-05-31 Thread srishti sharma
Fixed a comment coding style issue that generated a warning stating block comments use * on subsequent lines. Signed-off-by: srishti sharma --- drivers/staging/ccree/cc_crypto_ctx.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/ccree/cc_crypto_ctx.h

Re: [sparc64] crc32c misbehave

2017-05-31 Thread Anatoly Pugachev
Hello! While debugging occasional crc32c checksum errors with xfs disk reads on sparc64 (T5 [sun4v] 3.6 GHz CPU ldom, debian unstable/sid), Eric have found that crc32c sometimes returns wrong checksum for data. Eric made a simple test kernel module (included), which produce the following results o

Re: [PATCH v2 2/5] dt-bindings : Document the STM32F4 CRC32 binding

2017-05-31 Thread Cosar Dindar
On Tue, May 30, 2017 at 05:50:24PM -0500, Rob Herring wrote: > On Sat, May 20, 2017 at 04:32:12PM +0300, Cosar Dindar wrote: > > Add device tree binding for STM32F4. > > > > Signed-off-by: Cosar Dindar > > --- > > Documentation/devicetree/bindings/crypto/st,stm32-crc.txt | 4 ++-- > > 1 file cha