Re: [PATCH v3 2/3] crypto: inside-secure: add SafeXcel EIP197 crypto engine driver

2017-05-03 Thread Robin Murphy
On 24/04/17 09:57, Antoine Tenart wrote: > Hi Igal, > > On Mon, Apr 24, 2017 at 08:50:32AM +, Igal Liberman wrote: >> [...] >> >>> + priv->clk = of_clk_get(dev->of_node, 0); >>> + if (!IS_ERR(priv->clk)) { >>> + ret = clk_prepare_enable(priv->clk); >>> + if (ret) { >>>

Re: [PATCH v3 1/3] Documentation/bindings: Document the SafeXel cryptographic engine driver

2017-05-03 Thread Marc Zyngier
On 24/04/17 08:54, Antoine Tenart wrote: > The Inside Secure Safexcel cryptographic engine is found on some Marvell > SoCs (7k/8k). Document the bindings used by its driver. > > Signed-off-by: Antoine Tenart > --- > .../bindings/crypto/inside-secure-safexcel.txt | 27 > +

Re: [PATCH v3 2/3] crypto: inside-secure: add SafeXcel EIP197 crypto engine driver

2017-05-03 Thread Antoine Tenart
Hi Robin, On Wed, May 03, 2017 at 12:57:25PM +0100, Robin Murphy wrote: > On 24/04/17 08:54, Antoine Tenart wrote: > > + > > +#include > > everywhere, please. > > Other than that, the DMA aspects all look much nicer now, thanks. I'll update and resend a series when the next -rc1 is out. Than

Re: BUG: drbg: Added nodes from Stack Memory in link list

2017-05-03 Thread Stephan Müller
Am Mittwoch, 3. Mai 2017, 14:47:24 CEST schrieb Harsh Jain: Hi Harsh, > Hi Stephen, > > In drbg driver local variable of function are added as list nodes. one > instance is given below. > > > static inline int __init drbg_healthcheck_sanity(void) > > > > --- > --- > > max_addtllen = drbg_m

BUG: drbg: Added nodes from Stack Memory in link list

2017-05-03 Thread Harsh Jain
Hi Stephen, In drbg driver local variable of function are added as list nodes. one instance is given below. static inline int __init drbg_healthcheck_sanity(void) --- --- max_addtllen = drbg_max_addtl(drbg); max_request_bytes = drbg_max_request_bytes(drbg); drbg_string_fill(&addtl, buf, max_

Re: [PATCH v3 2/3] crypto: inside-secure: add SafeXcel EIP197 crypto engine driver

2017-05-03 Thread Robin Murphy
Hi Antoine, On 24/04/17 08:54, Antoine Tenart wrote: > Add support for Inside Secure SafeXcel EIP197 cryptographic engine, > which can be found on Marvell Armada 7k and 8k boards. This driver > currently implements: ecb(aes), cbc(aes), sha1, sha224, sha256 and > hmac(sah1) algorithms. > > Two fir

[PATCH] crypto: kpp, (ec)dh - fix typos

2017-05-03 Thread Tudor-Dan Ambarus
Signed-off-by: Tudor-Dan Ambarus --- crypto/dh.c | 4 ++-- crypto/dh_helper.c| 4 ++-- crypto/ecdh.c | 4 ++-- crypto/ecdh_helper.c | 4 ++-- include/crypto/dh.h | 4 ++-- include/crypto/ecdh.h | 4 ++-- include/crypto/kpp.h | 4 ++-- 7 files changed, 14 insertions(+), 1