KPP: DH/ECDH -- allocation returns ENOENT

2017-03-24 Thread Stephan Müller
Hi Salvatore, when I test 4.11-rc1 with the DH and ECDH options enabled, I get -ENOENT when trying to allocate the ciphers dh/dh_generic/ecdh. Note, the dh/ecdh kernel modules are loaded. Ciao Stephan

Re: [PATCH v2 1/3] crypto: hw_random - Add new Exynos RNG driver

2017-03-24 Thread Stephan Müller
Am Freitag, 24. März 2017, 19:26:04 CET schrieb Krzysztof Kozlowski: Hi Krzysztof, > +static unsigned int exynos_rng_copy_random(struct exynos_rng_dev *rng, > +u8 *dst, unsigned int dlen) > +{ > + unsigned int cnt = 0; > + int i, j; > + u32 val;

[PATCH v2 3/3] ARM: multi_v7_defconfig: Enable Exynos RNG and user-space crypto API

2017-03-24 Thread Krzysztof Kozlowski
Enable the new Exynos pseudo random number generator driver and user-space API to access crypto algorithms and devices (not only RNG). Signed-off-by: Krzysztof Kozlowski --- arch/arm/configs/multi_v7_defconfig | 6 ++ 1 file changed, 6 insertions(+) diff --git a/arch/arm/configs/multi_v7_de

[PATCH v2 1/3] crypto: hw_random - Add new Exynos RNG driver

2017-03-24 Thread Krzysztof Kozlowski
Replace existing hw_ranndom/exynos-rng driver with a new, reworked one. This is a driver for pseudo random number generator block which on Exynos4 chipsets must be seeded with some value. On newer Exynos5420 chipsets it might seed itself from true random number generator block but this is not impl

[PATCH v2 2/3] ARM: exynos_defconfig: Enable Exynos RNG and user-space crypto API

2017-03-24 Thread Krzysztof Kozlowski
Enable the new Exynos pseudo random number generator driver and user-space API to access crypto algorithms and devices (not only RNG). Signed-off-by: Krzysztof Kozlowski --- arch/arm/configs/exynos_defconfig | 6 ++ 1 file changed, 6 insertions(+) diff --git a/arch/arm/configs/exynos_defcon

[PATCH v2 0/3] crypto: hw_random - Add new Exynos RNG driver

2017-03-24 Thread Krzysztof Kozlowski
Hi, This is a follow up of my questions around exynos-rng [1]. Changes since v1: = 1. Re-work the code for seeding after system resume, following suggestions and review by Stephan Müller. The resume path was not tested. 2. Re-seed itself from time to time (every 100 ms), s

[cryptodev:master 42/60] drivers/crypto/ccp/ccp-dev-v5.c:436:28: note: in expansion of macro 'cpu_to_le32'

2017-03-24 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master head: 796b40c6171456274b02447e1dbbea97456403fe commit: 990672d48515ce09c76fcf1ceccee48b0dd1942b [42/60] crypto: ccp - Enable 3DES function on v5 CCPs config: arm64-allmodconfig (attached as .config) compile

Re: [RFC PATCH v2 15/32] x86: Add support for changing memory encryption attribute in early boot

2017-03-24 Thread Borislav Petkov
On Thu, Mar 02, 2017 at 10:15:28AM -0500, Brijesh Singh wrote: > Some KVM-specific custom MSRs shares the guest physical address with > hypervisor. When SEV is active, the shared physical address must be mapped > with encryption attribute cleared so that both hypervsior and guest can > access the d

Re: [PATCH 1/3] crypto: hw_random - Add new Exynos RNG driver

2017-03-24 Thread Krzysztof Kozlowski
On Fri, Mar 24, 2017 at 05:45:41PM +0100, Bartlomiej Zolnierkiewicz wrote: > > > > And I think the probe might be called twice, for example in case of > > > > mistake in DTB. > > > > > > Even if this is possible resource allocation code in the driver will > > > take take care of handling it just f

Re: [PATCH 1/3] crypto: hw_random - Add new Exynos RNG driver

2017-03-24 Thread Bartlomiej Zolnierkiewicz
On Friday, March 24, 2017 07:19:34 PM Krzysztof Kozlowski wrote: > On Fri, Mar 24, 2017 at 05:11:25PM +0100, Bartlomiej Zolnierkiewicz wrote: > > On Friday, March 24, 2017 06:46:00 PM Krzysztof Kozlowski wrote: > > > I really do not like global or file-scope variables. I do not like > > > drivers u

Re: [PATCH 1/3] crypto: hw_random - Add new Exynos RNG driver

2017-03-24 Thread Krzysztof Kozlowski
On Fri, Mar 24, 2017 at 05:11:25PM +0100, Bartlomiej Zolnierkiewicz wrote: > On Friday, March 24, 2017 06:46:00 PM Krzysztof Kozlowski wrote: > > I really do not like global or file-scope variables. I do not like > > drivers using them. Actually I hate them. > > > > From time to time I encounter a

Re: [PATCH 1/3] crypto: hw_random - Add new Exynos RNG driver

2017-03-24 Thread Bartlomiej Zolnierkiewicz
On Friday, March 24, 2017 06:46:00 PM Krzysztof Kozlowski wrote: > On Fri, Mar 24, 2017 at 04:26:47PM +0100, Bartlomiej Zolnierkiewicz wrote: > > > > Hi, > > > > Firstly, thanks for working on this. > > > > The patch looks fine overall for me, some review comments below. > > > > On Friday, Marc

Re: [PATCH 1/3] crypto: hw_random - Add new Exynos RNG driver

2017-03-24 Thread Krzysztof Kozlowski
On Fri, Mar 24, 2017 at 04:26:47PM +0100, Bartlomiej Zolnierkiewicz wrote: > > Hi, > > Firstly, thanks for working on this. > > The patch looks fine overall for me, some review comments below. > > On Friday, March 24, 2017 05:24:44 PM Krzysztof Kozlowski wrote: > > Replace existing hw_ranndom/e

Re: [PATCH 1/3] crypto: hw_random - Add new Exynos RNG driver

2017-03-24 Thread Bartlomiej Zolnierkiewicz
Hi, Firstly, thanks for working on this. The patch looks fine overall for me, some review comments below. On Friday, March 24, 2017 05:24:44 PM Krzysztof Kozlowski wrote: > Replace existing hw_ranndom/exynos-rng driver with a new, reworked one. > This is a driver for pseudo random number genera

Re: [PATCH 1/3] crypto: hw_random - Add new Exynos RNG driver

2017-03-24 Thread Krzysztof Kozlowski
On Fri, Mar 24, 2017 at 03:55:22PM +0100, Stephan Müller wrote: > Am Freitag, 24. März 2017, 15:51:56 CET schrieb Krzysztof Kozlowski: > > Hi Krzysztof, > > > > I'll use the generated random numbers. > > If you do that, may I propse that you update this seed field periodically? > E.g. with ever

Re: [PATCH 1/3] crypto: hw_random - Add new Exynos RNG driver

2017-03-24 Thread Stephan Müller
Am Freitag, 24. März 2017, 15:51:56 CET schrieb Krzysztof Kozlowski: Hi Krzysztof, > > I'll use the generated random numbers. If you do that, may I propse that you update this seed field periodically? E.g. with every (or every other) user request for random data, you may update that field with

Re: [PATCH 1/3] crypto: hw_random - Add new Exynos RNG driver

2017-03-24 Thread Krzysztof Kozlowski
On Fri, Mar 24, 2017 at 03:46:44PM +0100, Stephan Müller wrote: > Am Freitag, 24. März 2017, 15:43:48 CET schrieb Krzysztof Kozlowski: > > Hi Krzysztof, > > > On Fri, Mar 24, 2017 at 03:37:59PM +0100, Stephan Müller wrote: > > > Am Freitag, 24. März 2017, 15:24:44 CET schrieb Krzysztof Kozlowski:

Re: [PATCH 1/3] crypto: hw_random - Add new Exynos RNG driver

2017-03-24 Thread Stephan Müller
Am Freitag, 24. März 2017, 15:43:48 CET schrieb Krzysztof Kozlowski: Hi Krzysztof, > On Fri, Mar 24, 2017 at 03:37:59PM +0100, Stephan Müller wrote: > > Am Freitag, 24. März 2017, 15:24:44 CET schrieb Krzysztof Kozlowski: > > > > Hi Krzysztof, > > > > > + > > > +static int exynos_rng_set_seed(s

Re: [PATCH 1/3] crypto: hw_random - Add new Exynos RNG driver

2017-03-24 Thread Krzysztof Kozlowski
On Fri, Mar 24, 2017 at 03:37:59PM +0100, Stephan Müller wrote: > Am Freitag, 24. März 2017, 15:24:44 CET schrieb Krzysztof Kozlowski: > > Hi Krzysztof, > > > + > > +static int exynos_rng_set_seed(struct exynos_rng_dev *rng, > > + const u8 *seed, unsigned int slen) > > +{

Re: [PATCH 1/3] crypto: hw_random - Add new Exynos RNG driver

2017-03-24 Thread Stephan Müller
Am Freitag, 24. März 2017, 15:24:44 CET schrieb Krzysztof Kozlowski: Hi Krzysztof, > + > +static int exynos_rng_set_seed(struct exynos_rng_dev *rng, > +const u8 *seed, unsigned int slen) > +{ > + int ret, i; > + u32 val; > + > + dev_dbg(rng->dev, "Seeding w

Re: next build: 208 builds: 9 failed, 199 passed, 857 errors, 444 warnings (next-20170323)

2017-03-24 Thread Ralf Baechle
On Thu, Mar 23, 2017 at 07:44:50PM +0100, Ralf Baechle wrote: > > On Thu, Mar 23, 2017 at 6:46 AM, kernelci.org bot wrote: > > > > > acs5k_defconfig (arm) — PASS, 0 errors, 2 warnings, 0 section mismatches > > > > > > Warnings: > > > :1328:2: warning: #warning syscall arch_prctl not implemented

[PATCH 3/3] ARM: multi_v7_defconfig: Enable Exynos RNG and user-space crypto API

2017-03-24 Thread Krzysztof Kozlowski
Enable the new Exynos pseudo random number generator driver and user-space API to access crypto algorithms and devices (not only RNG). Signed-off-by: Krzysztof Kozlowski --- arch/arm/configs/multi_v7_defconfig | 6 ++ 1 file changed, 6 insertions(+) diff --git a/arch/arm/configs/multi_v7_de

[PATCH 2/3] ARM: exynos_defconfig: Enable Exynos RNG and user-space crypto API

2017-03-24 Thread Krzysztof Kozlowski
Enable the new Exynos pseudo random number generator driver and user-space API to access crypto algorithms and devices (not only RNG). Signed-off-by: Krzysztof Kozlowski --- arch/arm/configs/exynos_defconfig | 6 ++ 1 file changed, 6 insertions(+) diff --git a/arch/arm/configs/exynos_defcon

[PATCH 1/3] crypto: hw_random - Add new Exynos RNG driver

2017-03-24 Thread Krzysztof Kozlowski
Replace existing hw_ranndom/exynos-rng driver with a new, reworked one. This is a driver for pseudo random number generator block which on Exynos4 chipsets must be seeded with some value. On newer Exynos5420 chipsets it might seed itself from true random number generator block but this is not impl

[PATCH 0/3] crypto: hw_random - Add new Exynos RNG driver

2017-03-24 Thread Krzysztof Kozlowski
Hi, This is a follow up of my questions around exynos-rng [1]. The existing exynos-rng has many issues. The most important one is that it is a pseudo RNG device but uses hw_random interface which does not allow proper seeding. The RNG module on Exynos4 requires seeding. On newer SoCs (like Exy

Re: [PATCH] crypto: zip - add a cast for printing atomic64_t values

2017-03-24 Thread Herbert Xu
On Mon, Mar 20, 2017 at 01:39:16PM +0100, Arnd Bergmann wrote: > kernelci.org reports a build-time regression on linux-next, with a harmless > warning in x86 allmodconfig: > > drivers/crypto/cavium/zip/zip_main.c:489:18: warning: format '%ld' expects > argument of type 'long int', but argument 7

Re: [PATCH 6/7] md/raid10, LLVM: get rid of variable length array

2017-03-24 Thread Dmitry Vyukov
On Fri, Mar 24, 2017 at 3:10 PM, Peter Zijlstra wrote: > On Fri, Mar 24, 2017 at 02:50:24PM +0100, Dmitry Vyukov wrote: >> OK, I guess should not have referenced the llvm-linux page. >> So here are reasons on our side that I am ready to vouch: >> >> - clang make it possible to implement KMSAN (dy

Re: [PATCH 1/4] crypto: powerpc - Factor out the core CRC vpmsum algorithm

2017-03-24 Thread Herbert Xu
Daniel Axtens wrote: > The core nuts and bolts of the crc32c vpmsum algorithm will > also work for a number of other CRC algorithms with different > polynomials. Factor out the function into a new asm file. > > To handle multiple users of the function, a user simply > provides constants, defines

Re: [PATCH V3 0/3] Support new function in new CCPs

2017-03-24 Thread Herbert Xu
On Wed, Mar 15, 2017 at 01:20:34PM -0500, Gary R Hook wrote: > The following series implements new function in a version 5 coprocessor. > New features are: > - Support for SHA-2 384-bit and 512-bit hashing > - Support for 3DES encryption > - Support for AES GCM encryption > > Changes from V2: >

Re: [PATCH 0/7] crypto: caam - add Queue Interface (QI) support

2017-03-24 Thread Herbert Xu
On Fri, Mar 17, 2017 at 12:05:55PM +0200, Horia Geantă wrote: > RFC -> v1: > -rebased on latest cryptodev-2.6 tree > open-code tsk_cpus_allowed() - sync with commit > 0c98d344fe5c "sched/core: Remove the tsk_cpus_allowed() wrapper" > -addressed Scott's feedback - removed most of the accessors > add

Re: [PATCH v2] dt-bindings: rng: clocks property on omap_rng not always mandatory

2017-03-24 Thread Rob Herring
On Fri, Mar 24, 2017 at 09:19:05AM -0500, Rob Herring wrote: > On Fri, Mar 24, 2017 at 08:52:00AM -0500, Rob Herring wrote: > > On Fri, Mar 17, 2017 at 01:58:39PM +0100, Thomas Petazzoni wrote: > > > Commit 52060836f79 ("dt-bindings: omap-rng: Document SafeXcel IP-76 > > > device variant") update t

Re: [PATCH v2] dt-bindings: rng: clocks property on omap_rng not always mandatory

2017-03-24 Thread Rob Herring
On Fri, Mar 24, 2017 at 08:52:00AM -0500, Rob Herring wrote: > On Fri, Mar 17, 2017 at 01:58:39PM +0100, Thomas Petazzoni wrote: > > Commit 52060836f79 ("dt-bindings: omap-rng: Document SafeXcel IP-76 > > device variant") update the omap_rng Device Tree binding to add support > > for the IP-76 vari

Re: [PATCH] crypto: ccp - Make some CCP DMA channels private

2017-03-24 Thread Herbert Xu
On Thu, Mar 23, 2017 at 12:53:30PM -0500, Gary R Hook wrote: > The CCP registers its queues as channels capable of handling > general DMA operations. The NTB driver will use DMA if > directed, but as public channels can be reserved for use in > asynchronous operations some channels should be held b

Re: [PATCH] crypto: ixp4xx - Use sg_virt()

2017-03-24 Thread Herbert Xu
On Thu, Mar 23, 2017 at 09:16:30PM +0800, Geliang Tang wrote: > Use sg_virt() instead of open-coding it. > > Signed-off-by: Geliang Tang Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: zip - Memory corruption in zip_clear_stats()

2017-03-24 Thread Herbert Xu
On Fri, Mar 17, 2017 at 11:46:21PM +0300, Dan Carpenter wrote: > There is a typo here. It should be "stats" instead of "state". The > impact is that we clear 224 bytes instead of 80 and we zero out memory > that we shouldn't. > > Fixes: 09ae5d37e093 ("crypto: zip - Add Compression/Decompression

Re: [PATCH] padata: avoid race in reordering

2017-03-24 Thread Herbert Xu
Jason A. Donenfeld wrote: > Under extremely heavy uses of padata, crashes occur, and with list > debugging turned on, this happens instead: > > [87487.298728] WARNING: CPU: 1 PID: 882 at lib/list_debug.c:33 > __list_add+0xae/0x130 > [87487.301868] list_add corruption. prev->next should be next >

Re: [PATCH] crypto: DRBG - initialize SGL only once

2017-03-24 Thread Herbert Xu
On Wed, Mar 22, 2017 at 03:26:36PM +0100, Stephan Müller wrote: > An SGL to be initialized only once even when its buffers are written > to several times. > > Signed-off-by: Stephan Mueller Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: ht

Re: [PATCH] crypto: testmgr - mark ctr(des3_ede) as fips_allowed

2017-03-24 Thread Herbert Xu
On Mon, Mar 20, 2017 at 05:28:05PM -0300, Marcelo Henrique Cerri wrote: > 3DES is missing the fips_allowed flag for CTR mode. > > Signed-off-by: Marcelo Henrique Cerri Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.

Re: [PATCH] crypto: xts,lrw - fix out-of-bounds write after kmalloc failure

2017-03-24 Thread Herbert Xu
On Thu, Mar 23, 2017 at 01:39:46PM -0700, Eric Biggers wrote: > From: Eric Biggers > > In the generic XTS and LRW algorithms, for input data > 128 bytes, a > temporary buffer is allocated to hold the values to be XOR'ed with the > data before and after encryption or decryption. If the allocation

Re: [PATCH v2] dt-bindings: rng: clocks property on omap_rng not always mandatory

2017-03-24 Thread Herbert Xu
On Fri, Mar 17, 2017 at 01:58:39PM +0100, Thomas Petazzoni wrote: > Commit 52060836f79 ("dt-bindings: omap-rng: Document SafeXcel IP-76 > device variant") update the omap_rng Device Tree binding to add support > for the IP-76 variation of the IP. As part of this change, a "clocks" > property was ad

Re: [PATCH 0/4] crypto: s5p-sss - Fix and minor improvements

2017-03-24 Thread Herbert Xu
On Fri, Mar 17, 2017 at 04:49:18PM +0200, Krzysztof Kozlowski wrote: > Hi, > > I still did not fix the NULL pointer dereference reported by > Nathan Royce [1], but I got some other improvements. > > Testing done on Odroid U3 (Exynos4412) with tcrypt and cryptsetup. > > Best regards, > Krzysztof

Re: [PATCH] crypto, x86: aesni - fix token pasting for clang

2017-03-24 Thread Herbert Xu
On Wed, Mar 15, 2017 at 03:36:00PM -0700, Michael Davidson wrote: > aes_ctrby8_avx-x86_64.S uses the C preprocessor for token pasting > of character sequences that are not valid preprocessor tokens. > While this is allowed when preprocessing assembler files it exposes > an incompatibilty between th

Re: [PATCH] md5: remove from lib and only live in crypto

2017-03-24 Thread Herbert Xu
On Thu, Mar 16, 2017 at 03:18:57PM +0100, Jason A. Donenfeld wrote: > The md5_transform function is no longer used any where in the tree, > except for the crypto api's actual implementation of md5, so we can drop > the function from lib and put it as a static function of the crypto > file, where it

Re: [PATCH 6/7] md/raid10, LLVM: get rid of variable length array

2017-03-24 Thread Peter Zijlstra
On Fri, Mar 24, 2017 at 02:50:24PM +0100, Dmitry Vyukov wrote: > OK, I guess should not have referenced the llvm-linux page. > So here are reasons on our side that I am ready to vouch: > > - clang make it possible to implement KMSAN (dynamic detection of > uses of uninit memory) How does GCC mak

Re: [PATCH 6/7] md/raid10, LLVM: get rid of variable length array

2017-03-24 Thread Peter Zijlstra
On Fri, Mar 24, 2017 at 02:47:15PM +0100, Dmitry Vyukov wrote: > > Seriously, you should have taken the hack the first time that this > > needs to be fixed. Just because this is a fairly uncommon construct > > in the kernel doesn't mean it is not in userspace. > > There is a reason why it is fair

Re: [PATCH] arm64: dts: ls1012a: add crypto node

2017-03-24 Thread Shawn Guo
On Fri, Mar 24, 2017 at 08:29:17AM +, Horia Geantă wrote: > On 3/24/2017 9:35 AM, Shawn Guo wrote: > > On Fri, Mar 24, 2017 at 07:17:50AM +, Horia Geantă wrote: > +sec_mon: sec_mon@1e9 { > >>> > >>> Hyphen is more preferred to be used in node name than underscore. >

Re: [PATCH v2] dt-bindings: rng: clocks property on omap_rng not always mandatory

2017-03-24 Thread Rob Herring
On Fri, Mar 17, 2017 at 01:58:39PM +0100, Thomas Petazzoni wrote: > Commit 52060836f79 ("dt-bindings: omap-rng: Document SafeXcel IP-76 > device variant") update the omap_rng Device Tree binding to add support > for the IP-76 variation of the IP. As part of this change, a "clocks" > property was ad

Re: [PATCH 6/7] md/raid10, LLVM: get rid of variable length array

2017-03-24 Thread Dmitry Vyukov
On Fri, Mar 17, 2017 at 8:29 PM, Peter Zijlstra wrote: > On Fri, Mar 17, 2017 at 08:26:42PM +0100, Peter Zijlstra wrote: >> On Fri, Mar 17, 2017 at 08:05:16PM +0100, Dmitry Vyukov wrote: >> > You can also find some reasons in the Why section of LLVM-Linux project: >> > http://llvm.linuxfoundation.

Re: [PATCH 6/7] md/raid10, LLVM: get rid of variable length array

2017-03-24 Thread Dmitry Vyukov
On Fri, Mar 17, 2017 at 9:04 PM, wrote: > On March 17, 2017 12:27:46 PM PDT, Peter Zijlstra > wrote: >>On Fri, Mar 17, 2017 at 11:52:01AM -0700, Michael Davidson wrote: >>> On Fri, Mar 17, 2017 at 5:44 AM, Peter Zijlstra >> wrote: >>> > >>> > Be that as it may; what you construct above is disgu

Crypto Fixes for 4.11

2017-03-24 Thread Herbert Xu
Hi Linus: This push fixes regressions in the crypto ccp driver and the hwrng drivers amd and geode. Please pull from git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6.git linus Gary R Hook (1): crypto: ccp - Assign DMA commands to the channel's CCP Prarit Bhargava (2):

Re: [PATCH v2 2/5] crypto: stm32 - Support for STM32 CRC32 crypto module

2017-03-24 Thread PrasannaKumar Muralidharan
On 24 March 2017 at 15:26, Fabien DESSENNE wrote: > On 24/03/17 05:28, PrasannaKumar Muralidharan wrote: >> On 21 March 2017 at 20:43, Fabien Dessenne wrote: >>> This module registers a CRC32 ("Ethernet") and a CRC32C (Castagnoli) >>> algorithm that make use of the STMicroelectronics STM32 crypto

Re: [PATCH v2 2/5] crypto: stm32 - Support for STM32 CRC32 crypto module

2017-03-24 Thread Fabien DESSENNE
On 24/03/17 05:28, PrasannaKumar Muralidharan wrote: > On 21 March 2017 at 20:43, Fabien Dessenne wrote: >> This module registers a CRC32 ("Ethernet") and a CRC32C (Castagnoli) >> algorithm that make use of the STMicroelectronics STM32 crypto hardware. >> >> Theses algorithms are compatible with t

Re: [PATCH] padata: avoid race in reordering

2017-03-24 Thread Steffen Klassert
On Thu, Mar 23, 2017 at 12:24:43PM +0100, Jason A. Donenfeld wrote: > Under extremely heavy uses of padata, crashes occur, and with list > debugging turned on, this happens instead: > > [87487.298728] WARNING: CPU: 1 PID: 882 at lib/list_debug.c:33 > __list_add+0xae/0x130 > [87487.301868] list_add

Re: [PATCH] arm64: dts: ls1012a: add crypto node

2017-03-24 Thread Horia Geantă
On 3/24/2017 9:35 AM, Shawn Guo wrote: > On Fri, Mar 24, 2017 at 07:17:50AM +, Horia Geantă wrote: + sec_mon: sec_mon@1e9 { >>> >>> Hyphen is more preferred to be used in node name than underscore. >>> >> This would imply changing the >> Documentation/devicetree/bindings/crypt

Re: [PATCH] arm64: dts: ls1012a: add crypto node

2017-03-24 Thread Shawn Guo
On Fri, Mar 24, 2017 at 07:17:50AM +, Horia Geantă wrote: > >> + sec_mon: sec_mon@1e9 { > > > > Hyphen is more preferred to be used in node name than underscore. > > > This would imply changing the > Documentation/devicetree/bindings/crypto/fsl-sec4.txt binding and > dealing with

Re: [PATCH] arm64: dts: ls1012a: add crypto node

2017-03-24 Thread Horia Geantă
On 3/24/2017 3:56 AM, Shawn Guo wrote: > On Wed, Mar 22, 2017 at 02:29:39PM +0200, Horia Geantă wrote: >> LS1012A has a SEC v5.4 security engine. >> >> Signed-off-by: Horia Geantă >> --- >> arch/arm64/boot/dts/freescale/fsl-ls1012a-frdm.dts | 9 +++ >> arch/arm64/boot/dts/freescale/fsl-ls1012a-q