Re: crypto: hang in crypto_larval_lookup

2017-02-25 Thread Herbert Xu
On Sat, Feb 25, 2017 at 04:20:22PM -0300, Marcelo Cerri wrote: > > Yeah, I agree. This should work as long as the module aliases are > correct, which is enough. > > Other templates will not trigger the same error since they don't have to > try more than one underlying algorithm. But I think this

[v2 PATCH] crypto: xts - Propagate NEED_FALLBACK bit

2017-02-25 Thread Herbert Xu
When we're used as a fallback algorithm, we should propagate the NEED_FALLBACK bit when searching for the underlying ECB mode. This just happens to fix a hang too because otherwise the search may end up loading the same module that triggered this XTS creation. Fixes: f1c131b45410 ("crypto: xts -

Re: crypto: hang in crypto_larval_lookup

2017-02-25 Thread Marcelo Cerri
On Sat, Feb 25, 2017 at 11:17:07PM +0800, Herbert Xu wrote: > On Fri, Feb 24, 2017 at 08:44:00PM -0300, Marcelo Cerri wrote: > > > > This is probably caused by the way that the xts template is handling the > > underline algorithm selection. > > Good catch. I think the bigger issue here is that wh

Re: crypto: hang in crypto_larval_lookup

2017-02-25 Thread Herbert Xu
On Fri, Feb 24, 2017 at 08:44:00PM -0300, Marcelo Cerri wrote: > > This is probably caused by the way that the xts template is handling the > underline algorithm selection. Good catch. I think the bigger issue here is that when requesting for an XTS that doesn't need a fallback we shouldn't be us

Re: [PATCH 1/2] crypto: vmx - Use skcipher for cbc fallback

2017-02-25 Thread Herbert Xu
On Thu, Feb 23, 2017 at 10:42:04AM -0300, Marcelo Cerri wrote: > It makes sense. Thanks for the clarification, Herbert. > > One more question: are you planning to convert the ctr template to > skcipher? Yes everything will be converted. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apa