[PATCH] crypto: Add ECB dependency for XTS mode

2017-02-22 Thread Milan Broz
Since the commit f1c131b45410a202eb45cc55980a7a9e4e4b4f40 crypto: xts - Convert to skcipher the XTS mode is based on ECB, so the mode must select ECB otherwise it can fail to initialize. Signed-off-by: Milan Broz --- crypto/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/crypto

[PATCH] crypto: brcm: fix spelling mistake: "genereate" -> "generate"

2017-02-22 Thread Colin King
From: Colin Ian King trivial fix to spelling mistake in pr_err message Signed-off-by: Colin Ian King --- drivers/crypto/bcm/util.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/bcm/util.c b/drivers/crypto/bcm/util.c index 0502f46..430c557 100644 --- a/drive

Re: [PATCH 1/1] ARM: dts: NSP: Add crypto (SPU) to dtsi

2017-02-22 Thread Jon Mason
On Wed, Feb 22, 2017 at 4:22 PM, Steve Lin wrote: > Adds crypto hardware (SPU) to Northstar Plus device tree file. > > Signed-off-by: Steve Lin Looks good to me! Acked-by: Jon Mason > > --- > Code changes for this addition were submitted previously by Rob > Rice: > https://git.kernel.org/cgi

Re: crypto: xts: regression in 4.10

2017-02-22 Thread Nicolas Porcel
On Wed, Feb 22, 2017 at 12:31:30PM +0100, Milan Broz wrote: > Kernel 4.10 works with LUKS and XTS in general (otherwise I would scream much > earlier:-) I was surprised that it was still broken in the mainline release. All the other regressions I had have been fixed. Also, I guess LUKS with aes-x

Re: [PATCH 1/2] crypto: vmx - Use skcipher for cbc fallback

2017-02-22 Thread Marcelo Cerri
Hi Hebert, On Wed, Feb 22, 2017 at 04:18:19PM -0300, Marcelo Cerri wrote: > Hi Paulo. > > On Wed, Feb 22, 2017 at 03:00:15PM -0300, Paulo Flabiano Smorigo wrote: > > > > if (in_interrupt()) { > > - ret = crypto_blkcipher_encrypt(&fallback_desc, dst, src, > > -

[PATCH 0/2] crypto: vmx - fix vmx failures by changing fallback to skcipher

2017-02-22 Thread Paulo Flabiano Smorigo
Currently, neither cbc or xts are working with upstream kernel due to a failure in the fallback allocation. This can be fixed by changing the fallback to skcipher. Paulo Flabiano Smorigo (2): crypto: vmx - Use skcipher for cbc fallback crypto: vmx - Use skcipher for xts fallback drivers/cryp

[PATCH 1/1] ARM: dts: NSP: Add crypto (SPU) to dtsi

2017-02-22 Thread Steve Lin
Adds crypto hardware (SPU) to Northstar Plus device tree file. Signed-off-by: Steve Lin --- Code changes for this addition were submitted previously by Rob Rice: https://git.kernel.org/cgit/linux/kernel/git/herbert/cryptodev-2.6.git/commit/?id=9d12ba86f818aa9cfe9f01b750336aa441f2ffa2 --- arch/

Re: [PATCH 2/2] crypto: vmx - Use skcipher for xts fallback

2017-02-22 Thread Marcelo Cerri
In addition to cbc comments: On Wed, Feb 22, 2017 at 03:00:45PM -0300, Paulo Flabiano Smorigo wrote: > Signed-off-by: Paulo Flabiano Smorigo > --- > drivers/crypto/vmx/aes_xts.c | 32 ++-- > 1 file changed, 18 insertions(+), 14 deletions(-) > > diff --git a/drivers/c

Re: [PATCH 1/2] crypto: vmx - Use skcipher for cbc fallback

2017-02-22 Thread Marcelo Cerri
Hi Paulo. On Wed, Feb 22, 2017 at 03:00:15PM -0300, Paulo Flabiano Smorigo wrote: > Signed-off-by: Paulo Flabiano Smorigo > --- > drivers/crypto/vmx/aes_cbc.c | 41 - > 1 file changed, 20 insertions(+), 21 deletions(-) > > diff --git a/drivers/crypto/vmx/

[PATCH 2/2] crypto: vmx - Use skcipher for xts fallback

2017-02-22 Thread Paulo Flabiano Smorigo
Signed-off-by: Paulo Flabiano Smorigo --- drivers/crypto/vmx/aes_xts.c | 32 ++-- 1 file changed, 18 insertions(+), 14 deletions(-) diff --git a/drivers/crypto/vmx/aes_xts.c b/drivers/crypto/vmx/aes_xts.c index 24353ec3..a8245e1 100644 --- a/drivers/crypto/vmx/aes_xts

[PATCH 1/2] crypto: vmx - Use skcipher for cbc fallback

2017-02-22 Thread Paulo Flabiano Smorigo
Signed-off-by: Paulo Flabiano Smorigo --- drivers/crypto/vmx/aes_cbc.c | 41 - 1 file changed, 20 insertions(+), 21 deletions(-) diff --git a/drivers/crypto/vmx/aes_cbc.c b/drivers/crypto/vmx/aes_cbc.c index 94ad5c0..5aa70997 100644 --- a/drivers/crypto/vm

Re: crypto: xts: regression in 4.10

2017-02-22 Thread Marcelo Cerri
What XTS implementations do you have available on /proc/crypto after the error? Some drivers that allocate fallback implementations using the older API started to fail after the generic templates were converted to skcipher. On Wed, Feb 22, 2017 at 12:17:17AM +0100, Nicolas Porcel wrote: > Hello,

Re: crypto/cavium MSI-X fixups

2017-02-22 Thread David Daney
On 02/21/2017 11:27 PM, Christoph Hellwig wrote: On Tue, Feb 21, 2017 at 09:36:04AM -0800, David Daney wrote: With respect to pci_enable_msix(), what do you recommend as a replacement? pci_alloc_irq_vectors. In fact I have a tree ready for after -rc1 that removes pci_enable_msix() entirely.

Re: crypto: xts: regression in 4.10

2017-02-22 Thread Milan Broz
On 02/22/2017 12:17 AM, Nicolas Porcel wrote: > Hello, > > I am using aes-xts-plain64 with LUKS headers to crypt the root. In 4.10, > the partition cannot be opened and I have the following errors when > booting: > > device-mapper: table: 253:0: crypt: Error allocating crypto tfm > device