Re: [PATCH] crypto: rsa: rename two rsa key files

2016-11-08 Thread yjin
Thanks for Herbert's reminder. I have drop this patch in a previous mail. Regards! Yanjiang On 2016年11月08日 20:09, Herbert Xu wrote: yanjiang@windriver.com wrote: From: Yanjiang Jin This is to eliminate the below compile error: crypto/rsa_helper.c:19:29: fatal error: rsaprivkey-asn1.h: N

[PATCH RESEND] crypto: gf128mul - remove dead gf128mul_64k_lle code

2016-11-08 Thread Alex Cope
This code is unlikely to be useful in the future because transforms don't know how often keys will be changed, new algorithms are unlikely to use lle representation, and tables should be replaced with carryless multiplication instructions when available. Signed-off-by: Alex Cope --- crypto/gf128

[PATCH] crypto: dh - Consistenly return negative error codes

2016-11-08 Thread Mat Martineau
Fix the single instance where a positive EINVAL was returned. Signed-off-by: Mat Martineau --- crypto/dh.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/crypto/dh.c b/crypto/dh.c index 9d19360..ddcb528 100644 --- a/crypto/dh.c +++ b/crypto/dh.c @@ -118,7 +118,7 @@ static in

Re: [PATCH v4] poly1305: generic C can be faster on chips with slow unaligned access

2016-11-08 Thread Eric Biggers
On Tue, Nov 08, 2016 at 08:52:39AM +0100, Martin Willi wrote: > > > Not sure what the exact alignment rules for key/iv are, but maybe we > want to replace the same function in chacha20_generic.c as well? > > Martin chacha20-generic provides a blkcipher API and sets an alignmask of sizeof(u32) -

Re: [PATCH 6/6] Add support for AEAD algos.

2016-11-08 Thread Harsh Jain
On 08-11-2016 18:29, Stephan Mueller wrote: > Am Dienstag, 8. November 2016, 17:16:38 CET schrieb Harsh Jain: > > Hi Harsh, > >> On 08-11-2016 16:45, Stephan Mueller wrote: >>> Am Donnerstag, 27. Oktober 2016, 15:36:08 CET schrieb Harsh Jain: >>> >>> Hi Harsh, >>> >> +static void chcr_verify_

Re: [PATCH 6/6] Add support for AEAD algos.

2016-11-08 Thread Stephan Mueller
Am Dienstag, 8. November 2016, 17:16:38 CET schrieb Harsh Jain: Hi Harsh, > On 08-11-2016 16:45, Stephan Mueller wrote: > > Am Donnerstag, 27. Oktober 2016, 15:36:08 CET schrieb Harsh Jain: > > > > Hi Harsh, > > > +static void chcr_verify_tag(struct aead_request *req, u8 *input, int >

Re: [PATCH] crypto: rsa: rename two rsa key files

2016-11-08 Thread Herbert Xu
yanjiang@windriver.com wrote: > From: Yanjiang Jin > > This is to eliminate the below compile error: > > crypto/rsa_helper.c:19:29: fatal error: rsaprivkey-asn1.h: No such file or > directory > #include "rsaprivkey-asn1.h" > ^ > compilation terminated. > > Signe

Re: [PATCH] crypto: gf128mul - remove dead gf128mul_64k_lle code

2016-11-08 Thread Herbert Xu
Alex Cope wrote: > This code is unlikely to be useful in the future because transforms > don't know how often keys will be changed, new algorithms are unlikely > to use lle representation, and tables should be replaced with > carryless multiplication instructions when available. > > Signed-off-by

Re: [PATCH 6/6] Add support for AEAD algos.

2016-11-08 Thread Harsh Jain
On 08-11-2016 16:45, Stephan Mueller wrote: > Am Donnerstag, 27. Oktober 2016, 15:36:08 CET schrieb Harsh Jain: > > Hi Harsh, > +static void chcr_verify_tag(struct aead_request *req, u8 *input, int *err) +{ + u8 temp[SHA512_DIGEST_SIZE]; + struct crypto_aead *tfm = cryp

Re: [PATCH 6/6] Add support for AEAD algos.

2016-11-08 Thread Stephan Mueller
Am Donnerstag, 27. Oktober 2016, 15:36:08 CET schrieb Harsh Jain: Hi Harsh, > >> +static void chcr_verify_tag(struct aead_request *req, u8 *input, int > >> *err) > >> +{ > >> + u8 temp[SHA512_DIGEST_SIZE]; > >> + struct crypto_aead *tfm = crypto_aead_reqtfm(req); > >> + int authsize = crypto_a

Re: [PATCH v4] poly1305: generic C can be faster on chips with slow unaligned access

2016-11-08 Thread Martin Willi
> By using the unaligned access helpers, we drastically improve > performance on small MIPS routers that have to go through the > exception fix-up handler for these unaligned accesses. I couldn't measure any slowdown here, so: Acked-by: Martin Willi > -   dctx->s[0] = le32_to_cpuvp(key +