Re: [PATCH 4.9] hw_random: Don't use a stack buffer in add_early_randomness()

2016-10-16 Thread Matt Mullins
On Sun, Oct 16, 2016 at 10:17:15AM -0700, Andy Lutomirski wrote: > hw_random carefully avoids using a stack buffer except in > add_early_randomness(). This causes a crash in virtio_rng if > CONFIG_VMAP_STACK=y. I hadn't noticed the existing kmalloc in the __init, for the explicit purpose of virt_

Re: virtio-rng scatterlist null pointer dereference with VMAP_STACK=y

2016-10-16 Thread Andy Lutomirski
On Sun, Oct 16, 2016 at 9:59 AM, Andy Lutomirski wrote: > On Sat, Oct 15, 2016 at 5:21 PM, Matt Mullins wrote: >> With VMAP_STACK=y and HW_RANDOM_VIRTIO=y, I get the following crash: >> >> [1.470437] BUG: unable to handle kernel NULL pointer dereference at >> (null) >> [1.473350] IP: []

Re: virtio-rng scatterlist null pointer dereference with VMAP_STACK=y

2016-10-16 Thread Andy Lutomirski
On Sat, Oct 15, 2016 at 5:21 PM, Matt Mullins wrote: > With VMAP_STACK=y and HW_RANDOM_VIRTIO=y, I get the following crash: > > [1.470437] BUG: unable to handle kernel NULL pointer dereference at > (null) > [1.473350] IP: [] sg_init_one+0x65/0x90 > [1.474658] PGD 0 > [1.475169] O

Re: [PATCH 3/7] crypto: doc - fix source comments for Sphinx

2016-10-16 Thread Markus Heiser
Am 16.10.2016 um 15:03 schrieb Stephan Mueller : > Am Sonntag, 16. Oktober 2016, 14:56:49 CEST schrieb Markus Heiser: > > Hi Markus, > ... > >> compared to DocBook, with sphinx you can use (have to use) the reST markup >> in source code comments. >> >> Here, the code example is just a (indente

Re: [PATCH 7/7] crypto: doc - clarify AEAD memory structure

2016-10-16 Thread Stephan Mueller
Am Sonntag, 16. Oktober 2016, 15:11:38 CEST schrieb Markus Heiser: Hi Markus, > These are only my 2cent in hope that helps ... there is no rule > to use any special markup ... use markup as you prefer ;-) Thanks for the pointers. I will release a new patch set following your suggestions after o

Re: [PATCH 7/7] crypto: doc - clarify AEAD memory structure

2016-10-16 Thread Markus Heiser
Am 16.10.2016 um 05:22 schrieb Stephan Mueller : > The previous description have been misleading and partially incorrect. > > Reported-by: Harsh Jain > Signed-off-by: Stephan Mueller > --- > crypto/algif_aead.c | 14 ++ > include/crypto/aead.h | 35 +++-

Re: [PATCH 3/7] crypto: doc - fix source comments for Sphinx

2016-10-16 Thread Stephan Mueller
Am Sonntag, 16. Oktober 2016, 14:56:49 CEST schrieb Markus Heiser: Hi Markus, ... > compared to DocBook, with sphinx you can use (have to use) the reST markup > in source code comments. > > Here, the code example is just a (indented) float text and this is > why you have to quote the asterisk "\

Re: [PATCH 3/7] crypto: doc - fix source comments for Sphinx

2016-10-16 Thread Markus Heiser
Am 16.10.2016 um 05:18 schrieb Stephan Mueller : > Update comments to avoid any complaints from Sphinx during compilation. > > Signed-off-by: Stephan Mueller > --- > include/crypto/aead.h | 14 +++--- > include/crypto/hash.h | 2 +- > include/crypto/skcipher.h | 4 ++-- > include