[PATCH] s390/crypto: initialize ret to zero to avoid returning garbage value

2016-09-05 Thread Colin King
From: Colin Ian King static analysis with cppcheck detected that ret is not initialized and hence garbage is potentially being returned in the case where prng_data->ppnows.reseed_counter <= prng_reseed_limit. Signed-off-by: Colin Ian King --- arch/s390/crypto/prng.c | 2 +- 1 file changed, 1 i

Re: [PATCHv3 03/11] crypto: omap-sham: implement context export/import APIs

2016-09-05 Thread Tero Kristo
On 01/09/16 10:46, Tero Kristo wrote: On 01/09/16 10:31, Herbert Xu wrote: On Thu, Sep 01, 2016 at 10:28:47AM +0300, Tero Kristo wrote: Yeah, the flush should do the trick now. Kind of a chicken-egg problem here. :P How do you see the situation with the above explanation? The export function

[PATCH] crypto: arm/ghash: change internal cra_name to "__ghash"

2016-09-05 Thread Ard Biesheuvel
The fact that the internal synchrous hash implementation is called "ghash" like the publicly visible one is causing the testmgr code to misidentify it as an algorithm that requires testing at boottime. So rename it to "__ghash" to prevent this. Signed-off-by: Ard Biesheuvel --- Hi Herbert, This

Re: [PATCH 1/2] crypto: arm/ghash-ce - add missing async import/export

2016-09-05 Thread Herbert Xu
On Thu, Sep 01, 2016 at 04:14:22PM +0100, Ard Biesheuvel wrote: > > The culprit appears to be that the .cra_name of the internal shash is > "ghash", (and not "__ghash" like in the x86 case) which causes the > test code to run the test on not only the public ahash, but also on > the internal cryptd(

Re: Crypto Fixes for 4.8

2016-09-05 Thread Herbert Xu
Hi Linus: This push fixes a regression in the cryptd code that breaks certain accelerated AED algorithms as well as an older regression in the caam driver that breaks IPsec. Please pull from git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6.git linus Herbert Xu (1): crypt

Re: [cryptodev:master 65/80] drivers/pci/quirks.c:843:6: error: 'struct pci_dev' has no member named 'sriov'

2016-09-05 Thread Herbert Xu
On Sat, Sep 03, 2016 at 06:40:27PM -0700, Ananth Jasty wrote: > As this fix is purely SRIOV related, an ifdef guard for SRIOV support should > be sufficient to prevent this header dependency. Please don't top-post. > On Sep 3, 2016, at 5:16 PM, kbuild test robot wrote: > > > tree: > > https

Re: algif_akcipher

2016-09-05 Thread Herbert Xu
On Sun, Sep 04, 2016 at 04:06:43PM +0200, Stephan Mueller wrote: > Hi Herbert, David, > > may I inquire for the plans with algif_akcipher? The reason I am asking is > whether this interface may be accepted or whether a key rings based solution > is used and whether I can leave or remove the akci