Re: [PATCH] crypto: mv_cesa: remove NO_IRQ reference

2016-09-02 Thread Boris Brezillon
On Sat, 3 Sep 2016 01:26:40 +0200 Arnd Bergmann wrote: > Drivers should not use NO_IRQ, as we are trying to get rid of that. > In this case, the call to irq_of_parse_and_map() is both wrong > (as it returns '0' on failure, not NO_IRQ) and unnecessary > (as platform_get_irq() does the same thing)

Re: [dm-devel] dm-crypt: flush crypt_queue on suspend? on REQ_FLUSH?

2016-09-02 Thread Eric Wheeler
On Fri, 2 Sep 2016, Eric Wheeler wrote: > We have a KVM => dm-crypt => dm-thin stack and a snapshot may have > partially completed queued IO out-of-order. EXT4 is giving errors like > this after mounting a snapshot, but only on files recently modified near > the snapshot time. This might imply

Re: Who will copy the AAD data to dest. buffer

2016-09-02 Thread Harsh Jain
Thanks Herbert for clarification. It means Libkcapi documentation needs update of chapter "Aead Cipher API". Regards Harsh Jain On Fri, Sep 2, 2016 at 8:12 PM, Herbert Xu wrote: > On Fri, Sep 02, 2016 at 08:05:04PM +0530, Harsh Jain wrote: >> Hi Herbert, >> >> Is copy of AAD data to destinati

[PATCH] crypto: caam: add missing header dependencies

2016-09-02 Thread Baoyou Xie
We get 1 warning when building kernel with W=1: drivers/crypto/caam/ctrl.c:398:5: warning: no previous prototype for 'caam_get_era' [-Wmissing-prototypes] In fact, this function is declared in drivers/crypto/caam/ctrl.h and be exported, thus can be refrenced by modules, so this patch adds missin

[PATCH] crypto: mv_cesa: remove NO_IRQ reference

2016-09-02 Thread Arnd Bergmann
Drivers should not use NO_IRQ, as we are trying to get rid of that. In this case, the call to irq_of_parse_and_map() is both wrong (as it returns '0' on failure, not NO_IRQ) and unnecessary (as platform_get_irq() does the same thing) This removes the call to irq_of_parse_and_map() and checks for t

dm-crypt: flush crypt_queue on suspend? on REQ_FLUSH?

2016-09-02 Thread Eric Wheeler
Hello all, We have a KVM => dm-crypt => dm-thin stack in and a snapshot may have partially completed queued IO out-of-order. EXT4 is giving errors like this after mounting a snapshot, but only on files recently modified near the snapshot time. This might imply out-of-order writes since, pres

[PATCH v2 2/2] crypto: qat - fix resource release omissions

2016-09-02 Thread Quentin Lambert
In certain cases qat_uclo_parse_uof_obj used to return with an error code before releasing all resources. This patch add a jump to the appropriate label ensuring that the resources are properly released before returning. This issue was found with Hector. Signed-off-by: Quentin Lambert --- drive

[PATCH v2 1/2] crypto: qat - introduces a variable to handle error codes

2016-09-02 Thread Quentin Lambert
Most error code used to jump to a label that lead to a "return -EFAULT" statement. This patch introduces a variable that stores the error code so that other error branches can use the same label to exit. Signed-off-by: Quentin Lambert --- drivers/crypto/qat/qat_common/qat_uclo.c | 13

[PATCH v2 0/2] add omitted release in qat_common

2016-09-02 Thread Quentin Lambert
The first patch introduces a variable to handle different error codes and be able to reuse the same clean up code. The second add an omitted release by jumping to the clean code having set the returned value to the proper error code. -changes since v1 I failed to send the first version properly an

[PATCH 0/2][RESEND] add omitted release in qat_common

2016-09-02 Thread Quentin Lambert
The first patch introduces a variable to handle different error codes and be able to reuse the same clean up code. The second add an omitted release by jumping to the clean code having set the returned value to the proper error code. --- drivers/crypto/qat/qat_common/qat_uclo.c | 16 +++

[PATCH 2/2] crypto: qat - fix resource release omissions

2016-09-02 Thread Quentin Lambert
This issue was found with Hector. Signed-off-by: Quentin Lambert --- drivers/crypto/qat/qat_common/qat_uclo.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- a/drivers/crypto/qat/qat_common/qat_uclo.c +++ b/drivers/crypto/qat/qat_common/qat_uclo.c @@ -981,7 +981,8 @@ static int q

[PATCH 1/2] crypto: qat - introduces a variable to handle error codes

2016-09-02 Thread Quentin Lambert
Most error code used to jump to a label that lead to a "return -EFAULT" statement. This patch introduces a variable that stores the error code so that other error branches can use the same label to exit. Signed-off-by: Quentin Lambert --- drivers/crypto/qat/qat_common/qat_uclo.c | 13

[PATCH 0/2] add omitted release in qat_common

2016-09-02 Thread Quentin Lambert
The first patch introduces a variable to handle different error codes and be able to reuse the same clean up code. The second add an omitted release by jumping to the clean code having set the returned value to the proper error code. --- drivers/crypto/qat/qat_common/qat_uclo.c | 16 +++

[PATCH 1/2][RESEND] crypto: qat - introduces a variable to handle error codes

2016-09-02 Thread Quentin Lambert
Most error code used to jump to a label that lead to a "return -EFAULT" statement. This patch introduces a variable that stores the error code so that other error branches can use the same label to exit. Signed-off-by: Quentin Lambert --- drivers/crypto/qat/qat_common/qat_uclo.c | 13

[PATCH 2/2] crypto: qat - fix resource release omissions

2016-09-02 Thread Quentin Lambert
In certain cases qat_uclo_parse_uof_obj used to return with an error code before releasing all resources. This patch add a jump to the appropriate label ensuring that the resources are properly released before returning. This issue was found with Hector. Signed-off-by: Quentin Lambert --- drive

Re: Who will copy the AAD data to dest. buffer

2016-09-02 Thread Herbert Xu
On Fri, Sep 02, 2016 at 08:05:04PM +0530, Harsh Jain wrote: > Hi Herbert, > > Is copy of AAD data to destination buffer when dst != src is mandatory > requirements for crypto drivers or we can skip this copy. Actually I > am bit confused, In following link Stephen had mentioned caller will > memcp

Who will copy the AAD data to dest. buffer

2016-09-02 Thread Harsh Jain
Hi Herbert, Is copy of AAD data to destination buffer when dst != src is mandatory requirements for crypto drivers or we can skip this copy. Actually I am bit confused, In following link Stephen had mentioned caller will memcpy the AAD to destination buffer but authenc.c also copies the AAD to des

Re: CONFIG_FIPS without module loading support?

2016-09-02 Thread Herbert Xu
NTU wrote: > Ok, can we merge that in? We can if you send us a patch :) -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a messag

Re: [PATCH v2 3/4] hw_random: jz4780-rng: Add RNG node to jz4780.dtsi

2016-09-02 Thread PrasannaKumar Muralidharan
> I don't like this change. The RNG registers are documented as a part of > the same hardware block as the clock & power stuff which the CGU driver > handles, and indeed in the M200 SoC there is a power-related register > after the RNG registers. So shortening the range covered by the CGU > driver

Re: [PATCH v2 3/4] hw_random: jz4780-rng: Add RNG node to jz4780.dtsi

2016-09-02 Thread Paul Burton
On 27/08/16 19:14, PrasannaKumar Muralidharan wrote: > This patch adds RNG node to jz4780.dtsi. > > Signed-off-by: PrasannaKumar Muralidharan > --- > arch/mips/boot/dts/ingenic/jz4780.dtsi | 7 ++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/arch/mips/boot/dts/ingeni

[PATCH] crypto: ccp - add missing release in ccp_dmaengine_register

2016-09-02 Thread Quentin Lambert
ccp_dmaengine_register used to return with an error code before releasing all resource. This patch adds a jump to the appropriate label ensuring that the resources are properly released before returning. This issue was found with Hector. Signed-off-by: Quentin Lambert --- drivers/crypto/ccp/ccp