sha1_mb broken

2016-08-25 Thread Stephan Mueller
Hi, I tried to execute tests with sha1_mb. The execution simply stalls when invoking a digest operation -- i.e. the digest operation does not finish. After some time after invoking the hashing operation, the following log appears (note, the kccavs_* functions are my test code; that test code w

Re: Entropy sources

2016-08-25 Thread H. Peter Anvin
On 08/25/16 16:35, Sandy Harris wrote: > On Thu, Aug 25, 2016 at 5:30 PM, H. Peter Anvin wrote: > >> The network stack is a good source of entropy, *once it is online*. >> However, the most serious case is while the machine is still booting, >> when the network will not have enabled yet. >> >>

Re: Entropy sources (was: /dev/random - a new approach)

2016-08-25 Thread Sandy Harris
On Thu, Aug 25, 2016 at 5:30 PM, H. Peter Anvin wrote: > The network stack is a good source of entropy, *once it is online*. > However, the most serious case is while the machine is still booting, > when the network will not have enabled yet. > > -hpa One possible solution is at: https:/

Re: Entropy sources (was: /dev/random - a new approach)

2016-08-25 Thread H. Peter Anvin
On 08/20/16 22:37, Jeffrey Walton wrote: >> >> The biggest problem there is that the timer interrupt adds *no* entropy >> unless there is a source of asynchronicity in the system. On PCs, >> traditionally the timer has been run from a completely different crystal >> (14.31818 MHz) than the CPU, wh

Re: Git bisected regression for ipsec/aead

2016-08-25 Thread Sowmini Varadhan
On (08/25/16 16:49), Herbert Xu wrote: > This bisection doesn't make much sense as this patch just causes > cryptd to be used a little more more frequently. But it does > point the finger at cryptd. : > So we have list corruption here, possibly caused by use-after-free. > I did spot one bug in

Re: [PATCH v2 5/5] hwrng: amd: Rework of the amd768-hwrng driver

2016-08-25 Thread Jason Cooper
Hi Corentin, On Thu, Aug 25, 2016 at 02:16:35PM +0200, LABBE Corentin wrote: > This patch convert the hwrng interface used by amd768-rng to its new API > by replacing data_read()/data_present() by read(). > > Furthermore, Instead of having two global variable, it's better to use a > private struc

Re: [PATCH] hwrng: pasemi_rng.c: Migrate to managed API

2016-08-25 Thread PrasannaKumar Muralidharan
> I will propose to use devm_ioremap_resource() instead for removing this > hardcoded 0x100, but i cannot find any user of this driver in any dts. (And > so cannot check that this 0x100 is given in any DT resource node) > > Is this normal ? I wanted to use devm_ioremap_resource but could not fin

[PATCH] crypto: FIPS - allow tests to be disabled in FIPS mode

2016-08-25 Thread Stephan Mueller
In FIPS mode, additional restrictions may apply. If these restrictions are violated, the kernel will panic(). This patch allows test vectors for symmetric ciphers to be marked as to be skipped in FIPS mode. Together with the patch, the XTS test vectors where the AES key is identical to the tweak k

[PATCH v2 1/5] hwrng: amd: Fix style problem with blank line

2016-08-25 Thread LABBE Corentin
Some blank line are unncessary, and one is missing after declaration. This patch fix thoses style problems. Signed-off-by: LABBE Corentin --- drivers/char/hw_random/amd-rng.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/char/hw_random/amd-rng.c b/drivers/char/

[PATCH v2 0/5] hwrng: amd: rework of the amd hwrng driver

2016-08-25 Thread LABBE Corentin
Changes since v1: - Keep the hwrng name as "amd" LABBE Corentin (5): hwrng: amd: Fix style problem with blank line hwrng: amd: use the BIT macro hwrng: amd: Be consitent with the driver name hwrng: amd: Remove asm/io.h hwrng: amd: Rework of the amd768-hwrng driver drivers/char/hw_rand

[PATCH v2 4/5] hwrng: amd: Remove asm/io.h

2016-08-25 Thread LABBE Corentin
checkpatch complains about used instead of linux/io.h. In fact it is not needed. This patch remove it, and in the process, alphabetize the other headers. Signed-off-by: LABBE Corentin --- drivers/char/hw_random/amd-rng.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a

[PATCH v2 5/5] hwrng: amd: Rework of the amd768-hwrng driver

2016-08-25 Thread LABBE Corentin
This patch convert the hwrng interface used by amd768-rng to its new API by replacing data_read()/data_present() by read(). Furthermore, Instead of having two global variable, it's better to use a private struct. This will permit to remove amd_pdev variable. Finally, Instead of accessing hw direc

Re: [PATCH] hwrng: pasemi_rng.c: Migrate to managed API

2016-08-25 Thread LABBE Corentin
On Thu, Aug 25, 2016 at 05:04:16PM +0530, PrasannaKumar Muralidharan wrote: > Use devm_ioremap and devm_hwrng_register instead of ioremap and > hwrng_register. This removes unregistering and error handling code. > > This patch is not tested with hardware as I don't have access to it. > > Signed-o

[PATCH v2 3/5] hwrng: amd: Be consitent with the driver name

2016-08-25 Thread LABBE Corentin
The driver name is displayed each time differently. This patch make use of the same name everywhere. Signed-off-by: LABBE Corentin --- drivers/char/hw_random/amd-rng.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/char/hw_random/amd-rng.c b/drivers/char/

[PATCH v2 2/5] hwrng: amd: use the BIT macro

2016-08-25 Thread LABBE Corentin
This patch add usage of the BIT() macro Signed-off-by: LABBE Corentin --- drivers/char/hw_random/amd-rng.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/char/hw_random/amd-rng.c b/drivers/char/hw_random/amd-rng.c index 45b7965..d0042f5 100644 --- a/drivers/cha

[PATCH] hwrng: pasemi_rng.c: Migrate to managed API

2016-08-25 Thread PrasannaKumar Muralidharan
Use devm_ioremap and devm_hwrng_register instead of ioremap and hwrng_register. This removes unregistering and error handling code. This patch is not tested with hardware as I don't have access to it. Signed-off-by: PrasannaKumar Muralidharan --- drivers/char/hw_random/pasemi-rng.c | 26 +++

Re: crypto: mxs-dcp: do not call blocking ops when !TASK_RUNNING; state=1

2016-08-25 Thread Herbert Xu
On Thu, Aug 25, 2016 at 06:44:25AM +0200, Stefan Wahren wrote: > Hi Fabio, > > > Fabio Estevam hat am 25. August 2016 um 00:52 > > geschrieben: > > > > > > Hi Stefan, > > > > On Tue, Aug 23, 2016 at 5:38 PM, Stefan Wahren > > wrote: > > > Hi, > > > > > > i'm using a iMX233-OLinuXino board an

Re: Git bisected regression for ipsec/aead

2016-08-25 Thread Herbert Xu
On Fri, Aug 19, 2016 at 03:21:24PM -0400, Sowmini Varadhan wrote: > > Hi Herbert, > > In the process of testing ipsec I ran into panics (details below) > with the algorithm > "aead rfc4106(gcm(aes)) 0x1234567890123456789012345678901234567890 64" > > git-bisect analyzed this down to > >7271

Re: [PATCH -next] chcr: Fix non static symbol warning

2016-08-25 Thread Herbert Xu
On Wed, Aug 24, 2016 at 10:50:24PM +0800, Wei Yongjun wrote: > Hi Herbert, > > On 08/24/2016 09:06 PM, Herbert Xu wrote: > > On Mon, Aug 22, 2016 at 04:11:18PM +, Wei Yongjun wrote: > >> From: Wei Yongjun > >> > >> Fixes the following sparse warning: > >> > >> drivers/crypto/chelsio/chcr_algo