Re: Problems with cbc(aes) and do_alg0test()

2016-08-24 Thread Stephan Mueller
Am Dienstag, 23. August 2016, 22:44:39 CEST schrieb Michael McKay: Hi Michael, > We are writing a device driver with kernel v3.14, and trying to encrypt some > data using the Linux kernel algorithm “cbc(aes)”. Our /proc/crypto shows > the following is loaded: driver “cbc-aes-aesni”, module “aesni

[PATCH] softirq: fix tasklet_kill() and its users

2016-08-24 Thread Santosh Shilimkar
Semantically the expectation from the tasklet init/kill API should be as below. tasklet_init() == Init and Enable scheduling tasklet_kill() == Disable scheduling and Destroy tasklet_init() API exibit above behavior but not the tasklet_kill(). The tasklet handler can still get scheduled and run ev

Re: [PATCH] crypto: vmx - fix null dereference in p8_aes_xts_crypt

2016-08-24 Thread Herbert Xu
On Wed, Aug 24, 2016 at 03:34:40PM +0800, Li Zhong wrote: > walk.iv is not assigned a value in blkcipher_walk_init. It makes iv > uninitialized. > It is possibly a null value(as shown below), which is then used by > aes_p8_encrypt. > > This patch moves iv = walk.iv after blkcipher_walk_virt, in

Re: [PATCH 3/5] hwrng: amd: Be consitent with the driver name

2016-08-24 Thread Herbert Xu
On Wed, Aug 24, 2016 at 03:51:22PM +0200, LABBE Corentin wrote: > On Wed, Aug 24, 2016 at 06:58:11PM +0800, Herbert Xu wrote: > > On Fri, Aug 19, 2016 at 03:42:55PM +0200, LABBE Corentin wrote: > > > The driver name is displayed each time differently. > > > This patch make use of the same name ever

Re: crypto: mxs-dcp: do not call blocking ops when !TASK_RUNNING; state=1

2016-08-24 Thread Stefan Wahren
/Articles/628628/ > > The kernelci boot log does not show this problem on a imx23-olinuxino > running linux-next: > https://storage.kernelci.org/next/next-20160824/arm-mxs_defconfig/lab-pengutronix/boot-imx23-olinuxino.html > > We still have the errors below: > > [4.40

Re: [PATCH v2 2/2] HWRNG: thunderx: Add Cavium HWRNG driver for ThunderX SoC.

2016-08-24 Thread David Daney
On 08/23/2016 10:46 PM, Corentin LABBE wrote: Hello +/* Read data from the RNG unit */ +static int cavium_rng_read(struct hwrng *rng, void *dat, size_t max, bool wait) +{ + struct cavium_rng *p = container_of(rng, struct cavium_rng, ops); + unsigned int size = max; + + while (

Re: crypto: mxs-dcp: do not call blocking ops when !TASK_RUNNING; state=1

2016-08-24 Thread Fabio Estevam
on a imx23-olinuxino running linux-next: https://storage.kernelci.org/next/next-20160824/arm-mxs_defconfig/lab-pengutronix/boot-imx23-olinuxino.html We still have the errors below: [4.40] mxs-dcp 80028000.dcp: Failed to register sha1 hash! [4.41] mxs-dcp: probe of 80028000.dcp f

Re: [RFC PATCH v1 18/28] crypto: add AMD Platform Security Processor driver

2016-08-24 Thread Tom Lendacky
On 08/23/2016 02:14 AM, Herbert Xu wrote: > On Mon, Aug 22, 2016 at 07:27:22PM -0400, Brijesh Singh wrote: >> The driver to communicate with Secure Encrypted Virtualization (SEV) >> firmware running within the AMD secure processor providing a secure key >> management interface for SEV guests. >>

Re: [PATCH v2 1/2] PCI: quirk fixup for cavium invalid sriov link value.

2016-08-24 Thread Bjorn Helgaas
On Tue, Aug 23, 2016 at 04:27:14PM -0700, Omer Khaliq wrote: > From: Ananth Jasty > > Cavium cn88xx hardware presents an incorrect SR-IOV Function > Dependency Link, add a fixup quirk for the affected devices. > > Acked-by: David Daney > Signed-off-by: Ananth Jasty > Signed-off-by: Omer Khaliq

Re: [PATCH -next] chcr: Fix non static symbol warning

2016-08-24 Thread Wei Yongjun
Hi Herbert, On 08/24/2016 09:06 PM, Herbert Xu wrote: > On Mon, Aug 22, 2016 at 04:11:18PM +, Wei Yongjun wrote: >> From: Wei Yongjun >> >> Fixes the following sparse warning: >> >> drivers/crypto/chelsio/chcr_algo.c:593:5: warning: >> symbol 'cxgb4_is_crypto_q_full' was not declared. Should

Re: [PATCH] crypto: FIPS - allow RSA keys >= 2048 bits

2016-08-24 Thread Herbert Xu
On Tue, Aug 23, 2016 at 10:09:32AM +0200, Stephan Mueller wrote: > With a public notification, NIST now allows the use of RSA keys with a > modulus >= 2048 bits. The new rule allows any modulus size >= 2048 bits > provided that either 2048 or 3072 bits are supported at least so that > the entire RS

Re: [PATCH -next] chcr: Fix non static symbol warning

2016-08-24 Thread Herbert Xu
On Mon, Aug 22, 2016 at 04:11:18PM +, Wei Yongjun wrote: > From: Wei Yongjun > > Fixes the following sparse warning: > > drivers/crypto/chelsio/chcr_algo.c:593:5: warning: > symbol 'cxgb4_is_crypto_q_full' was not declared. Should it be static? > > Signed-off-by: Wei Yongjun Please repos

Re: [PATCH 3/5] hwrng: amd: Be consitent with the driver name

2016-08-24 Thread LABBE Corentin
On Wed, Aug 24, 2016 at 06:58:11PM +0800, Herbert Xu wrote: > On Fri, Aug 19, 2016 at 03:42:55PM +0200, LABBE Corentin wrote: > > The driver name is displayed each time differently. > > This patch make use of the same name everywhere. > > > > Signed-off-by: LABBE Corentin > > --- > > drivers/cha

Re: [PATCH] crypto: rockchip - use devm_add_action_or_reset()

2016-08-24 Thread Herbert Xu
On Tue, Aug 23, 2016 at 08:28:54PM +0530, Sudip Mukherjee wrote: > If devm_add_action() fails we are explicitly calling the cleanup to free > the resources allocated. Lets use the helper devm_add_action_or_reset() > and return directly in case of error, as we know that the cleanup function > has b

Re: [PATCH] crypto: mxc-scc - check clk_prepare_enable() error

2016-08-24 Thread Herbert Xu
On Sun, Aug 21, 2016 at 11:37:27PM -0300, Fabio Estevam wrote: > From: Fabio Estevam > > clk_prepare_enable() may fail, so we should better check its return > value and propagate it in the case of failure. > > Signed-off-by: Fabio Estevam Patch applied. Thanks. -- Email: Herbert Xu Home Pag

Re: [PATCH] hw_random: omap3-rom-rng.c: Remove obsoleted functions

2016-08-24 Thread Herbert Xu
On Sat, Aug 20, 2016 at 09:31:06PM +0530, PrasannaKumar Muralidharan wrote: > Remove omap3_rom_rng_data_present method as it was returning 1 always. > Use .read callback instead of .data_read callback. This avoids use of > obsolete callbacks. > > This patch is not tested with hardware as I don't h

Re: [PATCH] crypto/xor: skip speed test if the xor function is selected automatically

2016-08-24 Thread Herbert Xu
Martin Schwidefsky wrote: > If the architecture selected the xor function with XOR_SELECT_TEMPLATE > the speed result of the do_xor_speed benchmark is of limited value. > The speed measurement increases the bootup time a little, which can > makes a difference for kernels used in container like vir

Re: [PATCH -next] crypto: drbg - fix error return code

2016-08-24 Thread Herbert Xu
On Sat, Aug 20, 2016 at 03:06:51PM +, Wei Yongjun wrote: > Fix to return a negative error code from the error handling > case instead of 0. > > Signed-off-by: Wei Yongjun Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apa

Re: [PATCH -next v2] crypto: sun4i-ss - fix missing unlock on error in sun4i_hash()

2016-08-24 Thread Herbert Xu
On Sat, Aug 20, 2016 at 10:48:53AM +, Wei Yongjun wrote: > Add the missing unlock before return from function sun4i_hash() > in the error handling case. > > Fixes: 477d9b2e591b ("crypto: sun4i-ss - unify update/final function") > Signed-off-by: Wei Yongjun Patch applied. Thanks. -- Email:

Re: [PATCH] crypto: qat - fix aes-xts key sizes

2016-08-24 Thread Herbert Xu
On Thu, Aug 18, 2016 at 07:53:36PM +0100, Giovanni Cabiddu wrote: > Increase value of supported key sizes for qat_aes_xts. > aes-xts keys consists of keys of equal size concatenated. > > Reported-by: Wenqian Yu > Signed-off-by: Giovanni Cabiddu Patch applied. Thanks. -- Email: Herbert Xu Hom

Re: [PATCH] hw_random: Improve description of the ->read() interface

2016-08-24 Thread Herbert Xu
On Thu, Aug 18, 2016 at 01:37:21PM +0100, Daniel Thompson wrote: > Currently, very few RNG drivers support single byte reads using the > ->read() interface. Of the 14 drivers in drivers/char/hw_random that > support this interface only three of these actually support max == 1. > The other behaviour

Re: [PATCH V2 linux-next] hwrng: update Freescale i.MX RNGA Random Number Generator

2016-08-24 Thread Herbert Xu
On Tue, Aug 16, 2016 at 09:49:45PM +0200, Fabian Frederick wrote: > We can directly depend on SOC_IMX31 since commit c9ee94965dce > ("ARM: imx: deconstruct mxc_rnga initialization") > > Since that commit, CONFIG_HW_RANDOM_MXC_RNGA could not be switched on > with unknown symbol ARCH_HAS_RNGA and mx

Re: [PATCH 3/5] hwrng: amd: Be consitent with the driver name

2016-08-24 Thread Herbert Xu
On Fri, Aug 19, 2016 at 03:42:55PM +0200, LABBE Corentin wrote: > The driver name is displayed each time differently. > This patch make use of the same name everywhere. > > Signed-off-by: LABBE Corentin > --- > drivers/char/hw_random/amd-rng.c | 13 ++--- > 1 file changed, 6 insertions(+

[PATCH] crypto: vmx - fix null dereference in p8_aes_xts_crypt

2016-08-24 Thread Li Zhong
walk.iv is not assigned a value in blkcipher_walk_init. It makes iv uninitialized. It is possibly a null value(as shown below), which is then used by aes_p8_encrypt. This patch moves iv = walk.iv after blkcipher_walk_virt, in which walk.iv is set. [17856.268050] Unable to handle kernel pagin