Re: getrandom waits for a long time when /dev/random is insufficiently read from

2016-07-29 Thread Alex Xu
On Fri, 29 Jul 2016 19:03:51 +0200 Stephan Mueller wrote as excerpted: > Am Freitag, 29. Juli 2016, 10:14:07 CEST schrieb Alex Xu: > > I don't follow. Assuming you are correct and this is the issue, then > > reading 128 bits (16 bytes) from /dev/random should "exhaust the > > supply" and then both

Re: getrandom waits for a long time when /dev/random is insufficiently read from

2016-07-29 Thread Stephan Mueller
Am Freitag, 29. Juli 2016, 10:14:07 CEST schrieb Alex Xu: Hi Alex, > On Fri, 29 Jul 2016 15:12:30 +0200 > > Stephan Mueller wrote as excerpted: > > Am Freitag, 29. Juli 2016, 09:03:45 CEST schrieb Alex Xu: > > > In my opinion, assuming I am not doing something terribly wrong, > > > this constit

Re: getrandom waits for a long time when /dev/random is insufficiently read from

2016-07-29 Thread Alex Xu
On Fri, 29 Jul 2016 15:12:30 +0200 Stephan Mueller wrote as excerpted: > Am Freitag, 29. Juli 2016, 09:03:45 CEST schrieb Alex Xu: > > In my opinion, assuming I am not doing something terribly wrong, > > this constitutes a bug in the kernel's handling of getrandom calls > > at boot, possibly only

Re: getrandom waits for a long time when /dev/random is insufficiently read from

2016-07-29 Thread Stephan Mueller
Am Freitag, 29. Juli 2016, 09:03:45 CEST schrieb Alex Xu: Hi Alex, > On Fri, 29 Jul 2016 12:24:27 +0200 > > Nikos Mavrogiannopoulos wrote: > > On Fri, Jul 29, 2016 at 7:40 AM, Stephan Mueller > > > > wrote: > > > And finally, you have a coding error that is very very common but > > > fatal wh

Re: getrandom waits for a long time when /dev/random is insufficiently read from

2016-07-29 Thread Alex Xu
On Fri, 29 Jul 2016 12:24:27 +0200 Nikos Mavrogiannopoulos wrote: > On Fri, Jul 29, 2016 at 7:40 AM, Stephan Mueller > wrote: > > And finally, you have a coding error that is very very common but > > fatal when reading from /dev/random: you do not account for short > > reads which implies that y

Re: [PATCH] crypto: marvell: Don't copy IV vectors from the _process op for ciphers

2016-07-29 Thread Herbert Xu
Romain Perier wrote: > The IV output vectors should only be copied from the _complete operation > and not from the _process operation, i.e only from the operation that is > designed to copy the result of the request to the right location. This > copy is already done in the _complete operation, so

Re: getrandom waits for a long time when /dev/random is insufficiently read from

2016-07-29 Thread Nikos Mavrogiannopoulos
On Fri, Jul 29, 2016 at 7:40 AM, Stephan Mueller wrote: > And finally, you have a coding error that is very very common but fatal when > reading from /dev/random: you do not account for short reads which implies > that your loop continues even in the case of short reads. > > Fix your code with som

[PATCH] crypto/testmgr.c: fix !x==y confusion

2016-07-29 Thread yanjiang.jin
From: Yanjiang Jin "if (!ret == template[i].fail)" is confusing to compilers (gcc5): crypto/testmgr.c: In function '__test_aead': crypto/testmgr.c:531:12: warning: logical not is only applied to the left hand side of comparison [-Wlogical-not-parentheses] if (!ret == template[i].fail) {