Re: [PATCH v2 0/4] Introduce bulk mode for crypto engine framework

2016-04-17 Thread Baolin Wang
On 18 April 2016 at 13:45, Herbert Xu wrote: > On Mon, Apr 18, 2016 at 01:31:09PM +0800, Baolin Wang wrote: >> >> We've tried to do this in dm-crypt, but it failed. >> The dm-crypt maintainer explained to me that I should optimize the >> driver, not add strange hw-dependent crypto modes to dm-cryp

Re: [PATCH v2 0/4] Introduce bulk mode for crypto engine framework

2016-04-17 Thread Herbert Xu
On Mon, Apr 18, 2016 at 01:31:09PM +0800, Baolin Wang wrote: > > We've tried to do this in dm-crypt, but it failed. > The dm-crypt maintainer explained to me that I should optimize the > driver, not add strange hw-dependent crypto modes to dm-crypt, this is > not the first crypto accelerator that

Re: [PATCH v2 0/4] Introduce bulk mode for crypto engine framework

2016-04-17 Thread Baolin Wang
Hi Herbert, On 15 April 2016 at 21:48, Herbert Xu wrote: > On Tue, Mar 15, 2016 at 03:47:58PM +0800, Baolin Wang wrote: >> Now some cipher hardware engines prefer to handle bulk block by merging >> requests >> to increase the block size and thus increase the hardware engine processing >> speed.

Re: [PATCH] Re: Broken userspace crypto in linux-4.1.18

2016-04-17 Thread Herbert Xu
On Sun, Apr 17, 2016 at 06:39:18PM -0400, Sasha Levin wrote: > > So I mixed stuff up here, I've received a backport that would fix this problem > on 4.1, and applied it. However, I forgot about 3.18. > > Would Milan's backport work on 3.18 as well > (https://www.mail-archive.com/linux-crypto@vger

Re: [PATCH] Re: Broken userspace crypto in linux-4.1.18

2016-04-17 Thread Sasha Levin
On 04/17/2016 06:17 PM, Thomas D. wrote: > Hi, > > Sasha, can you please revert commit > f857638dd72680e2a8faafef7eebb4534cb39fd1 like Greg did with linux-3.10.101 > >> commit 1f2493fcd87bd810c608aa7976388157852eadb2 >> Author: Greg Kroah-Hartman >> Date: Sat Mar 12 21:30:16 2016 -0800 >> >>

Re: [PATCH] Re: Broken userspace crypto in linux-4.1.18

2016-04-17 Thread Thomas D.
Hi, Sasha, can you please revert commit f857638dd72680e2a8faafef7eebb4534cb39fd1 like Greg did with linux-3.10.101 > commit 1f2493fcd87bd810c608aa7976388157852eadb2 > Author: Greg Kroah-Hartman > Date: Sat Mar 12 21:30:16 2016 -0800 > > Revert: "crypto: af_alg - Disallow bind/setkey/... a