[PATCH v2] sunrpc: Fix skcipher/shash conversion

2016-04-02 Thread Herbert Xu
On Sat, Apr 02, 2016 at 11:59:00PM -0400, J. Bruce Fields wrote: > > Thanks. It's getting further now, but appears to be freezing later. > Possibly unrelated. I'm travelling, and it'll be Monday or Wednesday > till I can take another look. Thanks for the update. I've found another bug in the h

Re: nfs/krb5 crash on 4.6-rc1

2016-04-02 Thread J. Bruce Fields
On Sun, Apr 03, 2016 at 09:09:52AM +0800, Herbert Xu wrote: > On Sat, Apr 02, 2016 at 08:13:19PM -0400, J. Bruce Fields wrote: > > As of 3b5cf20c "sunrpc: Use skcipher and ahash/shash", I get a NULL > > dereference in krb5_encrypt on an NFS server when a client attempts to > > mount using krb5. I

Re: nfs/krb5 crash on 4.6-rc1

2016-04-02 Thread Herbert Xu
On Sat, Apr 02, 2016 at 08:13:19PM -0400, J. Bruce Fields wrote: > As of 3b5cf20c "sunrpc: Use skcipher and ahash/shash", I get a NULL > dereference in krb5_encrypt on an NFS server when a client attempts to > mount using krb5. I haven't tried to figure out what's going on beyond > that Oops,

nfs/krb5 crash on 4.6-rc1

2016-04-02 Thread J. Bruce Fields
As of 3b5cf20c "sunrpc: Use skcipher and ahash/shash", I get a NULL dereference in krb5_encrypt on an NFS server when a client attempts to mount using krb5. I haven't tried to figure out what's going on beyond that --b. [ 97.781559] IP: [] krb5_encrypt+0x138/0x1f0 [rpcsec_gss_krb5] [ 9

[PATCH] crypto: document correct return value for request allocation

2016-04-02 Thread Eric Biggers
Signed-off-by: Eric Biggers --- Documentation/DocBook/crypto-API.tmpl | 6 +++--- include/crypto/aead.h | 3 +-- include/crypto/hash.h | 3 +-- include/crypto/skcipher.h | 3 +-- include/linux/crypto.h| 3 +-- 5 files changed, 7 insertio

Re: [PATCH v2 1/4] scatterlist: Introduce some helper functions

2016-04-02 Thread Robert Jarzmik
Baolin Wang writes: > +/** > + * sg_is_contiguous - Check if the scatterlists are contiguous > + * @sga: SG entry > + * @sgb: SG entry > + * > + * Description: > + * If the sga scatterlist is contiguous with the sgb scatterlist, > + * that means they can be merged together. > + * > + **/ > +s