Re: crypto regression in 4.1.18: Check that kernel supports aes-cbc-essiv:sha256 cipher

2016-03-09 Thread Eric Wheeler
On Tue, 1 Mar 2016, Greg KH wrote: > On Tue, Mar 01, 2016 at 01:32:05AM +, Eric Wheeler wrote: > > Hello all, > > > > We updated from 4.1.17 to 4.1.18 (same .config) and now get the following > > error when trying to open a LUKS volume. We've reverted to 4.1.17 and it > > still works, so ex

[PATCH v2 2/3] crypto: s5p-sss - Handle unaligned buffers

2016-03-09 Thread Krzysztof Kozlowski
From: Krzysztof Kozlowski During crypto selftests on Odroid XU3 (Exynos5422) some of the algorithms failed because of passing AES-block unaligned source and destination buffers: alg: skcipher: encryption failed on chunk test 1 for ecb-aes-s5p: ret=22 Handle such case by copying the buffers to a

[PATCH v2 3/3] crypto: s5p-sss - Sort the headers to improve readability

2016-03-09 Thread Krzysztof Kozlowski
Sort the headers alphabetically to improve readability and to spot duplications easier. Suggested-by: Vladimir Zapolskiy Signed-off-by: Krzysztof Kozlowski --- Changes since v1: 1. New patch. My email differs from one used in previous patches because this time I am sending this from work. ---

[PATCH v2 1/3] crypto: s5p-sss - Minor coding cleanups

2016-03-09 Thread Krzysztof Kozlowski
From: Krzysztof Kozlowski Remove unneeded inclusion of delay.h and get rid of indentation from labels. Signed-off-by: Krzysztof Kozlowski Acked-by: Vladimir Zapolskiy --- Changes since v1: 1. Add Vladimir's acked-by. --- drivers/crypto/s5p-sss.c | 15 +++ 1 file changed, 7 inser

Re: [PATCH 1/2] crypto: s5p-sss - Minor coding cleanups

2016-03-09 Thread Vladimir Zapolskiy
Hi Krzysztof, On 07.03.2016 06:05, Krzysztof Kozlowski wrote: > On 07.03.2016 10:01, Vladimir Zapolskiy wrote: >> Hi Krzysztof, >> >> On 06.03.2016 12:17, Krzysztof Kozlowski wrote: >>> Remove unneeded inclusion of delay.h and get rid of indentation from >>> labels. >> >> just in case are you awar

Re: [PATCH 1/3] crypto: authenc - add TLS type encryption

2016-03-09 Thread Cristian Stoica
Hi Tadeusz, >> SSL/TLS is prone to this implementation issue and many user-space libraries >> got this wrong. It would be good to see >>some numbers to back-up the claim >> of timing differences as not being an issue for this one. >It is hard to get the implementation right when the protocol de