Re: crypto: algif_skcipher - Require setkey before accept(2)

2015-12-24 Thread Herbert Xu
On Fri, Dec 25, 2015 at 07:54:48AM +0100, Julia Lawall wrote: > Lines 766, 767 don't look correct at all. Thanks Julia. I have sent an updated patch in the original thread. I wonder why I haven't received the original kbuild test robot email though. Cheers, -- Email: Herbert Xu Home Page: http

[PATCH v2] crypto: algif_skcipher - Require setkey before accept(2)

2015-12-24 Thread Herbert Xu
Dmitry Vyukov wrote: > > I am testing with your two patches: > crypto: algif_skcipher - Use new skcipher interface > crypto: algif_skcipher - Require setkey before accept(2) > on top of a88164345b81292b55a8d4829fdd35c8d611cd7d (Dec 23). You sent the email to everyone on the original CC list excep

Re: crypto: algif_skcipher - Require setkey before accept(2)

2015-12-24 Thread Julia Lawall
Herbert, > > [auto build test WARNING on crypto/master] > [also build test WARNING on next-20151223] > [cannot apply to v4.4-rc6] > > url: > https://github.com/0day-ci/linux/commits/Herbert-Xu/crypto-algif_skcipher-Require-setkey-before-accept-2/20151224-174142 > base:

Re: [RFC PATCH 3/5] crypto: sunxi-ss: fix dev_dbg() output type

2015-12-24 Thread Corentin LABBE
Le 22/12/2015 13:27, Andre Przywara a écrit : > The length parameter in this dev_dbg() call is actually a size_t, > so use the proper type to avoid warnings when compiling for 64-bit > architectures. > > Signed-off-by: Andre Przywara > --- > drivers/crypto/sunxi-ss/sun4i-ss-cipher.c | 2 +- > 1

Re: GPF in lrw_crypt

2015-12-24 Thread Dmitry Vyukov
On Thu, Dec 24, 2015 at 10:39 AM, Herbert Xu wrote: > On Thu, Dec 17, 2015 at 01:59:11PM +0100, Dmitry Vyukov wrote: >> >> The following program causes GPF in lrw_crypt: > > OK, this is a result of certain implementations (such as lrw) > not coping with there being no key gracefully. > > I think t

Re: GPF in gf128mul_64k_bbe

2015-12-24 Thread Herbert Xu
On Thu, Dec 17, 2015 at 02:00:23PM +0100, Dmitry Vyukov wrote: > > The following program causes GPF in gf128mul_64k_bbe: This is identical to the lrw_crypt problem you found earlier. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.a

Re: GPF in lrw_crypt

2015-12-24 Thread Herbert Xu
On Thu, Dec 17, 2015 at 01:59:11PM +0100, Dmitry Vyukov wrote: > > The following program causes GPF in lrw_crypt: OK, this is a result of certain implementations (such as lrw) not coping with there being no key gracefully. I think the easiest way is probably to check this in algif_skcipher. ---