Re: bad page state due to PF_ALG socket

2015-12-21 Thread Cong Wang
On Thu, Dec 17, 2015 at 4:58 AM, Dmitry Vyukov wrote: > kasan: GPF could be caused by NULL-ptr deref or user memory access > general protection fault: [#1] SMP KASAN > Modules linked in: > CPU: 3 PID: 7168 Comm: a.out Tainted: GB 4.4.0-rc3+ #151 > Hardware name: QEMU Standard PC

Re: GPF in lrw_crypt

2015-12-21 Thread Stephan Mueller
Am Donnerstag, 17. Dezember 2015, 13:59:11 schrieb Dmitry Vyukov: Hi Dmitry, > Hello, > > The following program causes GPF in lrw_crypt: Here we are: this problem looks very much like the error reprt about a GFP in gf128mul_64_bbe. > > // autogenerated by syzkaller (http://github.com/google/s

Re: GPF in gf128mul_64k_bbe

2015-12-21 Thread Stephan Mueller
Am Montag, 21. Dezember 2015, 23:53:14 schrieb Stephan Mueller: Hi, > Am Donnerstag, 17. Dezember 2015, 14:00:23 schrieb Dmitry Vyukov: > > Hi Dmitry, > > > Hello, > > > The following program causes GPF in gf128mul_64k_bbe: > This looks very much like the issue you reported for lrw_crypt. Oop

Re: GPF in gf128mul_64k_bbe

2015-12-21 Thread Stephan Mueller
Am Donnerstag, 17. Dezember 2015, 14:00:23 schrieb Dmitry Vyukov: Hi Dmitry, > Hello, > > The following program causes GPF in gf128mul_64k_bbe: This looks very much like the issue you reported for lrw_crypt. > > // autogenerated by syzkaller (http://github.com/google/syzkaller) > #include > #

Re: GPF in gf128mul_64k_bbe

2015-12-21 Thread Stephan Mueller
Am Donnerstag, 17. Dezember 2015, 14:00:23 schrieb Dmitry Vyukov: Hi Herbert, After digging a bit here, I find the following: - When using the test app on my system, I get a GPF in twofish, which means that the problem is not tied to a particular cipher implementation. - When analyzing gf128mu

Re: [PATCH] crypto: AF_ALG - add support for keys/asymmetric-type

2015-12-21 Thread Tadeusz Struk
Hi Stephan, On 12/21/2015 01:27 PM, Stephan Mueller wrote: >> @@ -192,7 +194,30 @@ static int alg_setkey(struct sock *sk, char __user >> > *ukey, if (copy_from_user(key, ukey, keylen)) >> >goto out; >> > >> > - err = setkey(ask->private, key, keylen); >> > + if (key_id) { > Wouldn't

Re: use-after-free in skcipher_sock_destruct

2015-12-21 Thread Stephan Mueller
Am Donnerstag, 17. Dezember 2015, 13:56:12 schrieb Dmitry Vyukov: Hi Dmitry, > Hello, > > The following program triggers use-after-free in skcipher_sock_destruct: This issue is not evident after applying Herbert's patch converting the algif_skcipher from using ablkcipher to skcipher API. > >

Re: [PATCH] crypto: AF_ALG - add support for keys/asymmetric-type

2015-12-21 Thread Stephan Mueller
Am Montag, 21. Dezember 2015, 12:51:07 schrieb Tadeusz Struk: Hi Tadeusz, > From: Tadeusz Struk > > Created on top of patchset from Stephan Mueller > https://patchwork.kernel.org/patch/7877921/ > https://patchwork.kernel.org/patch/7877971/ > https://patchwork.kernel.org/patch/7877961/ > > Thi

Re: [PATCH v2 1/2] crypto: KEYS: convert public key to the akcipher api

2015-12-21 Thread Tadeusz Struk
Hi, On 12/19/2015 03:49 PM, kbuild test robot wrote: > Hi Tadeusz, > > [auto build test ERROR on crypto/master] > [also build test ERROR on v4.4-rc5 next-20151218] > > url: > https://github.com/0day-ci/linux/commits/Tadeusz-Struk/crypto-KEYS-convert-public-key-to-akcipher-api/20151213-103429

[PATCH] crypto: AF_ALG - add support for keys/asymmetric-type

2015-12-21 Thread Tadeusz Struk
From: Tadeusz Struk Created on top of patchset from Stephan Mueller https://patchwork.kernel.org/patch/7877921/ https://patchwork.kernel.org/patch/7877971/ https://patchwork.kernel.org/patch/7877961/ This patch adds support for asymmetric key type to AF_ALG. It will work as follows: A new PF_AL

[PATCH] crypto: 842 - remove WARN inside printk

2015-12-21 Thread Dan Streetman
Remove the WARN() from the beN_to_cpu macro, which is used as a param to a pr_debug() call. With a certain kernel config, this printk-in-printk results in the no_printk() macro trying to recursively call the no_printk() macro, and since macros can't recursively call themselves a build error result

[PATCH] Renaming dh895xcc mmp fw

2015-12-21 Thread Atta, Ahsan
Renaming dh895xcc mmp fw Signed-off-by: Ahsan Atta --- .../crypto/qat/qat_dh895xcc/adf_dh895xcc_hw_data.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/crypto/qat/qat_dh895xcc/adf_dh895xcc_hw_data.h b/drivers/crypto/qat/qat_dh895xcc/adf_dh895xcc_hw_data.h ind

Re: [PATCH] Renaming dh895xcc mmp fw

2015-12-21 Thread Greg KH
On Mon, Dec 21, 2015 at 02:36:57PM +, Atta, Ahsan wrote: > Renaming dh895xcc mmp fw > > Signed-off-by: Ahsan Atta > --- > .../crypto/qat/qat_dh895xcc/adf_dh895xcc_hw_data.h |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) This is not the correct way to submit patches for incl

[PATCH] Renaming dh895xcc mmp fw

2015-12-21 Thread Atta, Ahsan
Renaming dh895xcc mmp fw Signed-off-by: Ahsan Atta --- .../crypto/qat/qat_dh895xcc/adf_dh895xcc_hw_data.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/crypto/qat/qat_dh895xcc/adf_dh895xcc_hw_data.h b/drivers/crypto/qat/qat_dh895xcc/adf_dh895xcc_hw_data.h ind