[PATCH v5 3/4] crypto: akcipher: add akcipher declarations needed by templates.

2015-11-26 Thread Andrew Zaborowski
Add a struct akcipher_instance and struct akcipher_spawn similar to how AEAD declares them and the macros for converting to/from crypto_instance/crypto_spawn. Also add register functions to avoid exposing crypto_akcipher_type. Signed-off-by: Andrew Zaborowski --- v2: no changes since v1 v3: drop

[PATCH v5 4/4] crypto: RSA padding algorithm

2015-11-26 Thread Andrew Zaborowski
This patch adds PKCS#1 v1.5 standard RSA padding as a separate template. This way an RSA cipher with padding can be obtained by instantiating "pkcs1pad(rsa)". The reason for adding this is that RSA is almost never used without this padding (or OAEP) so it will be needed for either certificate work

[PATCH] hw_random: core, sleep interruptible in read

2015-11-26 Thread Jiri Slaby
hwrng kthread can be waiting via hwrng_fillfn for some data from a rng like virtio-rng: hwrng D 880093e17798 0 382 2 0x ... Call Trace: [] wait_for_completion_killable+0x96/0x210 [] virtio_read+0x57/0xf0 [virtio_rng] [] hwrng_fillfn+0x75/0x130 [] kthread+0xf3/0x

[PATCH] crypto: mxs-dcp - Initialize .statesize fields

2015-11-26 Thread Fabio Estevam
Initialize .statesize fields in order to avoid the following error on probe: mxs-dcp 80028000.dcp: Failed to register sha1 hash! mxs-dcp: probe of 80028000.dcp failed with error -22 Cc: # 4.1+ Suggested-by: Stephan Mueller Signed-off-by: Fabio Estevam --- drivers/crypto/mxs-dcp.c | 2 ++ 1 fi

ahash and halg.statesize

2015-11-26 Thread Stephan Mueller
Hi Herbert, after Fabio's confirmation on the mxs-dcp ahash implementations, I briefly looked for the invocation of crypto_register_ahash and found numerous invocations. After taking two examples (sahara, n2), I did not find halg.statesize. Thus, I would conclude that none of these ciphers wou

Re: mxs-dcp: Failed to register sha1 hash

2015-11-26 Thread Marek Vasut
On Thursday, November 26, 2015 at 04:38:01 PM, Fabio Estevam wrote: > Hi Stephan, > > On Thu, Nov 26, 2015 at 1:25 PM, Stephan Mueller wrote: > > Briefly looking into drivers/crypto/mxs-dcp.c, it is an ahash and does > > not contain halg.statesize in the algo definitions. Thus it looks very > > m

Re: mxs-dcp: Failed to register sha1 hash

2015-11-26 Thread Fabio Estevam
Hi Stephan, On Thu, Nov 26, 2015 at 1:25 PM, Stephan Mueller wrote: > Briefly looking into drivers/crypto/mxs-dcp.c, it is an ahash and does not > contain halg.statesize in the algo definitions. Thus it looks very much like > the same issue that I see with ghash. Thanks for your suggestion! Yo

Re: mxs-dcp: Failed to register sha1 hash

2015-11-26 Thread Stephan Mueller
Am Donnerstag, 26. November 2015, 13:14:12 schrieb Fabio Estevam: Hi Fabio, > Hi, > > On kernel 4.1.13 and also on 4.4.0-rc2-next-20151126 I see the > following error on mx28: > > [2.245453] mxs-dcp 80028000.dcp: Failed to register sha1 hash! > [2.253928] mxs-dcp:

mxs-dcp: Failed to register sha1 hash

2015-11-26 Thread Fabio Estevam
Hi, On kernel 4.1.13 and also on 4.4.0-rc2-next-20151126 I see the following error on mx28: [2.245453] mxs-dcp 80028000.dcp: Failed to register sha1 hash! [2.253928] mxs-dcp: probe of 80028000.dcp failed with error -22 Does anyone have any idea how to fix this? Thanks, Fabio Estevam

Re: ghash-clmulni: does not load

2015-11-26 Thread Stephan Mueller
Am Donnerstag, 26. November 2015, 13:45:26 schrieb Stephan Mueller: Hi, >Hi Tadeusz, > >testing the current cryptodev-2.6 tree, ghash-clmulni does not load. In the >init function > > err = crypto_register_ahash(&ghash_async_alg); > >returns EINVAL. It looks like the halg.statesize is missi

ghash-clmulni: does not load

2015-11-26 Thread Stephan Mueller
Hi Tadeusz, testing the current cryptodev-2.6 tree, ghash-clmulni does not load. In the init function err = crypto_register_ahash(&ghash_async_alg); returns EINVAL. Any ideas? -- Ciao Stephan -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a

Re: [PATCH v4 4/4] crypto: RSA padding algorithm

2015-11-26 Thread Herbert Xu
Andrew Zaborowski wrote: > > +struct crypto_template rsa_pkcs1pad_tmpl = { > + .name = "pkcs1pad", > + .create = pkcs1pad_create, > + .free = pkcs1pad_free, Please use inst->free instead (crypto/gcm.c is a good example). BTW the first two patches are fine so you don't have to p

Re: [PATCH v3 5/5] crypto: AES CBC multi-buffer glue code

2015-11-26 Thread Herbert Xu
On Tue, Nov 24, 2015 at 10:30:06AM -0800, Tim Chen wrote: > > On the decrypt path, we don't need to use multi-buffer algorithm > as aes-cbc decrypt can be parallelized inherently on a single > request. So most of the time the outer layer algorithm > cbc_mb_async_ablk_decrypt can bypass mcryptd and