Re: [PATCH v2] crypto/caam: add backlogging support

2015-09-23 Thread Herbert Xu
On Wed, Sep 23, 2015 at 02:40:32PM +, Porosanu Alexandru wrote: > > Yes, you are absolutely right. In this case, I have some reasons why I > wouldn't like to use a crypto_queue based approach: > > 1) we've prototyped a crypto_queue implementation which did not reach the > performance expect

[PATCH 2/2] crytpo: rsa - use mpi slg helpers to import and export data

2015-09-23 Thread Tadeusz Struk
Use the new mpi_write_to_sgl and mpi_read_raw_from_sgl helpers to import and export data. Signed-off-by: Tadeusz Struk --- crypto/rsa.c | 127 +- 1 file changed, 12 insertions(+), 115 deletions(-) diff --git a/crypto/rsa.c b/crypto/rsa.c

[PATCH 1/2] lib/mpi: Add mpi sgl helpers

2015-09-23 Thread Tadeusz Struk
Add mpi_read_raw_from_sgl and mpi_write_to_sgl helpers. Signed-off-by: Tadeusz Struk --- include/linux/mpi.h |4 + lib/mpi/mpicoder.c | 189 +++ 2 files changed, 193 insertions(+) diff --git a/include/linux/mpi.h b/include/linux/mpi.h index

[PATCH 0/2] crytpo: rsa - use mpi sgl helpers

2015-09-23 Thread Tadeusz Struk
This series introduces new mpi helpers to read from and write to an sgl without a need of using an intermediate flat buffer. First patch adds helpers to mpi library. Second patch changes rsa implementation to use the new functions. This is an incremental patch series on top of these two: https://

Re: [PATCH 2/4] crypto: qce: dma_map_sg can handle chained SG

2015-09-23 Thread Stanimir Varbanov
Hi, On 09/23/2015 02:55 PM, LABBE Corentin wrote: > The qce driver use two dma_map_sg path according to SG are chained > or not. > Since dma_map_sg can handle both case, clean the code with all > references to sg chained. > > Thus removing qce_mapsg, qce_unmapsg and qce_countsg functions. > > Si

RE: [PATCH v2] crypto/caam: add backlogging support

2015-09-23 Thread Porosanu Alexandru
Hi Herbert, > -Original Message- > From: Herbert Xu [mailto:herb...@gondor.apana.org.au] > Sent: Wednesday, September 23, 2015 3:02 PM > To: Porosanu Alexandru-B06830 > Cc: linux-crypto@vger.kernel.org; Geanta Neag Horia Ioan-B05471 > ; Pop Mircea-R19439 > > Subject: Re: [PATCH v2] crypt

Re: [PATCH 1/4] crypto: talitos: dma_map_sg can handle chained SG

2015-09-23 Thread Christophe Leroy
Le 23/09/2015 13:55, LABBE Corentin a écrit : The talitos driver use two dma_map_sg path according to SG are chained or not. Since dma_map_sg can handle both case, clean the code with all references to sg chained. Thus removing talitos_map_sg, talitos_unmap_sg_chain and sg_count functions. Sh

Re: [PATCH v2] crypto/caam: add backlogging support

2015-09-23 Thread Herbert Xu
On Fri, Sep 18, 2015 at 02:27:12PM +, Porosanu Alexandru wrote: > > Well, the HW has less than the whole RAM for backlogging requests, it has the > # of available backlogging requests slots. > Then it will start dropping, just like in the out-of-mem case. OK I think that's where our misunder

[PATCH 4/4] crypto: sahara: dma_map_sg can handle chained SG

2015-09-23 Thread LABBE Corentin
The sahara driver use two dma_map_sg path according to SG are chained or not. Since dma_map_sg can handle both case, clean the code with all references to sg chained. Thus removing the sahara_sha_unmap_sg function. Signed-off-by: LABBE Corentin --- drivers/crypto/sahara.c | 66 ++---

[PATCH 3/4] crypto: caam: dma_map_sg can handle chained SG

2015-09-23 Thread LABBE Corentin
The caam driver use two dma_map_sg path according to SG are chained or not. Since dma_map_sg can handle both case, clean the code with all references to sg chained. Thus removing dma_map_sg_chained, dma_unmap_sg_chained and __sg_count functions. Signed-off-by: LABBE Corentin --- drivers/crypto/

[PATCH 2/4] crypto: qce: dma_map_sg can handle chained SG

2015-09-23 Thread LABBE Corentin
The qce driver use two dma_map_sg path according to SG are chained or not. Since dma_map_sg can handle both case, clean the code with all references to sg chained. Thus removing qce_mapsg, qce_unmapsg and qce_countsg functions. Signed-off-by: LABBE Corentin --- drivers/crypto/qce/ablkcipher.c |

[PATCH 1/4] crypto: talitos: dma_map_sg can handle chained SG

2015-09-23 Thread LABBE Corentin
The talitos driver use two dma_map_sg path according to SG are chained or not. Since dma_map_sg can handle both case, clean the code with all references to sg chained. Thus removing talitos_map_sg, talitos_unmap_sg_chain and sg_count functions. Signed-off-by: LABBE Corentin --- drivers/crypto/t

[PATCH] crypto: dma_map_sg can handle chained SG

2015-09-23 Thread LABBE Corentin
Hello Some drivers use two dma_map_sg path according to SG are chained or not. Since dma_map_sg can handle both case, this patch series clean all code with references to sg chained. Note that I could only compile test sahara and caam patch. And none could be tested due to lack oh hardware. Rega

Re: [PATCH] drivers/crypto/nx: Add CRC and validation support for nx842

2015-09-23 Thread Herbert Xu
On Tue, Sep 22, 2015 at 11:08:22AM -0400, Dan Streetman wrote: > > you think we should just strip out the 842-nx alignment/sizing code > and change it to fallback to the sw driver? Right, if the only intended user can provide aligned input then by all means make the unaligned case use the software