On Tue, Sep 08, 2015 at 05:23:59AM +0200, Stephan Mueller wrote:
> Am Dienstag, 16. Juni 2015, 11:46:46 schrieb Boris Brezillon:
>
> Hi Herbert,
>
> >The crypto drivers are supposed to update the IV passed to the crypto
> >request before calling the completion callback.
> >Test for the IV value b
Am Dienstag, 16. Juni 2015, 11:46:46 schrieb Boris Brezillon:
Hi Herbert,
>The crypto drivers are supposed to update the IV passed to the crypto
>request before calling the completion callback.
>Test for the IV value before considering the test as successful.
May I ask whether there is anything
Tadeusz Struk wrote:
>
> The more I think about the sgl support the more it looks to me like it wasn't
> a good idea. It will be copied into a flat buffer somewhere along the way
> anyway.
> Like in the example below.
>
> I have that conversion already done, and for SW it looks like the data is
Am Montag, 7. September 2015, 15:07:47 schrieb Mike Mestnik:
Hi Mike,
>This is just an off the wall guess. Wouldn't such entropy already be
>collected at a lower level, like raw usb traffic?
The RNG collects data from interrupts (that also covers normal PS/2 mice and
keyboards), block devices
This is just an off the wall guess. Wouldn't such entropy already be
collected at a lower level, like raw usb traffic?
On Sun, Sep 6, 2015 at 7:12 PM, Stephan Mueller wrote:
> Am Montag, 7. September 2015, 02:10:16 schrieb Stephan Mueller:
>
> Hi Stephan,
>
>> Hi,
>>
>> While analyzing the entro
Am Montag, 7. September 2015, 07:31:56 schrieb Tadeusz Struk:
Hi Tadeusz,
>On 09/06/2015 07:33 AM, Andrzej Zaborowski wrote:
>> Probably yes, I also read about the decision to use iov buffers, this
>> will have a bigger effect on code.
>
>The more I think about the sgl support the more it looks t
Am Montag, 7. September 2015, 16:42:42 schrieb Andrzej Zaborowski:
Hi Andrzej,
>
>Specifically I use 1 + prandom_u32_max(255) which should give me
>numbers > 0 although it can't be perfectly uniform.
Oh, now I see. Thanks for the clarification. And yes, per definition the
values cannot be unifor
Am Montag, 7. September 2015, 07:11:24 schrieb Tadeusz Struk:
Hi Tadeusz,
>On 09/06/2015 01:34 AM, Stephan Mueller wrote:
>>> +static int pkcs1pad_setkey(struct crypto_akcipher *tfm, const void *key,
>>>
>>> > + unsigned int keylen)
>>
>> Albeit I have nothing to say against the code, b
On 6 September 2015 at 23:17, Stephan Mueller wrote:
> Am Sonntag, 6. September 2015, 16:33:26 schrieb Andrzej Zaborowski:
>
> Hi Andrzej,
>
+ for (pos = 2; pos < child_req->dst_len; pos++)
+ if (dst[pos] == 0x00)
+ break;
>>>
>>> What happens if
Hi Tadeusz,
On 7 September 2015 at 16:06, Tadeusz Struk wrote:
> Hi Andrew,
> On 09/05/2015 04:00 PM, Andrew Zaborowski wrote:
>> +static int crypto_akcipher_init(struct crypto_tfm *tfm, u32 type, u32 mask)
>> +{
>> + return 0;
>> +}
>> +
>
> This is not needed I think.
To create the padding
On 09/06/2015 07:33 AM, Andrzej Zaborowski wrote:
> Probably yes, I also read about the decision to use iov buffers, this
> will have a bigger effect on code.
The more I think about the sgl support the more it looks to me like it wasn't
a good idea. It will be copied into a flat buffer somewhere a
On 09/06/2015 01:34 AM, Stephan Mueller wrote:
>> +static int pkcs1pad_setkey(struct crypto_akcipher *tfm, const void *key,
>> > + unsigned int keylen)
> Albeit I have nothing to say against the code, but shouldn't we first get the
> split of the setkey function implemented? The conversio
Hi Andrew,
On 09/05/2015 04:00 PM, Andrew Zaborowski wrote:
> +static int crypto_akcipher_init(struct crypto_tfm *tfm, u32 type, u32 mask)
> +{
> + return 0;
> +}
> +
This is not needed I think.
>
> +static int pkcs1pad_decrypt_complete(struct akcipher_request *req, int err)
> +{
> + str
Herbert Xu wrote:
> > I am not in favor of just hacking in this split until the semantics are
> > actually understood. As said, the right solution from my point of view is
> > to remove setkey from akcipher and replace it with setkeyid instead.
>
> It's the keys system that should not be decodin
14 matches
Mail list logo
