Re: [PATCH] cleanups for crypto/wp512.c

2015-07-24 Thread Herbert Xu
On Fri, Jul 24, 2015 at 06:50:15PM +0200, Ahmed Mohamed Abd EL Mawgood wrote: > > fixing all errors and warning of checkpatch.pl for > crypto/wp512.c > Signed-off-by: Ahmed Mohamed Nack. Please do not generate patches purely based on checkpatch. Thanks, -- Email: Herbert Xu Home Page: http:/

Re: [PATCH] code cleanups for crypto/blkcipher.c

2015-07-24 Thread Herbert Xu
On Fri, Jul 24, 2015 at 04:04:32PM +0200, Ahmed Mohamed Abd EL Mawgood wrote: > > @@ -68,6 +68,7 @@ static inline void blkcipher_unmap_dst(struct > blkcipher_walk *walk) > static inline u8 *blkcipher_get_spot(u8 *start, unsigned int len) > { > u8 *end_page = (u8 *)(((unsigned long)(start +

Re: [PATCH RFC 06/11] crypto: caam - Enable MXC devices to select CAAM driver in Kconfig

2015-07-24 Thread Herbert Xu
On Fri, Jul 24, 2015 at 08:14:31PM +0300, Horia Geantă wrote: > > Even more, not all SOC_IMX6 variants have a CAAM block. > > Not sure what's better: > -try to exactly indicate the HW that has the IP > -only name the arch / SoC (provided compilation passes), and then depend > on defconfig and/or d

[PATCH] jent: use safe format string parameters

2015-07-24 Thread Kees Cook
Since the API for jent_panic() does not include format string parameters, adjust the call to panic() to use a literal string to avoid any future callers from leaking format strings into the panic message. Signed-off-by: Kees Cook --- crypto/jitterentropy-kcapi.c | 2 +- 1 file changed, 1 inserti

[PATCH] crypto: qat - remove unused define

2015-07-24 Thread Tadeusz Struk
From: Bruce Allan Signed-off-by: Bruce Allan Signed-off-by: Tadeusz Struk --- drivers/crypto/qat/qat_common/qat_hal.c |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/crypto/qat/qat_common/qat_hal.c b/drivers/crypto/qat/qat_common/qat_hal.c index 1d6d289..8e711d1 100644 --- a/dri

[PATCH] crypto: qat - remove redundant struct elem

2015-07-24 Thread Tadeusz Struk
From: Bruce Allan The element pci_dev_id in the struct adf_hw_device_data is redundant since the PCI device id can be retrieved from the struct pci_dev. Signed-off-by: Bruce Allan Signed-off-by: Tadeusz Struk --- drivers/crypto/qat/qat_common/adf_accel_devices.h |1 - .../crypto/qat/qat_

[PATCH] crypto: qat - fix bug in ADF_RING_SIZE_BYTES_MIN macro

2015-07-24 Thread Tadeusz Struk
From: Bruce Allan The subject macro mistakenly compares the passed-in ring size in bytes with ADF_RING_SIZE_4K which is 0x6 (an internal representation of 4KB) rather than comparing with the intended value of 4096. Signed-off-by: Bruce Allan Signed-off-by: Tadeusz Struk --- .../qat/qat_common

[PATCH] crypto: qat Fix typo othewise->otherwise

2015-07-24 Thread Tadeusz Struk
From: Ahsan Atta Signed-off-by: Ahsan Atta Signed-off-by: Tadeusz Struk --- drivers/crypto/qat/qat_common/adf_aer.c |2 +- drivers/crypto/qat/qat_common/adf_cfg.c |6 +++--- drivers/crypto/qat/qat_common/adf_dev_mgr.c |2 +- drivers/crypto/qat/qat_common/adf_init.c

FROM MR. MARTIN IBANEZ

2015-07-24 Thread MR. MARTIN IBANEZ
PLEASE VIEW THE ATTACHED FILE MR. MARTIN IBANEZ.pdf Description: Adobe PDF document

Re: [PATCH RFC 06/11] crypto: caam - Enable MXC devices to select CAAM driver in Kconfig

2015-07-24 Thread Horia Geantă
On 6/17/2015 10:27 AM, Steffen Trumtrar wrote: > On Mon, Jun 15, 2015 at 04:52:54PM -0700, Victoria Milhoan wrote: >> From: Steve Cornelius >> >> Allow CAAM to be selected in the kernel for Freescale i.MX6 devices if >> ARCH_MXC is enabled. >> >> Signed-off-by: Steve Cornelius >> Signed-off-by: V

[PATCH] cleanups for crypto/wp512.c

2015-07-24 Thread Ahmed Mohamed Abd EL Mawgood
fixing all errors and warning of checkpatch.pl for crypto/wp512.c Signed-off-by: Ahmed Mohamed --- crypto/wp512.c | 120 - 1 file changed, 60 insertions(+), 60 deletions(-) diff --git a/crypto/wp512.c b/crypto/wp512.c index 7ee5a04..8a2696

[PATCH] code cleanups for crypto/blkcipher.c

2015-07-24 Thread Ahmed Mohamed Abd EL Mawgood
fixing all errors and most warning of checkpatch.pl for crypto/blkcipher.c Signed-off-by: Ahmed Mohamed --- crypto/blkcipher.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/crypto/blkcipher.c b/crypto/blkcipher.c index 11b9814..4530ff9 100644 --- a/crypto/blkcip

[PATCH] hwrng: correct error check of kthread_run call

2015-07-24 Thread Martin Schwidefsky
The kthread_run() function can return two different error values but the hwrng core only checks for -ENOMEM. If the other error value -EINTR is returned it is assigned to hwrng_fill and later used on a kthread_stop() call which naturally crashes. Signed-off-by: Martin Schwidefsky --- drivers/cha

Re: [PATCH v11] crypto: Add Allwinner Security System crypto accelerator

2015-07-24 Thread Maxime Ripard
On Tue, Jul 21, 2015 at 08:50:14PM +0800, Herbert Xu wrote: > On Tue, Jul 21, 2015 at 02:38:47PM +0200, Maxime Ripard wrote: > > I thought you needed at least my Acked-by for that, but > > whatever... How are we supposed to handle subsequent DT patches that > > should be merged through arm-soc then