Le 26/03/2015 19:31, Boris Brezillon a écrit :
> Hi Corentin,
>
> Here is a quick review, there surely are a lot of other things I didn't
> spot.
>
> On Mon, 16 Mar 2015 20:01:22 +0100
> LABBE Corentin wrote:
>
>> Add support for the Security System included in Allwinner SoC A20.
>> The Securit
On 04/02/15 04:10, kevin.z.m...@gmail.com wrote:
>> Thanks for your answer, I have loose hours on that problem.
> I'm sorry to hear that.
>
>> Perhaps you could update all datasheet/user manual about this known issue ?
> We have updated the user manual and datasheet, the latest version is 1.3 for
A cipher instance is added to the list of instances unconditionally
regardless of whether the associated test failed. However, a failed
test implies that during another lookup, the cipher instance will
be added to the list again as it will not be found by the lookup
code.
That means that the list
On Thu, Apr 02, 2015 at 05:13:23PM +0200, Stephan Mueller wrote:
>
> In crypto_remove_instance, the code dereferences inst->tmpl. If you say that
> it is not guaranteed that the alg is always wrapped by an inst, wouldn't we
> have a potential invalid pointer?
This particular spot is always an in
Am Donnerstag, 2. April 2015, 22:59:11 schrieb Herbert Xu:
Hi Herbert,
>On Thu, Apr 02, 2015 at 04:54:03PM +0200, Stephan Mueller wrote:
>> >@@ -316,7 +316,7 @@ static int crypto_del_alg(struct sk_buff *skb, struct
>> >nlmsghdr *nlh, if (atomic_read(&alg->cra_refcnt) != 1)
>> >
>> >re
On Thu, Apr 02, 2015 at 04:54:03PM +0200, Stephan Mueller wrote:
>
> >@@ -316,7 +316,7 @@ static int crypto_del_alg(struct sk_buff *skb, struct
> >nlmsghdr *nlh, if (atomic_read(&alg->cra_refcnt) != 1)
> > return -EBUSY;
> >
> >-return crypto_unregister_instance(alg);
> >+return
Am Donnerstag, 2. April 2015, 22:39:40 schrieb Herbert Xu:
Hi Herbert,
>This patch makes crypto_unregister_instance take a crypto_instance
>instead of a crypto_alg. This allows us to remove a duplicate
>CRYPTO_ALG_INSTANCE check in crypto_unregister_instance.
>
>Signed-off-by: Herbert Xu
>
>dif
On Sun, Mar 29, 2015 at 04:26:40PM +0200, Stephan Mueller wrote:
> A cipher instance is added to the list of instances unconditionally
> regardless of whether the associated test failed. However, a failed
> test implies that during another lookup, the cipher instance will
> be added to the list aga
This patch makes crypto_unregister_instance take a crypto_instance
instead of a crypto_alg. This allows us to remove a duplicate
CRYPTO_ALG_INSTANCE check in crypto_unregister_instance.
Signed-off-by: Herbert Xu
diff --git a/crypto/algapi.c b/crypto/algapi.c
index 0f1976e..f1d0307 100644
--- a/
There are multiple problems in crypto_unregister_instance:
1) The cra_refcnt BUG_ON check is racy and can cause crashes.
2) The cra_refcnt check shouldn't exist at all.
3) There is no reference on tmpl to protect the tmpl->free call.
This patch rewrites the function using crypto_remove_spawn whic
kmap_atomic() gives only the page address of the input page.
Driver should take care of adding the offset of the scatterlist
within the page to the returned page address.
omap-sham driver is not adding the offset to page and directly operates
on the return vale of kmap_atomic(), because of which th
Hi Herbert,
On Wednesday 01 April 2015 07:48 PM, Herbert Xu wrote:
> On Tue, Mar 31, 2015 at 09:52:23AM +0530, Lokesh Vutla wrote:
>> Commit 26a05489ee0e ("crypto: omap-sham - Map SG pages if they are HIGHMEM
>> before accessing")
>> says that HIGHMEM pages may not be mapped so we must
>> kmap the
12 matches
Mail list logo
