Re: [PATCH] ARM: crypto: update NEON AES module to latest OpenSSL version

2015-02-28 Thread Milan Broz
On 02/26/2015 08:22 AM, Ard Biesheuvel wrote: > This updates the bit sliced AES module to the latest version in the > upstream OpenSSL repository (e620e5ae37bc). This is needed to fix a > bug in the XTS decryption path, where data chunked in a certain way > could trigger the ciphertext stealing cod

[PATCH] crypto: fix typo in dev_err error message

2015-02-28 Thread Colin King
From: Colin Ian King Fix typo, "intialization" -> "initialization" Signed-off-by: Colin Ian King --- drivers/crypto/atmel-aes.c | 2 +- drivers/crypto/atmel-sha.c | 2 +- drivers/crypto/atmel-tdes.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/crypto/atmel-a

[PATCH v13 1/2] crypto: AF_ALG: add AEAD support

2015-02-28 Thread Stephan Mueller
This patch adds the AEAD support for AF_ALG. The implementation is based on algif_skcipher, but contains heavy modifications to streamline the interface for AEAD uses. To use AEAD, the user space consumer has to use the salg_type named "aead". The AEAD implementation includes some overhead to ca

[PATCH v13 0/2] crypto: AF_ALG: add AEAD support

2015-02-28 Thread Stephan Mueller
Hi, This patch set adds AEAD support to the AF_ALG interface exported by the kernel crypto API. The AEAD implementation uses the same approach as provided with skcipher by offering the following interfaces: * sendmsg and recvmsg interfaces allowing multiple invocations supporti

[PATCH v13 2/2] crypto: AF_ALG: enable AEAD interface compilation

2015-02-28 Thread Stephan Mueller
Enable compilation of the AEAD AF_ALG support and provide a Kconfig option to compile the AEAD AF_ALG support. Signed-off-by: Stephan Mueller --- crypto/Kconfig | 9 + crypto/Makefile | 1 + 2 files changed, 10 insertions(+) diff --git a/crypto/Kconfig b/crypto/Kconfig index 2ca8d15..f

Re: [PATCH 05/10] ARM: dts: omap3 hs: Remove timer12

2015-02-28 Thread Pavel Machek
On Thu 2015-02-26 14:49:55, Pali Rohár wrote: > Device timer12 is automatically disabled on all HS devices via DTS property > "ti,timer-secure" in file omap3.dtsi so it can be safely removed. We do not > need to disable it on another place. Dunno. Theoretically, Linux is not the only user of dts..

Re: [PATCH 06/10] ARM: dts: omap3: Add missing dmas for crypto

2015-02-28 Thread Pavel Machek
On Thu 2015-02-26 14:49:56, Pali Rohár wrote: > This patch adds missing dma DTS definitions for omap aes and sham drivers. > Without it kernel drivers do not work. > > Signed-off-by: Pali Rohár Acked-by: Pavel Machek -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) htt

Re: [PATCH 10/10] ARM: dts: Remove files omap34xx-hs.dtsi and omap36xx-hs.dtsi

2015-02-28 Thread Pavel Machek
On Thu 2015-02-26 14:50:00, Pali Rohár wrote: > These files are not used by any DTS file anymore. > > Signed-off-by: Pali Rohár Acked-by: Pavel Machek > --- > arch/arm/boot/dts/omap34xx-hs.dtsi | 12 > arch/arm/boot/dts/omap36xx-hs.dtsi | 12 > 2 files changed,

Re: [PATCH 09/10] ARM: dts: omap3-tao3530: Include directly omap34xx.dtsi

2015-02-28 Thread Pavel Machek
On Thu 2015-02-26 14:49:59, Pali Rohár wrote: > This patch just move content of file omap34xx-hs.dtsi into omap3-tao3530.dts. > There is no code change, patch is just preparation for removing -hs file. > > Signed-off-by: Pali Rohár Acked-by: Pavel Machek > --- a/arch/arm/boot/dts/omap3-tao3530

Re: [PATCH 08/10] ARM: dts: n900: Enable omap sham and include directly omap34xx.dtsi

2015-02-28 Thread Pavel Machek
On Thu 2015-02-26 14:49:58, Pali Rohár wrote: > This patch moves content of file omap34xx-hs.dtsi into omap3-n900.dts and > enable > omap sham support (omap HW support for SHA + MD5). After testing both omap > hwmod > and omap-sham.ko drivers it looks like signed Nokia X-Loader enable L3 > firew

Re: [PATCH 07/10] ARM: dts: n9/n950: Enable omap crypto support

2015-02-28 Thread Pavel Machek
On Thu 2015-02-26 14:49:57, Pali Rohár wrote: > Harmattan system on Nokia N9 and N950 devices uses omap crypto support. > Bootloader on those devices is known that it enables HW crypto support. > This patch just include omap36xx.dtsi directly, so aes and sham is enabled. > > Signed-off-by: Pali Ro

Re: [PATCH 04/10] crypto: omap-sham: Check for return value from pm_runtime_get_sync

2015-02-28 Thread Pavel Machek
On Thu 2015-02-26 14:49:54, Pali Rohár wrote: > Function pm_runtime_get_sync could fail and we need to check return > value to prevent kernel crash. > > Signed-off-by: Pali Rohár Acked-by: Pavel Machek -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin

Re: [PATCH 02/10] ARM: OMAP3: Fix crypto support for HS devices

2015-02-28 Thread Pavel Machek
On Thu 2015-02-26 14:49:52, Pali Rohár wrote: > Register crypto hwmod links only if they are not disabled in DT. > If DT information is missing, enable them only for GP devices. > > Before this patch crypto hwmod links were always disabled for all HS devices > and it was not possible to use omap-a

Re: [PATCH 03/10] crypto: omap-sham: Add support for omap3 devices

2015-02-28 Thread Pavel Machek
On Thu 2015-02-26 14:49:53, Pali Rohár wrote: > omap3 support is same as omap2, just with different IO address (specified in > DT) > > Signed-off-by: Pali Rohár Acked-by: Pavel Machek > @@ -1792,6 +1792,10 @@ static const struct of_device_id omap_sham_of_match[] > = { > .data

Re: GCM / seqiv and SP800-38D

2015-02-28 Thread Stephan Mueller
Am Samstag, 28. Februar 2015, 23:47:12 schrieb Herbert Xu: Hi Herbert, > On Thu, Feb 19, 2015 at 07:56:48AM +0100, Stephan Mueller wrote: > > In case of rfc4106(gcm(aes)), the IV is 96 bits. Thus, our constructed > > > IV looks like: > The IV to rfc4106 is 96 bits, but the IV to the underlying g

Re: GCM / seqiv and SP800-38D

2015-02-28 Thread Herbert Xu
On Thu, Feb 19, 2015 at 07:56:48AM +0100, Stephan Mueller wrote: > > In case of rfc4106(gcm(aes)), the IV is 96 bits. Thus, our constructed > IV looks like: The IV to rfc4106 is 96 bits, but the IV to the underlying gcm is 128 bits so that's what guarantees the uniqueness. Cheers, -- Email: Her

Re: crypto: aesni - make driver-gcm-aes-aesni helper a proper aead alg

2015-02-28 Thread Herbert Xu
On Fri, Feb 06, 2015 at 10:25:20AM -0800, Tadeusz Struk wrote: > Changed the __driver-gcm-aes-aesni to be a proper aead algorithm. > This required a valid setkey and setauthsize functions to be added and also > some changes to make sure that math context is not corrupted when the alg is > used dire

Re: crypto: mxs-dcp - fix type of ret for wait_for_completion_timeout

2015-02-28 Thread Herbert Xu
On Sat, Feb 07, 2015 at 03:09:41AM -0500, Nicholas Mc Guire wrote: > return type of wait_for_completion_timeout is unsigned long not int, this > patch changes the type of ret from int to unsigned long. > > Signed-off-by: Nicholas Mc Guire All four patches applied. -- Email: Herbert Xu Home Pag

Re: [PATCHv2 0/7] Add VMX module for PPC64

2015-02-28 Thread Herbert Xu
On Fri, Feb 06, 2015 at 02:54:55PM -0200, Leonidas S. Barbosa wrote: > VMX cryptographic acceleration instructions were added to the POWER8 > CPU. These instructions implement portions of AES and GHASH in hardware. > > This patch set adds a new module for PPC64, vmx, that support > cryptographic r

Re: [PATCH] crypto: tcrypt speed: fix filter for aead algorithms

2015-02-28 Thread Herbert Xu
On Fri, Feb 27, 2015 at 01:14:20PM +0200, Cristian Stoica wrote: > Hi Herbert, > > On 02/27/2015 11:25 AM, Herbert Xu wrote: > > On Tue, Feb 03, 2015 at 03:59:48PM +0200, Cristian Stoica wrote: > >> test_aead_speed is written for sync algorithms without specifically > [...] > > Please fix it to te