Re: [PATCH 3/5] hwrng: core - Do not register device opportunistically

On Wed, Dec 24, 2014 at 09:59:41AM +1030, Rusty Russell wrote: > > Does this break userspace by creating a device which will just return > -ENODEV on read? Sure, callers *should* handle it... If somebody complains we could easily fix this by making open fail. In fact, if such applications exist

Re: [PATCH 2/5] hwrng: core - Fix current_rng init/cleanup race yet again

On Wed, Dec 24, 2014 at 09:56:36AM +1030, Rusty Russell wrote: > > I'll have to pull the tree to review it properly, but the theory was > that the reference count was counting users of the rng. Now I don't > know what it's counting: The reference count starts off at zero, meaning that the RNG has

Re: [PATCH 1/5] hwrng: core - Use struct completion for cleanup_done

Herbert Xu writes: > There is no point in doing a manual completion for cleanup_done > when struct completion fits in perfectly. > > Signed-off-by: Herbert Xu Indeed. Acked-by: Rusty Russell Thanks, Rusty. > --- > > drivers/char/hw_random/core.c | 12 +++- > include/linux/hw_rando

Re: [PATCH 2/5] hwrng: core - Fix current_rng init/cleanup race yet again

Herbert Xu writes: > The kref solution is still buggy because we were only focusing > on the register/unregister race. The same race affects the > setting of current_rng through sysfs. > > This patch fixes it by using kref_get_unless_zero. > > Signed-off-by: Herbert Xu This patch scares me a li

Re: [PATCH 3/5] hwrng: core - Do not register device opportunistically

Herbert Xu writes: > Currently we only register the device when a valid RNG is added. > However the way it's done is buggy because we test whether there > is a current RNG to determine whether we need to register. As > the current RNG may be missing due to a reinitialisation error > this can lead

Re: [PATCH] crypto: AF_ALG: zeroize key data

On Tue, Dec 23, 2014 at 09:34:03AM +0100, Stephan Mueller wrote: > alg_setkey should zeroize the sensitive data after use. > > Signed-off-by: Stephan Mueller Patch applied. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.

Re: algif_hash: splice of data > 2**16

Am Mittwoch, 24. Dezember 2014, 16:12:53 schrieb Stephan Mueller: Hi Christophe, > Am Mittwoch, 24. Dezember 2014, 15:10:14 schrieb leroy christophe: > > Hi leroy, > > > Le 24/12/2014 10:03, Stephan Mueller a écrit : > > > Am Dienstag, 23. Dezember 2014, 18:16:01 schrieb leroy christophe: > > >

[PATCH v6 2/4] crypto: AF_ALG: enable AEAD interface compilation

Enable compilation of the AEAD AF_ALG support and provide a Kconfig option to compile the AEAD AF_ALG support. Signed-off-by: Stephan Mueller --- crypto/Kconfig | 9 + crypto/Makefile | 1 + 2 files changed, 10 insertions(+) diff --git a/crypto/Kconfig b/crypto/Kconfig index 1618468..c

[PATCH v6 0/4] crypto: AF_ALG: add AEAD and RNG support

Hi, This patch set adds AEAD and RNG support to the AF_ALG interface exported by the kernel crypto API. By extending AF_ALG with AEAD and RNG support, all cipher types the kernel crypto API allows access to are now accessible from userspace. Both, AEAD and RNG implementations are stand-alone and

[PATCH v6 3/4] crypto: AF_ALG: add random number generator support

This patch adds the random number generator support for AF_ALG. A random number generator's purpose is to generate data without requiring the caller to provide any data. Therefore, the AF_ALG interface handler for RNGs only implements a callback handler for recvmsg. The following parameters provi

[PATCH v6 1/4] crypto: AF_ALG: add AEAD support

This patch adds the AEAD support for AF_ALG. The implementation is based on algif_skcipher, but contains heavy modifications to streamline the interface for AEAD uses. To use AEAD, the user space consumer has to use the salg_type named "aead". The AEAD implementation includes some overhead to ca

[PATCH v6 4/4] crypto: AF_ALG: enable RNG interface compilation

Enable compilation of the RNG AF_ALG support and provide a Kconfig option to compile the RNG AF_ALG support. Signed-off-by: Stephan Mueller --- crypto/Kconfig | 9 + crypto/Makefile | 1 + 2 files changed, 10 insertions(+) diff --git a/crypto/Kconfig b/crypto/Kconfig index cd3e6fd..f2d

Re: [PATCH v5 3/8] crypto: AF_ALG: add AEAD support

On Wed, Dec 24, 2014 at 09:54:33AM +0100, Stephan Mueller wrote: > > That is right, but isn't that the nature of AEAD ciphers in general? Even if > you are in the kernel, you need to have all scatter lists together for one > invocation of the AEAD cipher. It's actually only the nature of certai

Re: [PATCH v5 3/8] crypto: AF_ALG: add AEAD support

Am Mittwoch, 24. Dezember 2014, 09:54:33 schrieb Stephan Mueller: Hi Stephan, > Am Mittwoch, 24. Dezember 2014, 07:24:01 schrieb Herbert Xu: > > Hi Herbert, > > > On Tue, Dec 23, 2014 at 03:52:27PM +0100, Stephan Mueller wrote: > > > Am Dienstag, 23. Dezember 2014, 22:56:26 schrieb Herbert Xu: