Re: Using separate initcall level for crypto subsystem

2014-12-23 Thread Herbert Xu
On Mon, Dec 22, 2014 at 10:46:47AM -0800, Marcel Holtmann wrote: > Hi, > > we wanted to add some crypto selftests to the Bluetooth subsystem that checks > our usage of the crypto handling we use for Bluetooth Low Energy Legacy > Pairing and Secure Connections. > > Since the Crypto subsystem and

Re: [PATCH 0/5] MIPS/crypto: MD5 for OCTEON

2014-12-23 Thread Herbert Xu
On Sun, Dec 21, 2014 at 10:53:57PM +0200, Aaro Koskinen wrote: > Hi, > > This adds accelerated MD5 cryptoapi module for OCTEON. > > Tested with 3.19-rc1 on EdgeRouter Lite (OCTEON+) and EdgeRouter Pro > (OCTEON2) by running selftest, tcrypt and also by sending TCP MD5SIG > traffic between OCTEON

Re: [PATCH v5 3/8] crypto: AF_ALG: add AEAD support

2014-12-23 Thread Herbert Xu
On Tue, Dec 23, 2014 at 03:52:27PM +0100, Stephan Mueller wrote: > Am Dienstag, 23. Dezember 2014, 22:56:26 schrieb Herbert Xu: > > > In fact AEAD is rather awkward because you need to do everything > > in one go. Perhaps we could adapt our kernel interface to allow > > partial AEAD operations? >

Re: algif_hash: splice of data > 2**16

2014-12-23 Thread leroy christophe
Le 20/12/2014 07:37, Stephan Mueller a écrit : Am Donnerstag, 18. Dezember 2014, 13:22:20 schrieb leroy christophe: Hi Christophe, Le 18/12/2014 13:15, Stephan Mueller a écrit : Hi Herbert, While testing the vmsplice/splice interface of algif_hash I was made aware of the problem that data b

Re: [PATCH v5 3/8] crypto: AF_ALG: add AEAD support

2014-12-23 Thread Stephan Mueller
Am Dienstag, 23. Dezember 2014, 22:56:26 schrieb Herbert Xu: Hi Herbert, > On Tue, Dec 23, 2014 at 09:14:43AM +0100, Stephan Mueller wrote: > > - the check aead_readable() immediately before this check implements the > > blocking if we do not have sufficient data *and* more data is to be > > expe

Re: [PATCH v5 3/8] crypto: AF_ALG: add AEAD support

2014-12-23 Thread Herbert Xu
On Tue, Dec 23, 2014 at 09:14:43AM +0100, Stephan Mueller wrote: > > - the check aead_readable() immediately before this check implements the > blocking if we do not have sufficient data *and* more data is to be expected Good point. In fact AEAD is rather awkward because you need to do everythin

[PATCH] crypto: AF_ALG: zeroize key data

2014-12-23 Thread Stephan Mueller
alg_setkey should zeroize the sensitive data after use. Signed-off-by: Stephan Mueller --- crypto/af_alg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/crypto/af_alg.c b/crypto/af_alg.c index a8ff3c4..76d739d 100644 --- a/crypto/af_alg.c +++ b/crypto/af_alg.c @@ -188,7 +18

Re: [PATCH v5 5/8] crypto: AF_ALG: add user space interface for RNG

2014-12-23 Thread Stephan Mueller
Am Montag, 22. Dezember 2014, 22:27:30 schrieb Herbert Xu: Hi Herbert, > On Sun, Dec 07, 2014 at 11:23:48PM +0100, Stephan Mueller wrote: > > Allow user space to seed / reset the RNG via a setsockopt. > > > > This patch reuses alg_setkey to copy data into the kernel. The > > alg_setkey is now us

Re: [PATCH v5 3/8] crypto: AF_ALG: add AEAD support

2014-12-23 Thread Stephan Mueller
Am Montag, 22. Dezember 2014, 22:23:41 schrieb Herbert Xu: Hi Herbert, > On Sun, Dec 07, 2014 at 11:22:30PM +0100, Stephan Mueller wrote: > > +static inline bool aead_sufficient_data(struct aead_ctx *ctx) > > +{ > > + unsigned as = crypto_aead_authsize(crypto_aead_reqtfm(&ctx- >aead_req)); > >