Re: [PATCH] crypto: caam: fix error reporting

2014-11-04 Thread Kim Phillips
On Tue, 4 Nov 2014 10:57:57 +0200 Cristian Stoica wrote: > Hi Kim, > > >> Actually, our static code analyzer did not see this one. > > > > ok, so the patch technically isn't fixing anything broken, then. > > Are you saying the code isn't broken _because_ a static tool analyser > did not see an

[PATCH] crypto: drbg - add MODULE_ALIAS for all DRBG types

2014-11-04 Thread Stephan Mueller
The kernel module drbg.ko is currently not loaded automatically when a DRBG is requested by a consumer. This is due to missing MODULE_ALIAS flags for each of the implemented DRBG types. This patch adds aliases for each of the 22 defined DRBGs. Signed-off-by: Stephan Mueller --- crypto/drbg.c |

Re: [PATCH] crypto: caam: fix error reporting

2014-11-04 Thread Cristian Stoica
Hi Kim, >> Actually, our static code analyzer did not see this one. > > ok, so the patch technically isn't fixing anything broken, then. Are you saying the code isn't broken _because_ a static tool analyser did not see anything wrong here? > the new code just added a new condition, which doesn