Re: [PATCH v3 1/3] ima: use ahash API for file hash calculation

2014-07-09 Thread Dmitry Kasatkin
On 10 July 2014 00:00, Marek Vasut wrote: > On Tuesday, July 08, 2014 at 10:07:16 AM, Dmitry Kasatkin wrote: > [...] >> > Right, but my concern is not about unloading the kernel module, but >> > about the IMA module parameters left initialized. The existing code >> > will continue using ahash (so

Re: [PATCH v1 1/5] seq_file: provide an analogue of print_hex_dump()

2014-07-09 Thread Joe Perches
On Wed, 2014-07-09 at 22:39 +0200, Marek Vasut wrote: > The above function looks like almost verbatim copy of print_hex_dump(). The > only > difference I can spot is that it's calling seq_printf() instead of printk(). > Can > you not instead generalize print_hex_dump() and based on it's invocat

Re: [PATCH v1 1/5] seq_file: provide an analogue of print_hex_dump()

2014-07-09 Thread Marek Vasut
On Wednesday, July 09, 2014 at 05:24:26 PM, Andy Shevchenko wrote: > The new seq_hex_dump() is a complete analogue of print_hex_dump(). > > We have few users of this functionality already. It allows to reduce their > codebase. > > Signed-off-by: Andy Shevchenko > --- > fs/seq_file.c

Re: [PATCH v3 1/3] ima: use ahash API for file hash calculation

2014-07-09 Thread Marek Vasut
On Tuesday, July 08, 2014 at 10:07:16 AM, Dmitry Kasatkin wrote: [...] > > Right, but my concern is not about unloading the kernel module, but > > about the IMA module parameters left initialized. The existing code > > will continue using ahash (software version), even though the kernel > > module

Re: [PATCH v2] crypto: caam - fix memleak in caam_jr module

2014-07-09 Thread Marek Vasut
On Friday, July 04, 2014 at 12:54:06 AM, Kim Phillips wrote: > On Thu, 3 Jul 2014 15:07:50 +0300 > > Cristian Stoica wrote: > > This patch fixes a memory leak that appears when caam_jr module is > > unloaded. > > > > Cc: # 3.13+ > > Signed-off-by: Cristian Stoica > > --- > > > > drivers/cryp

Re: [PATCH] crypto: dts - Addition of missing SEC compatibile property in c29x device tree

2014-07-09 Thread Marek Vasut
On Tuesday, July 08, 2014 at 03:21:11 PM, Herbert Xu wrote: > On Tue, Jul 01, 2014 at 07:37:23PM +0530, Nitesh Narayan Lal wrote: > > The driver is compatible with SEC version 4.0, which was missing from > > device tree resulting that the caam driver doesn't gets probed. Since > > SEC is backward c

Re: [PATCH v1 4/5] parisc: use seq_hex_dump() to dump buffers

2014-07-09 Thread Andy Shevchenko
In one case indeed it does, in another - no, though it seems it prints same data (by meaning) in both cases. I would like driver maintainer to say a word what they think about it. On Wed, Jul 9, 2014 at 9:26 PM, Joe Perches wrote: > On Wed, 2014-07-09 at 18:24 +0300, Andy Shevchenko wrote: >> Ins

Re: [PATCH v1 0/5] fs/seq_file: introduce seq_hex_dump() helper

2014-07-09 Thread Joe Perches
On Wed, 2014-07-09 at 18:24 +0300, Andy Shevchenko wrote: > This introduces a new helper and switches current users to use it. While seq_print_hex_dump seems useful, I'm not sure existing forms can be changed to use it if any output content changes. seq_ is supposed to be a stable API. -- To un

Re: [PATCH v1 4/5] parisc: use seq_hex_dump() to dump buffers

2014-07-09 Thread Joe Perches
On Wed, 2014-07-09 at 18:24 +0300, Andy Shevchenko wrote: > Instead of custom approach let's use recently introduced seq_hex_dump() > helper. Doesn't this also change the output from to

Re: [PATCH v1 2/5] saa7164: convert to seq_hex_dump()

2014-07-09 Thread Steven Toth
On Wed, Jul 9, 2014 at 11:24 AM, Andy Shevchenko wrote: > Instead of custom approach let's use recently added seq_hex_dump() helper. > > Signed-off-by: Andy Shevchenko ack Reviewed-by: Steven Toth -- Steven Toth - Kernel Labs http://www.kernellabs.com -- To unsubscribe from this list: send t

[PATCH v1 2/5] saa7164: convert to seq_hex_dump()

2014-07-09 Thread Andy Shevchenko
Instead of custom approach let's use recently added seq_hex_dump() helper. Signed-off-by: Andy Shevchenko --- drivers/media/pci/saa7164/saa7164-core.c | 31 --- 1 file changed, 4 insertions(+), 27 deletions(-) diff --git a/drivers/media/pci/saa7164/saa7164-core.c b/

[PATCH v1 4/5] parisc: use seq_hex_dump() to dump buffers

2014-07-09 Thread Andy Shevchenko
Instead of custom approach let's use recently introduced seq_hex_dump() helper. Signed-off-by: Andy Shevchenko --- drivers/parisc/ccio-dma.c | 14 +++--- drivers/parisc/sba_iommu.c | 11 +++ 2 files changed, 6 insertions(+), 19 deletions(-) diff --git a/drivers/parisc/ccio-dma.

[PATCH v1 3/5] crypto: qat - use seq_hex_dump() to dump buffers

2014-07-09 Thread Andy Shevchenko
Instead of custom approach let's use recently introduced seq_hex_dump() helper. In this case it slightly changes the output, namely the four tetrads will be output on one line. Signed-off-by: Andy Shevchenko --- drivers/crypto/qat/qat_common/adf_transport_debug.c | 16 ++-- 1 file c

[PATCH v1 5/5] [S390] zcrypt: use seq_hex_dump() to dump buffers

2014-07-09 Thread Andy Shevchenko
Instead of custom approach let's use recently introduced seq_hex_dump() helper. In this case it slightly changes the output, namely the four tetrads will be output on one line. Signed-off-by: Andy Shevchenko --- drivers/s390/crypto/zcrypt_api.c | 10 +- 1 file changed, 1 insertion(+), 9

[PATCH v1 0/5] fs/seq_file: introduce seq_hex_dump() helper

2014-07-09 Thread Andy Shevchenko
This introduces a new helper and switches current users to use it. parisc and s390 weren't tested anyhow, the other are compile tested. Andy Shevchenko (5): seq_file: provide an analogue of print_hex_dump() saa7164: convert to seq_hex_dump() crypto: qat - use seq_hex_dump() to dump buffers

[PATCH v1 1/5] seq_file: provide an analogue of print_hex_dump()

2014-07-09 Thread Andy Shevchenko
The new seq_hex_dump() is a complete analogue of print_hex_dump(). We have few users of this functionality already. It allows to reduce their codebase. Signed-off-by: Andy Shevchenko --- fs/seq_file.c| 35 +++ include/linux/seq_file.h | 4 2 fil