Re: [PATCH v7 1/6] SP800-90A Deterministic Random Bit Generator

2014-05-25 Thread Stephan Mueller
Am Samstag, 24. Mai 2014, 05:10:07 schrieb Herbert Xu: Hi Herbert, > Stephan Mueller wrote: > > + memset(&drbg_algs[i], 0, sizeof(struct crypto_alg)); > > + if (pr) { > > + memcpy(drbg_algs[i].cra_name, "drbg(pr(", 8); > > + memcpy(drbg_algs[i].cra_driver_

Re: [PATCH v7 0/6] SP800-90A Deterministic Random Bit Generator

2014-05-25 Thread Stephan Mueller
Am Samstag, 24. Mai 2014, 05:14:59 schrieb Herbert Xu: Hi Herbert, > Stephan Mueller wrote: > > Hi, > > > > the following set of patches implements the deterministic random bit > > generator (DRBG) specified by SP800-90A. > > > > The DRBG implementation offers the following: > >* All t

Re: [PATCH 3/3] crypto: Add Allwinner Security System crypto accelerator

2014-05-25 Thread Marek Vasut
On Sunday, May 25, 2014 at 01:58:39 PM, Corentin LABBE wrote: [...] > > This is one IP block and it provides 5 algorithms. Put it under one > > config option please. > > I want to let the user choose what it want to be used. Someone could want > only to accelerate md5 and to not use the PRNG. Lo

Re: [PATCH 1/3] dt: Add DT bindings documentation for SUNXI Security System

2014-05-25 Thread Maxime Ripard
On Sat, May 24, 2014 at 09:59:30PM +0200, Marek Vasut wrote: > On Saturday, May 24, 2014 at 09:51:59 PM, Tomasz Figa wrote: > [...] > > >>> Why sun7i-a20 ? Is the crypto unit different in other sunxi chips ? Can > > >>> that not be described by DT props ? > > >> > > >> A widely used convention is

Re: [PATCH 1/3] dt: Add DT bindings documentation for SUNXI Security System

2014-05-25 Thread Maxime Ripard
On Sat, May 24, 2014 at 09:43:42PM +0200, Marek Vasut wrote: > On Saturday, May 24, 2014 at 09:20:03 PM, Tomasz Figa wrote: > > Hi Marek, > > > > On 24.05.2014 13:21, Marek Vasut wrote: > > > On Thursday, May 22, 2014 at 05:09:54 PM, LABBE Corentin wrote: > > > > > > Missing commit message. Pleas

Re: [PATCH 3/3] crypto: Add Allwinner Security System crypto accelerator

2014-05-25 Thread Corentin LABBE
Le 24/05/2014 14:00, Marek Vasut a écrit : > On Thursday, May 22, 2014 at 05:09:56 PM, LABBE Corentin wrote: > > Do I have to repeat myself ? :) No, sorry for the commit message, I begin to use git Generally I agree all your remarks with some comments below. > >> Signed-off-by: LABBE Corentin