Re: [PATCH 1/3] dt: Add DT bindings documentation for SUNXI Security System

2014-05-24 Thread Marek Vasut
On Saturday, May 24, 2014 at 09:51:59 PM, Tomasz Figa wrote: [...] > >>> Why sun7i-a20 ? Is the crypto unit different in other sunxi chips ? Can > >>> that not be described by DT props ? > >> > >> A widely used convention is to define compatible strings after first > >> SoCs on which particular IP

Re: [PATCH 1/3] dt: Add DT bindings documentation for SUNXI Security System

2014-05-24 Thread Tomasz Figa
On 24.05.2014 21:43, Marek Vasut wrote: > On Saturday, May 24, 2014 at 09:20:03 PM, Tomasz Figa wrote: >> Hi Marek, >> >> On 24.05.2014 13:21, Marek Vasut wrote: >>> On Thursday, May 22, 2014 at 05:09:54 PM, LABBE Corentin wrote: >>> >>> Missing commit message. Please fix this and send a V2. >>> >>

Re: [PATCH 1/3] dt: Add DT bindings documentation for SUNXI Security System

2014-05-24 Thread Marek Vasut
On Saturday, May 24, 2014 at 09:20:03 PM, Tomasz Figa wrote: > Hi Marek, > > On 24.05.2014 13:21, Marek Vasut wrote: > > On Thursday, May 22, 2014 at 05:09:54 PM, LABBE Corentin wrote: > > > > Missing commit message. Please fix this and send a V2. > > > >> Signed-off-by: LABBE Corentin > >> ---

Re: [PATCH 1/3] dt: Add DT bindings documentation for SUNXI Security System

2014-05-24 Thread Tomasz Figa
Hi Marek, On 24.05.2014 13:21, Marek Vasut wrote: > On Thursday, May 22, 2014 at 05:09:54 PM, LABBE Corentin wrote: > > Missing commit message. Please fix this and send a V2. > >> Signed-off-by: LABBE Corentin >> --- >> Documentation/devicetree/bindings/crypto/sunxi-ss.txt | 9 + >> 1

Re: [PATCH 3/3] crypto: Add Allwinner Security System crypto accelerator

2014-05-24 Thread Marek Vasut
On Friday, May 23, 2014 at 12:46:10 PM, Arnd Bergmann wrote: > On Thursday 22 May 2014, Corentin LABBE wrote: > > Le 22/05/2014 17:28, Arnd Bergmann a écrit : > > > On Thursday 22 May 2014 17:09:56 LABBE Corentin wrote: > > >> Signed-off-by: LABBE Corentin > > > > > > My feeling is that this shou

Re: [PATCH] crypto:caam - Define setbits32() and clrbits32() for ARM in the Freescale CAAM driver

2014-05-24 Thread Marek Vasut
On Thursday, May 01, 2014 at 10:46:50 PM, Kim Phillips wrote: > On Tue, 29 Apr 2014 15:41:39 +0530 > > Ruchika Gupta wrote: > > The kernel defines setbits32() and clrbits32() macros only for > > Power-based architectures. This patch modifies the Freescale CAAM > > driver to add macros for use on

Re: [PATCH 1/3] dt: Add DT bindings documentation for SUNXI Security System

2014-05-24 Thread Marek Vasut
On Thursday, May 22, 2014 at 05:09:54 PM, LABBE Corentin wrote: Missing commit message. Please fix this and send a V2. > Signed-off-by: LABBE Corentin > --- > Documentation/devicetree/bindings/crypto/sunxi-ss.txt | 9 + > 1 file changed, 9 insertions(+) > create mode 100644 Documentati

Re: [PATCH] crypto: x86/sha1: fix coverity CID 1195603

2014-05-24 Thread Marek Vasut
On Thursday, May 08, 2014 at 03:30:25 PM, Herbert Xu wrote: > On Wed, Apr 30, 2014 at 03:17:54PM -0400, Milos Vyletel wrote: > > Coverity detected possible use of uninitialized pointer when printing > > info message during module load. While this is higly unlikely to cause > > any troubles simple c

Re: [PATCH 3/3] crypto: Add Allwinner Security System crypto accelerator

2014-05-24 Thread Marek Vasut
On Thursday, May 22, 2014 at 05:09:56 PM, LABBE Corentin wrote: Do I have to repeat myself ? :) > Signed-off-by: LABBE Corentin > --- > drivers/crypto/Kconfig| 49 ++ > drivers/crypto/Makefile |1 + > drivers/crypto/sunxi-ss.c | 1476 > + 3

Re: [PATCH 2/3] ARM: sun7i: dt: Add Security System to A20 SoC DTS

2014-05-24 Thread Marek Vasut
On Thursday, May 22, 2014 at 05:09:55 PM, LABBE Corentin wrote: Commit message ... damn, there is a reason why you _should_ write the commit message, even if the $subject is descriptive enough. You should elaborate on what you did here and _why_ you did it. The _why_ part is also really importan

Re: [PATCH] crypto:caam - Modify width of few read only registers

2014-05-24 Thread Marek Vasut
On Thursday, May 08, 2014 at 01:54:42 AM, Kim Phillips wrote: [...] > > In the first version of guide they were defined as 64 bit. They were > > later changed to 32 bit once issue was reported while testing on > > emulator. Latest guide of LS2100 has them modified. A register width > > column has

Re: [PATCH] RSA: Don't select non-existent symbol

2014-05-24 Thread Marek Vasut
On Thursday, May 22, 2014 at 06:25:15 PM, Jean Delvare wrote: > You can select MPILIB_EXTRA all you want, it doesn't exist ;-) > > Surprised kconfig doesn't complain about that... > > Signed-off-by: Jean Delvare > Cc: Herbert Xu > Cc: "David S. Miller" > --- > crypto/asymmetric_keys/Kconfig |