[RFC PATCH 05/22] staging: crypto: skein: remove skein_port.h

2014-03-11 Thread Jason Cooper
Signed-off-by: Jason Cooper --- drivers/staging/skein/include/skein.h | 14 +++- drivers/staging/skein/include/skein_port.h | 108 - drivers/staging/skein/skein.c | 21 -- 3 files changed, 13 insertions(+), 130 deletions(-) delete mode 100644 d

[RFC PATCH 14/22] staging: crypto: skein: remove trailing whitespace

2014-03-11 Thread Jason Cooper
Signed-off-by: Jason Cooper --- drivers/staging/skein/include/skein.h| 16 +- drivers/staging/skein/include/skeinApi.h | 44 ++-- drivers/staging/skein/include/threefishApi.h | 40 - drivers/staging/skein/skeinBlockNo3F.c |

[RFC PATCH 19/22] staging: crypto: skein: remove externs from .c files

2014-03-11 Thread Jason Cooper
Signed-off-by: Jason Cooper --- drivers/staging/skein/include/skein_block.h | 22 ++ drivers/staging/skein/skein.c | 10 +- 2 files changed, 23 insertions(+), 9 deletions(-) create mode 100644 drivers/staging/skein/include/skein_block.h diff --git a/dri

[RFC PATCH 21/22] staging: crypto: skein: remove unnecessary line continuation

2014-03-11 Thread Jason Cooper
Signed-off-by: Jason Cooper --- drivers/staging/skein/skein_block.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/skein/skein_block.c b/drivers/staging/skein/skein_block.c index 707a21ae53c6..fd96ca0ad0ed 100644 --- a/drivers/staging/skein/skein_block.c +++

[RFC PATCH 09/22] staging: crypto: skein: use u8, u64 vice uint*_t

2014-03-11 Thread Jason Cooper
Signed-off-by: Jason Cooper --- drivers/staging/skein/include/skeinApi.h | 8 drivers/staging/skein/include/threefishApi.h | 22 +++--- drivers/staging/skein/skeinApi.c | 22 +++--- drivers/staging/skein/threefish1024Block.c | 18 +++

[RFC PATCH 06/22] staging: crypto: skein: remove __cplusplus and an unneeded stddef.h

2014-03-11 Thread Jason Cooper
Signed-off-by: Jason Cooper --- drivers/staging/skein/include/skein.h| 11 --- drivers/staging/skein/include/skeinApi.h | 9 - drivers/staging/skein/include/threefishApi.h | 9 - 3 files changed, 29 deletions(-) diff --git a/drivers/staging/skein/include/ske

[RFC PATCH 07/22] staging: crypto: skein: remove unneeded typedefs

2014-03-11 Thread Jason Cooper
Signed-off-by: Jason Cooper --- drivers/staging/skein/include/skein.h| 73 ++--- drivers/staging/skein/include/skeinApi.h | 4 +- drivers/staging/skein/include/skein_iv.h | 26 drivers/staging/skein/include/threefishApi.h | 6 +- drivers/staging/skein/sk

[RFC PATCH 08/22] staging: crypto: skein: remove all typedef {struct,enum}

2014-03-11 Thread Jason Cooper
Signed-off-by: Jason Cooper --- drivers/staging/skein/include/skein.h| 58 ++-- drivers/staging/skein/include/skeinApi.h | 32 +++ drivers/staging/skein/include/threefishApi.h | 32 +++ drivers/staging/skein/skein.c| 42 +

[RFC PATCH 18/22] staging: crypto: skein: wrap multi-line macros in do-while loops

2014-03-11 Thread Jason Cooper
Signed-off-by: Jason Cooper --- drivers/staging/skein/skein_block.c | 66 - 1 file changed, 51 insertions(+), 15 deletions(-) diff --git a/drivers/staging/skein/skein_block.c b/drivers/staging/skein/skein_block.c index 6e0f4a21aae3..707a21ae53c6 100644 --- a/

[RFC PATCH 17/22] staging: crypto: skein: fix brace placement errors

2014-03-11 Thread Jason Cooper
Signed-off-by: Jason Cooper --- drivers/staging/skein/include/skein.h| 30 - drivers/staging/skein/include/skein_iv.h | 65 -- drivers/staging/skein/skein.c| 111 ++- 3 files changed, 74 insertions(+), 132 deletions(-) diff --

[RFC PATCH 10/22] staging: crypto: skein: fixup pointer whitespace

2014-03-11 Thread Jason Cooper
Signed-off-by: Jason Cooper --- drivers/staging/skein/include/skein.h| 18 +- drivers/staging/skein/include/skeinApi.h | 10 +- drivers/staging/skein/include/threefishApi.h | 22 +++--- drivers/staging/skein/skeinApi.c | 18 +

[RFC PATCH 22/22] staging: crypto: skein: add TODO file

2014-03-11 Thread Jason Cooper
Signed-off-by: Jason Cooper --- drivers/staging/skein/TODO | 11 +++ 1 file changed, 11 insertions(+) create mode 100644 drivers/staging/skein/TODO diff --git a/drivers/staging/skein/TODO b/drivers/staging/skein/TODO new file mode 100644 index ..f5c167a305ae --- /dev/null ++

[RFC PATCH 04/22] staging: crypto: skein: remove brg_*.h includes

2014-03-11 Thread Jason Cooper
Signed-off-by: Jason Cooper --- drivers/staging/skein/include/brg_endian.h | 148 - drivers/staging/skein/include/brg_types.h | 131 - drivers/staging/skein/include/skein_port.h | 6 +- 3 files changed, 2 insertions(+), 283 deletions(-) dele

[RFC PATCH 20/22] staging: crypto: skein: remove braces from single-statement block

2014-03-11 Thread Jason Cooper
Signed-off-by: Jason Cooper --- drivers/staging/skein/skeinApi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/skein/skeinApi.c b/drivers/staging/skein/skeinApi.c index f0015d5b10f5..dd109bf6f7b9 100644 --- a/drivers/staging/skein/skeinApi.c +++ b/drivers

[RFC PATCH 16/22] staging: crypto: skein: fix do/while brace formatting

2014-03-11 Thread Jason Cooper
Signed-off-by: Jason Cooper --- drivers/staging/skein/skein_block.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/staging/skein/skein_block.c b/drivers/staging/skein/skein_block.c index 780b4936f783..6e0f4a21aae3 100644 --- a/drivers/staging/skein/skein_blo

[RFC PATCH 00/22] staging: add skein/threefish crypto algos

2014-03-11 Thread Jason Cooper
Greg, all, Attached is a series I've sat on for the past month and a half. I'm hoping that by posting it in it's incomplete state, it will either a) motivate me to finish hooking into the crypto API, or b) motivate someone else to pitch in. ;-) >From patch 3, all commits build successfully. In

[RFC PATCH 01/22] scripts: objdiff: detect object code changes between two commits

2014-03-11 Thread Jason Cooper
objdiff is useful when doing large code cleanups. For example, when removing checkpatch warnings and errors from new drivers in the staging tree. objdiff can be used in conjunction with a git rebase to confirm that each commit made no changes to the resulting object code. It has the same return

[RFC PATCH 03/22] staging: crypto: skein: allow building statically

2014-03-11 Thread Jason Cooper
These are the minimum changes required to get the code to build statically in the kernel. It's necessary to do this first so that we can empirically determine that future cleanup patches aren't changing the generated object code. Signed-off-by: Jason Cooper --- drivers/staging/Kconfig

Re: [PATCH] crypto: avoid module request when lookup crypto larval of template

2014-03-11 Thread joeyli
Hi Herbert, 於 一,2014-03-10 於 19:57 +0800,Herbert Xu 提到: > On Mon, Mar 10, 2014 at 05:22:51PM +0800, Lee, Chun-Yi wrote: > > When allocate crypto algorithms, e.g. crypto_alloc_shash(), using > > template model will run into the path that call module_request(). > > But there have no any module alia