RE: [PATCH 2/2] Crypto: Add support for 192 & 256 bit keys to AESNI RFC4106 - fixed whitespace

2014-03-10 Thread McCaffrey, Timothy M
Thanks. I'll get the revision for glue.c done ( and the e-mail problem fixed, probably from a different address) soon. - Tim -Original Message- From: Tim Chen [mailto:tim.c.c...@linux.intel.com] Sent: Monday, March 10, 2014 7:11 PM To: McCaffrey, Timothy M Cc: herb...@gondor

RE: [PATCH 2/2] Crypto: Add support for 192 & 256 bit keys to AESNI RFC4106 - fixed whitespace

2014-03-10 Thread Tim Chen
On Fri, 2014-03-07 at 19:56 -0600, McCaffrey, Timothy M wrote: > Ok, will generate another patch for glue.c. Since the asm doesn't verify the > aadlen or taglen either (they have a constrained set of values as well), > perhaps they should be verified by glue.c as well? > > - Tim > Ran t

Re: [PATCH 2/6] header file for DRBG

2014-03-10 Thread Rafael Aquini
On Sun, Mar 09, 2014 at 12:46:42AM +0100, Stephan Mueller wrote: > The header file includes the definition of: > > * DRBG data structures with > - struct drbg_state as main structure > - struct drbg_core referencing the backend ciphers > - struct drbg_state_ops callbach handlers

Re: [PATCH v3] crypto: omap-sham: Map SG pages if they are HIGHMEM before accessing

2014-03-10 Thread Herbert Xu
On Fri, Mar 07, 2014 at 10:28:46AM -0600, Joel Fernandes wrote: > HIGHMEM pages may not be mapped so we must kmap them before accessing. > This resolves a random OOPs error that was showing up during OpenSSL SHA > tests. > > Signed-off-by: Joel Fernandes Patch applied. Thanks! -- Email: Herbe

Re: [PATCH] crypto: caam - Dynamic memory allocation for caam_rng_ctx object

2014-03-10 Thread Herbert Xu
On Fri, Mar 07, 2014 at 06:27:58AM +, Ruchika Gupta wrote: > Acked-by: Ruchika Gupta Patch applied. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux

Re: [RFC PATCH 1/3] crypto: remove direct blkcipher_walk dependency on transform

2014-03-10 Thread Herbert Xu
On Tue, Mar 04, 2014 at 01:28:38PM +0800, Ard Biesheuvel wrote: > In order to allow other uses of the blkcipher walk API than the blkcipher > algos themselves, this patch copies some of the transform data members to the > walk struct so the transform is only accessed at walk init time. > > Signed-

Re: [PATCH][RESEND 3] hwrng: add randomness to system from rng sources

2014-03-10 Thread Herbert Xu
On Thu, Mar 06, 2014 at 07:55:33AM -0500, Jason Cooper wrote: > On Mon, Mar 03, 2014 at 03:51:48PM -0800, Kees Cook wrote: > > When bringing a new RNG source online, it seems like it would make sense > > to use some of its bytes to make the system entropy pool more random, > > as done with all sort

Re: [PATCH] crypto: mxs-dcp: Align the bounce buffers

2014-03-10 Thread Herbert Xu
On Mon, Mar 03, 2014 at 01:23:15AM +0100, Marek Vasut wrote: > The DCP needs the bounce buffers, DMA descriptors and result buffers aligned > to 64 bytes (yet another hardware limitation). Make sure they are aligned by > properly aligning the structure which contains them during allocation. > > Si

Re: [PATCH 1/3] crypto: omap-aes - Use SIMPLE_DEV_PM_OPS macro

2014-03-10 Thread Herbert Xu
On Thu, Feb 27, 2014 at 08:31:38PM +0900, Jingoo Han wrote: > Use SIMPLE_DEV_PM_OPS macro in order to make the code simpler. > > Signed-off-by: Jingoo Han All three patches applied. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herber

Re: [PATCH] crypto: omap-des - make local functions static

2014-03-10 Thread Herbert Xu
On Thu, Feb 27, 2014 at 06:59:48PM -0600, Joel Fernandes wrote: > On 02/27/2014 05:34 AM, Jingoo Han wrote: > > Make omap_des_copy_needed(), omap_des_copy_sgs(), because these > > functions are used only in this file. > > > > Signed-off-by: Jingoo Han > > Ok with me, > Acked-by: Joel Fernandes

Re: [PATCH] crypto: mxs-dcp: Optimize hashing

2014-03-10 Thread Herbert Xu
On Mon, Mar 03, 2014 at 01:40:30PM +0100, Marek Vasut wrote: > Optimize the hashing operation in the MXS-DCP by doing two adjustments: > 1) Given that the output buffer for the hash is now always correctly aligned, >we can just use the buffer for the DCP DMA to store the resulting hash. >We

Re: [PATCH] crypt: bfin_crc: Remove useless SSYNC instruction and cache flush to DMA coherent memory

2014-03-10 Thread Herbert Xu
On Wed, Feb 26, 2014 at 10:39:16AM +0800, Sonic Zhang wrote: > From: Sonic Zhang > > 1) SSYNC instruction is blackfin specific and takes no effect in this driver. > 2) DMA descriptor and SG middle buffer are in DMA coherent memory. No need > to flush. > 3) Turn kzalloc, ioremap and request_irq in

Re: [PATCH 2/2] crypto: sahara: Use return value of devm_request_irq() on error

2014-03-10 Thread Herbert Xu
On Sat, Feb 22, 2014 at 12:55:35PM +, Alexander Shiyan wrote: > Signed-off-by: Alexander Shiyan Patch 1/2 dropped since it's already in the tree. Patch 2/2 applied. Thanks! -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pu

Re: [PATCH 1/2] SHA1 transform: x86_64 AVX2 optimization - assembly code

2014-03-10 Thread Herbert Xu
On Thu, Feb 27, 2014 at 09:06:55AM -0800, chandramouli narayanan wrote: > This git patch adds x86_64 AVX2 optimization of SHA1 transform > to crypto support. The patch has been tested with 3.14.0-rc1 > kernel. > > On a Haswell desktop, with turbo disabled and all cpus running > at maximum frequenc

Re: [PATCH] crypto: avoid module request when lookup crypto larval of template

2014-03-10 Thread Herbert Xu
On Mon, Mar 10, 2014 at 05:22:51PM +0800, Lee, Chun-Yi wrote: > When allocate crypto algorithms, e.g. crypto_alloc_shash(), using > template model will run into the path that call module_request(). > But there have no any module alias that match with the template name. There aren't any but there c

RE: [PATCH] crypt: bfin_crc: Remove useless SSYNC instruction and cache flush to DMA coherent memory

2014-03-10 Thread Zhang, Sonic
PING >-Original Message- >From: Sonic Zhang [mailto:sonic@gmail.com] >Sent: Wednesday, February 26, 2014 10:39 AM >To: Herbert Xu >Cc: linux-crypto@vger.kernel.org; adi-buildroot-de...@lists.sourceforge.net; >Zhang, >Sonic >Subject: [PATCH] crypt: bfin_crc: Remove useless SSYNC instru

[PATCH] crypto: avoid module request when lookup crypto larval of template

2014-03-10 Thread Lee, Chun-Yi
When allocate crypto algorithms, e.g. crypto_alloc_shash(), using template model will run into the path that call module_request(). But there have no any module alias that match with the template name. e.g. Enable the module_request tracing event then run "modprobe tcrypt mode=10" to test, it prod